Fix facade completeness test for new coloring and lsystem exports

Make coloring/solve private (too generic for the facade namespace —
power users can require eido.gen.coloring directly). Re-export lsystem
presets using import-fn for name consistency. Add eido.gen.coloring to
the facade completeness test namespace list.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: leifericf

src/eido/gen.clj

@@ -187,12 +187,12 @@
 (import-fn coloring/color-regions)
 
 ;; lsystem presets (constrained expansion with vector alternatives)
-(def lsystem-bush lsystem/bush)
-(def lsystem-fern lsystem/fern)
-(def lsystem-coral lsystem/coral)
-(def lsystem-lightning lsystem/lightning)
-(def lsystem-seaweed lsystem/seaweed)
-(def lsystem-tree lsystem/tree)
+(import-fn lsystem/bush)
+(import-fn lsystem/fern)
+(import-fn lsystem/coral)
+(import-fn lsystem/lightning)
+(import-fn lsystem/seaweed)
+(import-fn lsystem/tree)
 
 ;; convenience helpers
 (import-fn prob/mixture)

src/eido/gen/coloring.clj

@@ -75,7 +75,7 @@
 
 ;; --- constraint solver ---
 
-(defn solve
+(defn- solve
   "Solves a graph coloring problem via CLP(FD).
   n-regions:  number of regions to color
   adjacency:  collection of [i j] pairs

test/eido/facade_test.clj

@@ -27,7 +27,7 @@
                      'eido.gen.lsystem 'eido.gen.noise 'eido.gen.particle
                      'eido.gen.prob 'eido.gen.scatter 'eido.gen.series
                      'eido.gen.stipple 'eido.gen.subdivide 'eido.gen.vary
-                     'eido.gen.voronoi])]
+                     'eido.gen.voronoi 'eido.gen.coloring])]
       (is (empty? missing)
           (str "eido.gen is missing exports: " (sort missing))))))
 

test/eido/gen/coloring_test.clj

@@ -5,43 +5,9 @@
     [eido.gen.voronoi :as voronoi]
     [eido.gen.subdivide :as subdivide]))
 
-(deftest solve-triangle-test
-  (testing "triangle (K3) needs 3 colors"
-    (let [adj #{[0 1] [1 2] [0 2]}]
-      (is (= 3 (count (distinct (coloring/solve 3 adj 3)))))
-      (is (nil? (coloring/solve 3 adj 2))))))
-
-(deftest solve-bipartite-test
-  (testing "cycle of 4 (bipartite) needs only 2 colors"
-    (let [result (coloring/solve 4 #{[0 1] [1 2] [2 3] [0 3]} 2)]
-      (is (some? result))
-      (is (every? #{0 1} result))
-      (doseq [[i j] #{[0 1] [1 2] [2 3] [0 3]}]
-        (is (not= (nth result i) (nth result j)))))))
-
-(deftest solve-no-adjacency-test
-  (testing "no edges means all regions get a valid color"
-    (is (= [0 0 0 0 0] (coloring/solve 5 #{} 3)))))
-
-(deftest solve-empty-test
-  (testing "zero regions returns nil"
-    (is (nil? (coloring/solve 0 #{} 3)))))
-
-(deftest solve-deterministic-test
-  (testing "same input gives same output"
-    (let [adj #{[0 1] [1 2] [2 3] [0 3] [0 2]}]
-      (is (= (coloring/solve 4 adj 4)
-             (coloring/solve 4 adj 4))))))
-
-(deftest solve-with-pin-test
-  (testing "pinned regions get their assigned color"
-    (let [result (coloring/solve 4 #{[0 1] [1 2] [2 3] [0 3]} 3
-                   {:pin {0 2, 2 1}})]
-      (is (some? result))
-      (is (= 2 (nth result 0)))
-      (is (= 1 (nth result 2)))
-      (doseq [[i j] #{[0 1] [1 2] [2 3] [0 3]}]
-        (is (not= (nth result i) (nth result j)))))))
+(def ^:private palette
+  [[:color/rgb 255 0 0] [:color/rgb 0 255 0]
+   [:color/rgb 0 0 255] [:color/rgb 255 255 0]])
 
 (deftest cells-adjacency-test
   (testing "4-point Voronoi produces correct adjacency"
@@ -60,14 +26,12 @@
       (is (pos? (count adj)))
       (is (every? (fn [[i j]] (< i j)) adj)))))
 
-(deftest color-regions-voronoi-test
+(deftest color-regions-basic-test
   (testing "colors Voronoi cells with no adjacent same-color"
-    (let [points  [[50 50] [150 50] [100 150] [50 150] [150 150]]
-          cells   (voronoi/voronoi-cells points [0 0 200 200])
-          adj     (coloring/cells-adjacency cells)
-          palette [[:color/rgb 255 0 0] [:color/rgb 0 255 0]
-                   [:color/rgb 0 0 255] [:color/rgb 255 255 0]]
-          result  (coloring/color-regions cells adj palette {:seed 42})]
+    (let [points [[50 50] [150 50] [100 150] [50 150] [150 150]]
+          cells  (voronoi/voronoi-cells points [0 0 200 200])
+          adj    (coloring/cells-adjacency cells)
+          result (coloring/color-regions cells adj palette {:seed 42})]
       (is (some? result))
       (is (= (count cells) (count result)))
       (is (every? :style/fill result))
@@ -77,23 +41,39 @@
 
 (deftest color-regions-seed-variety-test
   (testing "different seeds produce different colorings"
-    (let [points  [[50 50] [150 50] [100 150] [50 150] [150 150]]
-          cells   (voronoi/voronoi-cells points [0 0 200 200])
-          adj     (coloring/cells-adjacency cells)
-          palette [[:color/rgb 255 0 0] [:color/rgb 0 255 0]
-                   [:color/rgb 0 0 255] [:color/rgb 255 255 0]]
+    (let [points [[50 50] [150 50] [100 150] [50 150] [150 150]]
+          cells  (voronoi/voronoi-cells points [0 0 200 200])
+          adj    (coloring/cells-adjacency cells)
           r1 (mapv :style/fill (coloring/color-regions cells adj palette {:seed 1}))
           r2 (mapv :style/fill (coloring/color-regions cells adj palette {:seed 2}))]
       (is (not= r1 r2)))))
 
+(deftest color-regions-deterministic-test
+  (testing "same seed produces same result"
+    (let [points [[50 50] [150 50] [100 150]]
+          cells  (voronoi/voronoi-cells points [0 0 200 200])
+          adj    (coloring/cells-adjacency cells)]
+      (is (= (coloring/color-regions cells adj palette {:seed 42})
+             (coloring/color-regions cells adj palette {:seed 42}))))))
+
 (deftest color-regions-with-pin-test
   (testing "pinning specific regions to colors"
-    (let [points  [[50 50] [150 50] [100 150] [50 150] [150 150]]
-          cells   (voronoi/voronoi-cells points [0 0 200 200])
-          adj     (coloring/cells-adjacency cells)
-          palette [[:color/rgb 255 0 0] [:color/rgb 0 255 0]
-                   [:color/rgb 0 0 255] [:color/rgb 255 255 0]]
-          red     [:color/rgb 255 0 0]
-          result  (coloring/color-regions cells adj palette {:seed 1 :pin {0 red}})]
+    (let [points [[50 50] [150 50] [100 150] [50 150] [150 150]]
+          cells  (voronoi/voronoi-cells points [0 0 200 200])
+          adj    (coloring/cells-adjacency cells)
+          red    [:color/rgb 255 0 0]
+          result (coloring/color-regions cells adj palette {:seed 1 :pin {0 red}})]
       (is (some? result))
-      (is (= red (:style/fill (nth result 0)))))))
+      (is (= red (:style/fill (nth result 0))))
+      ;; Adjacency still respected
+      (doseq [[i j] adj]
+        (is (not= (:style/fill (nth result i))
+                   (:style/fill (nth result j))))))))
+
+(deftest color-regions-impossible-test
+  (testing "triangle with 2 colors returns nil"
+    (let [points [[50 50] [150 50] [100 150]]
+          cells  (voronoi/voronoi-cells points [0 0 200 200])
+          adj    (coloring/cells-adjacency cells)
+          pal2   [[:color/rgb 255 0 0] [:color/rgb 0 255 0]]]
+      (is (nil? (coloring/color-regions cells adj pal2 {:seed 42}))))))