Skip to content

Commit cc51d7e

Browse files
leifericfclaude
andcommitted
Fix latent -Wall warnings the v0.74.0 cycle introduced
Three warnings show up when an embedder builds the mino tree as a single cc invocation (mino-lsp, mino-nrepl): another /* inside a block comment in ns_env.c (the *ns* var publish helper carries the same slash-star pattern fixed earlier in install.c), an unused mino_val_t local in read_namespaced_map, and an unused env parameter on eval_declare. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent df00bed commit cc51d7e

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

src/eval/defs.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -595,6 +595,7 @@ mino_val_t *eval_declare(mino_state_t *S, mino_val_t *form,
595595
mino_val_t *args, mino_env_t *env, int tail)
596596
{
597597
mino_val_t *rest = args;
598+
(void)env;
598599
(void)tail;
599600
while (mino_is_cons(rest)) {
600601
mino_val_t *sym = rest->as.cons.car;

src/eval/read.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1505,7 +1505,6 @@ static mino_val_t *read_namespaced_map(mino_state_t *S, const char **p)
15051505
char prefix[256];
15061506
size_t prefix_len = 0;
15071507
int saw_double_colon = 0;
1508-
mino_val_t *m;
15091508
mino_val_t *out;
15101509
int line = S->reader_line;
15111510
int col = S->reader_col;

src/runtime/ns_env.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,11 @@ mino_val_t *ns_symbol_with_meta(mino_state_t *S, const char *name)
129129
return sym;
130130
}
131131

132-
/* Update clojure.core/*ns*'s root binding to a fresh symbol naming the
133-
* current namespace, so (deref (find-var 'clojure.core/*ns*)) tracks
134-
* user-visible namespace switches. No-op when the var has not yet been
135-
* interned (init order: install.c interns it after the primitives are
136-
* registered). */
132+
/* Update the clojure.core *ns* var's root binding to a fresh symbol
133+
* naming the current namespace, so deref of (find-var) on the qualified
134+
* name tracks user-visible namespace switches. No-op when the var has
135+
* not yet been interned (init order: install.c interns it after the
136+
* primitives are registered). */
137137
void mino_publish_current_ns(mino_state_t *S)
138138
{
139139
mino_val_t *var;

0 commit comments

Comments
 (0)