fix(p4): sync! applies the same exclude policy as clone!

clone! built its clj-p4.api/clone! request with :exclude derived from
resources/p4-excludes.edn, but sync! never assembled the exclude
vector — so any changelist that added a file type the user had
excluded at clone time would silently get pulled in on the next sync,
polluting the history with binary noise the policy meant to drop.

sync! now calls (compile-excludes {}) the same way clone! does and
forwards the result. Single-arg signature is unchanged; opts symmetry
with clone! is a separate concern.

Stub-based regression in p4_test intercepts api/sync! and asserts the
:exclude vector is non-empty.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: leifericf

CHANGES.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Fixes
+
+- **`noumenon.p4/sync!` applies the same exclude policy as `clone!`** — `clone!` filtered binary noise (`*.fbx`, `*.uasset`, etc. from `resources/p4-excludes.edn`) but `sync!` was building its `clj-p4.api/sync!` request without an `:exclude` field, so any new changelist that added an excluded file type would silently include it on the next sync. Sync now computes the same default exclude vector and passes it through, keeping the imported history aligned with the policy across both the initial clone and every subsequent incremental import.
+
 ## 0.10.3
 
 ### Fixes

src/noumenon/p4.clj

@@ -106,7 +106,9 @@
 
 (defn sync!
   "Bring an existing clj-p4 clone at `repo-path` up to date with Perforce.
-   Derives the stream from the most recent commit's `git-p4:` trailer."
+   Derives the stream from the most recent commit's `git-p4:` trailer.
+   Applies the same default `p4-excludes.edn` policy `clone!` uses, so
+   files excluded at clone time stay excluded on every subsequent sync."
   [repo-path]
   (let [stream (-> (last-commit-message repo-path) stream-from-trailer)]
     (when-not stream
@@ -117,6 +119,7 @@
     (api/sync! {:conn        (conn-from-env)
                 :stream      stream
                 :target      (str repo-path)
+                :exclude     (compile-excludes {})
                 :progress-fn progress-fn})
     (log! "clj-p4: sync complete")
     true))

test/noumenon/p4_test.clj

@@ -4,6 +4,7 @@
    bits: depot-path detection, clone-path derivation, exclude-defaults
    loading from `p4-excludes.edn`, and trailer parsing for sync."
   (:require [clojure.test :refer [deftest is testing]]
+            [clj-p4.api :as api]
             [noumenon.p4 :as p4]))
 
 (deftest depot-path-detection
@@ -38,3 +39,29 @@
   ;; Doesn't assert true/false — the test environment may or may not have
   ;; the p4 binary. Just check the call succeeds and returns a boolean.
   (is (boolean? (p4/available?))))
+
+(deftest sync-passes-exclude-policy
+  (testing "sync! computes the same default excludes as clone! and forwards them"
+    (let [captured (atom nil)]
+      (with-redefs [;; Stub out the trailer-parse → return a fake stream
+                    p4/depot-path? (fn [_] true)
+                    ;; Intercept the underlying clj-p4 call
+                    api/sync! (fn [m] (reset! captured m) {:synced 0})
+                    ;; Stub clj-p4.shell.proc/run-checked! so last-commit-message
+                    ;; returns a string carrying a git-p4 trailer (so sync!
+                    ;; passes its trailer-presence guard).
+                    clj-p4.shell.proc/run-checked!
+                    (fn [_ & _]
+                      {:exit 0
+                       :stdout-bytes (.getBytes (str "subject\n\n"
+                                                     "[git-p4: depot-paths = "
+                                                     \" "//stream/main/" \" ": "
+                                                     "change = 1]")
+                                                "UTF-8")
+                       :stderr "" :elapsed-ms 1})]
+        (p4/sync! "/tmp/fake-repo")
+        (let [{:keys [exclude]} @captured]
+          (is (vector? exclude)
+              "exclude vector should be present, not nil")
+          (is (pos? (count exclude))
+              "default p4-excludes.edn should produce at least one pattern"))))))