Fix CI

Author: igorshapiro

.eslintrc.js

@@ -9,7 +9,6 @@ module.exports = {
     'plugin:@typescript-eslint/eslint-recommended',
     'plugin:@typescript-eslint/recommended',
     'prettier',
-    'prettier/@typescript-eslint',
   ],
   root: true,
   env: {

.github/workflows/test.yml

@@ -7,7 +7,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [12.x, 14.x, 16.x]
+        node-version: [16.x]
     services:
       elasticmq:
         image: s12v/elasticmq

.vscode/settings.json

@@ -1,3 +1,4 @@
 {
-  "typescript.tsdk": "node_modules/typescript/lib"
-}
+  "typescript.tsdk": "node_modules/typescript/lib",
+  "editor.formatOnPaste": true
+}

Makefile

@@ -0,0 +1,4 @@
+elasticmq:
+	docker rm -f elasticmq; docker run -d -p 9324:9324 --mount type=bind,source=$(shell pwd)/.github/build/elasticmq.conf,target=/etc/elasticmq/elasticmq.conf --name elasticmq s12v/elasticmq
+e2e-test:
+	npm run test:e2e

e2e/module.e2e-spec.ts

@@ -3,21 +3,20 @@ import { SqsModule, SqsService } from '../lib';
 import { SqsConsumerOptions, SqsProducerOptions } from '../lib/sqs.types';
 import { Injectable } from '@nestjs/common';
 import { SqsConsumerEventHandler, SqsMessageHandler } from '../lib/sqs.decorators';
-import * as AWS from 'aws-sdk';
-import { promisify } from 'util';
 import waitForExpect from 'wait-for-expect';
+import { Message, SQSClient as SQS } from '@aws-sdk/client-sqs';
 
-const delay = promisify(setTimeout);
 const SQS_ENDPOINT = process.env.SQS_ENDPOINT || 'http://localhost:9324';
 
 enum TestQueue {
   Test = 'test',
   DLQ = 'test-dead',
 }
 
-const sqs = new AWS.SQS({
+const sqs = new SQS({
   apiVersion: '2012-11-05',
-  credentials: new AWS.Credentials('x', 'x'),
+  credentials: { accessKeyId: 'x', secretAccessKey: 'x'},
+  endpoint: SQS_ENDPOINT,
   region: 'none',
 });
 
@@ -37,8 +36,6 @@ const TestQueues: { [key in TestQueue]: SqsConsumerOptions | SqsProducerOptions
 describe('SqsModule', () => {
   let module: TestingModule;
 
-  describe.skip('register', () => {});
-
   describe('registerAsync', () => {
     let module: TestingModule;
 
@@ -78,17 +75,17 @@ describe('SqsModule', () => {
 
       @SqsMessageHandler(TestQueue.Test)
       // eslint-disable-next-line @typescript-eslint/no-empty-function
-      public async handleTestMessage(message: AWS.SQS.Message) {
+      public async handleTestMessage(message: Message) {
         fakeProcessor(message);
       }
 
       @SqsConsumerEventHandler(TestQueue.Test, 'processing_error')
-      public handleErrorEvent(err: Error, message: AWS.SQS.Message) {
+      public handleErrorEvent(err: Error, message: Message) {
         fakeErrorEventHandler(err, message);
       }
 
       @SqsMessageHandler(TestQueue.DLQ)
-      public async handleDLQMessage(message: AWS.SQS.Message) {
+      public async handleDLQMessage(message: Message) {
         fakeDLQProcessor(message);
       }
     }

lib/sqs-producer/producer.ts

@@ -64,7 +64,8 @@ export class Producer {
     });
 
     const result = await this.sqs.send(params);
-    const failedMessagesBatch = failedMessages.concat(result.Failed.map((entry) => entry.Id));
+    const failed = result.Failed ?? []
+    const failedMessagesBatch = failedMessages.concat(failed.map((entry) => entry.Id));
     const successfulMessagesBatch = successfulMessages.concat(result.Successful);
 
     if (endIndex < messages.length) {