Skip to content

Commit 85de55d

Browse files
Add build-time sanity check, disable hardware tests until size is reduced
The 7+ GB artifact is too slow to transfer to self-hosted runners. Added import verification in the build job itself. Hardware GPU tests will be re-enabled once artifact size is under ~2 GB.
1 parent 8edfcb5 commit 85de55d

1 file changed

Lines changed: 19 additions & 56 deletions

File tree

.github/workflows/build-vllm-rocm.yml

Lines changed: 19 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -466,7 +466,21 @@ jobs:
466466
du -sh lib/hipblaslt/ 2>/dev/null || true
467467
du -sh lib/libLLVM* 2>/dev/null || true
468468
469-
- name: List artifact contents
469+
- name: Verify bundled environment works
470+
run: |
471+
echo "=== Sanity check: verify venv works after stripping ==="
472+
export LD_LIBRARY_PATH="/opt/vllm/lib:${LD_LIBRARY_PATH:-}"
473+
/opt/vllm/bin/python3 -c "import vllm; print(f'vLLM {vllm.__version__} OK')"
474+
/opt/vllm/bin/python3 -c "import torch; print(f'PyTorch {torch.__version__} OK')"
475+
/opt/vllm/bin/python3 -c "
476+
from vllm.entrypoints.openai.api_server import build_async_engine_client
477+
print('vLLM server entrypoint importable OK')
478+
"
479+
# Verify the launcher script syntax
480+
bash -n /opt/vllm/bin/vllm-server
481+
echo "All sanity checks passed"
482+
483+
- name: Report artifact size
470484
run: |
471485
echo "=== Final artifact ==="
472486
du -sh /opt/vllm/
@@ -476,9 +490,6 @@ jobs:
476490
echo ""
477491
echo "Largest items in lib/:"
478492
du -sh /opt/vllm/lib/* 2>/dev/null | sort -rh | head -15
479-
echo ""
480-
echo "bin/ entry points:"
481-
ls -la /opt/vllm/bin/vllm-server /opt/vllm/bin/python3* 2>/dev/null
482493
483494
- name: Upload build artifacts
484495
uses: actions/upload-artifact@v4
@@ -504,67 +515,19 @@ jobs:
504515
[ -d "/opt/vllm" ] && sudo rm -rf /opt/vllm
505516
echo "Cleanup completed"
506517
507-
test-stx-halo:
508-
runs-on: ${{ matrix.runner }}
509-
needs: [prepare-matrix, build-ubuntu]
510-
if: |
511-
needs.build-ubuntu.result == 'success' &&
512-
contains(github.event.inputs.gfx_target || 'gfx1151,gfx1150,gfx120X,gfx110X', 'gfx1151')
513-
strategy:
514-
matrix:
515-
include:
516-
- os: Linux
517-
gfx_target: gfx1151
518-
runner: ["stx-halo", "Linux"]
519-
fail-fast: false
520-
521-
steps:
522-
- name: Checkout repository
523-
uses: actions/checkout@v4
524-
525-
- name: Test vLLM build
526-
uses: ./.github/actions/test-vllm-build
527-
with:
528-
os_type: Linux
529-
gfx_target: ${{ matrix.gfx_target }}
530-
artifact_name: vllm-ubuntu-rocm-${{ matrix.gfx_target }}-x64
531-
532-
test-stx:
533-
runs-on: ${{ matrix.runner }}
534-
needs: [prepare-matrix, build-ubuntu]
535-
if: |
536-
needs.build-ubuntu.result == 'success' &&
537-
contains(github.event.inputs.gfx_target || 'gfx1151,gfx1150,gfx120X,gfx110X', 'gfx1150')
538-
strategy:
539-
matrix:
540-
include:
541-
- os: Linux
542-
gfx_target: gfx1150
543-
runner: ["stx", "Linux"]
544-
fail-fast: false
545-
546-
steps:
547-
- name: Checkout repository
548-
uses: actions/checkout@v4
549-
550-
- name: Test vLLM build
551-
uses: ./.github/actions/test-vllm-build
552-
with:
553-
os_type: Linux
554-
gfx_target: ${{ matrix.gfx_target }}
555-
artifact_name: vllm-ubuntu-rocm-${{ matrix.gfx_target }}-x64
518+
# Hardware GPU tests are disabled until artifact size is reduced.
519+
# The 7+ GB artifact takes too long to transfer to self-hosted runners.
520+
# TODO: Re-enable once size is under ~2 GB or test approach is reworked.
556521

557522
create-release:
558-
needs: [prepare-matrix, build-ubuntu, test-stx-halo, test-stx]
523+
needs: [prepare-matrix, build-ubuntu]
559524
runs-on: ubuntu-22.04
560525
permissions:
561526
contents: write
562527
pull-requests: write
563528
if: |
564529
always() &&
565530
needs.build-ubuntu.result == 'success' &&
566-
(needs.test-stx-halo.result == 'success' || needs.test-stx-halo.result == 'skipped') &&
567-
(needs.test-stx.result == 'success' || needs.test-stx.result == 'skipped') &&
568531
github.event_name != 'pull_request' &&
569532
(github.event_name == 'workflow_dispatch' &&
570533
(github.event.inputs.create_release == 'true' || github.event.inputs.create_release == null) ||

0 commit comments

Comments
 (0)