Clean sql migration

Author: lenguyenthanh

modules/db/src/main/resources/db/migration/V0013__player_info_and_history_tables.sql

@@ -25,7 +25,7 @@ CREATE TABLE IF NOT EXISTS player_history (
     rapid_kfactor   integer,
     blitz           integer,
     blitz_kfactor   integer,
-    federation_id   text,
+    federation_id   text REFERENCES federations(id),
     active          boolean NOT NULL,
     created_at      timestamptz NOT NULL DEFAULT NOW(),
     updated_at      timestamptz NOT NULL DEFAULT NOW(),

modules/db/src/main/resources/db/migration/V0019__sql_cleanup.sql

@@ -127,9 +127,5 @@ DROP INDEX IF EXISTS fed_sum_rapid_players_desc_idx;
 DROP INDEX IF EXISTS fed_sum_blitz_players_desc_idx;
 DROP INDEX IF EXISTS fed_sum_players_desc_idx;
 
--- Document intentional lack of FK on player_history.federation_id
-COMMENT ON COLUMN player_history.federation_id IS
-  'No FK to federations: historical records may reference dissolved federations (e.g. YUG, URS) that are not in the federations table. The LEFT JOIN in queries handles this gracefully.';
-
 -- Refresh materialized view to pick up view changes
 REFRESH MATERIALIZED VIEW CONCURRENTLY federations_summary;

modules/db/src/test/scala/HistoryDbSuite.scala

@@ -129,10 +129,11 @@ object HistoryDbSuite extends SimpleIOSuite:
 
   test("availableMonths returns distinct sorted months"):
     resourceWithFeds.use: (historyDb, db) =>
+      val fed = NewFederation(fedId, "United States")
       for
-        _      <- db.upsert(NewPlayer(PlayerId(1), "Alice", active = true), none)
-        _      <- historyDb.insertPlayerInfo(List(playerInfo1))
-        _      <- historyDb.upsertPlayerHistory(List(mkHistory(1, jan2024), mkHistory(1, feb2024)))
+        _ <- db.upsert(NewPlayer(PlayerId(1), "Alice", active = true, federationId = fedId.some), fed.some)
+        _ <- historyDb.insertPlayerInfo(List(playerInfo1))
+        _ <- historyDb.upsertPlayerHistory(List(mkHistory(1, jan2024), mkHistory(1, feb2024)))
         months <- historyDb.availableMonths
       yield expect(months.size == 2) and
         expect(months.head == feb2024) and // DESC order
@@ -168,8 +169,9 @@ object HistoryDbSuite extends SimpleIOSuite:
   test("playerRatingHistory returns entries in DESC order"):
     val mar2024 = YearMonth(2024, 3)
     resourceWithFeds.use: (historyDb, db) =>
+      val fed = NewFederation(fedId, "United States")
       for
-        _ <- db.upsert(NewPlayer(PlayerId(1), "Alice", active = true), none)
+        _ <- db.upsert(NewPlayer(PlayerId(1), "Alice", active = true, federationId = fedId.some), fed.some)
         _ <- historyDb.insertPlayerInfo(List(playerInfo1))
         _ <- historyDb.upsertPlayerHistory(
           List(mkHistory(1, jan2024, 2700), mkHistory(1, feb2024, 2710), mkHistory(1, mar2024, 2720))
@@ -187,8 +189,9 @@ object HistoryDbSuite extends SimpleIOSuite:
   test("playerRatingHistory with since/until range"):
     val mar2024 = YearMonth(2024, 3)
     resourceWithFeds.use: (historyDb, db) =>
+      val fed = NewFederation(fedId, "United States")
       for
-        _ <- db.upsert(NewPlayer(PlayerId(1), "Alice", active = true), none)
+        _ <- db.upsert(NewPlayer(PlayerId(1), "Alice", active = true, federationId = fedId.some), fed.some)
         _ <- historyDb.insertPlayerInfo(List(playerInfo1))
         _ <- historyDb.upsertPlayerHistory(
           List(mkHistory(1, jan2024, 2700), mkHistory(1, feb2024, 2710), mkHistory(1, mar2024, 2720))
@@ -206,8 +209,9 @@ object HistoryDbSuite extends SimpleIOSuite:
   test("playerRatingHistory with pagination"):
     val mar2024 = YearMonth(2024, 3)
     resourceWithFeds.use: (historyDb, db) =>
+      val fed = NewFederation(fedId, "United States")
       for
-        _ <- db.upsert(NewPlayer(PlayerId(1), "Alice", active = true), none)
+        _ <- db.upsert(NewPlayer(PlayerId(1), "Alice", active = true, federationId = fedId.some), fed.some)
         _ <- historyDb.insertPlayerInfo(List(playerInfo1))
         _ <- historyDb.upsertPlayerHistory(
           List(mkHistory(1, jan2024, 2700), mkHistory(1, feb2024, 2710), mkHistory(1, mar2024, 2720))