Skip to content

Fix incorrect function and variable names in code space #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix incorrect function and variable names in code space #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ac08d4
proof.rs
intls Dec 20, 2024
3604f66
da-proof-checker.ts
intls Dec 20, 2024
303e945
LensHubV1Gateway.ts
intls Dec 20, 2024
3cc1b7e
LensHubV2Gateway.ts
intls Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions momoka-node/src/evm/gateway/LensHubV1Gateway.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,10 +97,10 @@ export class LensHubV1Gateway {
// we go a bespoke way so we can use our own http library and not ethers
// to be in full control
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore - use internal methods from mutlicall
// @ts-ignore - use internal methods from multicall
const calls = multicall.mapCallContextToMatchContractFormat(
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore - use internal methods from mutlicall
// @ts-ignore - use internal methods from multicall
multicall.buildAggregateCallContext([contractCallContext])
);
const encodedData = contractInterface.encodeFunctionData('tryBlockAndAggregate', [true, calls]);
Expand Down
4 changes: 2 additions & 2 deletions momoka-node/src/evm/gateway/LensHubV2Gateway.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,10 @@ export class LensHubV2Gateway {
// we go a bespoke way so we can use our own http library and not ethers
// to be in full control
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore - use internal methods from mutlicall
// @ts-ignore - use internal methods from multicall
const calls = multicall.mapCallContextToMatchContractFormat(
// eslint-disable-next-line @typescript-eslint/ban-ts-comment
// @ts-ignore - use internal methods from mutlicall
// @ts-ignore - use internal methods from multicall
multicall.buildAggregateCallContext([contractCallContext])
);
const encodedData = contractInterface.encodeFunctionData('tryBlockAndAggregate', [true, calls]);
Expand Down
8 changes: 4 additions & 4 deletions momoka-node/src/proofs/da-proof-checker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,7 @@ export class DaProofChecker {

log('event timestamp matches publication timestamp');

const validateBlockResult = await this.validateChoosenBlock(
const validateBlockResult = await this.validateChosenBlock(
daPublication.chainProofs.thisPublication.blockNumber,
daPublication.timestampProofs.response.timestamp,
ethereumNode,
Expand Down Expand Up @@ -357,7 +357,7 @@ export class DaProofChecker {
* @param log - The log function used to log debug information.
* @returns A PromiseResult containing a success result if the block is validated, or a failure with the corresponding error.
*/
private async validateChoosenBlock(
private async validateChosenBlock(
blockNumber: number,
timestamp: number,
ethereumNode: EthereumNode,
Expand Down Expand Up @@ -404,7 +404,7 @@ export class DaProofChecker {
}
}

log('compare done', { choosenBlock: closestBlock.timestamp, timestamp });
log('compare done', { chosenBlock: closestBlock.timestamp, timestamp });

//TODO look at this again
// block times are 2 seconds so this should never ever happen
Expand All @@ -414,7 +414,7 @@ export class DaProofChecker {

return success();
} catch (e) {
log('validateChoosenBlock error', e);
log('validateChosenBlock error', e);
return failure(MomokaValidatorError.UNKNOWN);
}
}
Expand Down
8 changes: 4 additions & 4 deletions momoka-rs/src/verifier/proof.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,14 +162,14 @@ async fn get_blocks(
/// # Examples
///
/// ```
/// # use momoka_rs::{is_valid_choosen_block, EthereumNode};
/// # use momoka_rs::{is_valid_chosen_block, EthereumNode};
///
/// let block_number = 42;
/// let timestamp = 1620627000;
/// let provider_context = ProviderContext{(/* ... */)};
/// let result = is_valid_choosen_block(&block_number, &timestamp, &provider_context).await;
/// let result = is_valid_chosen_block(&block_number, &timestamp, &provider_context).await;
/// ```
async fn is_valid_choosen_block(
async fn is_valid_chosen_block(
block_number: &u64,
timestamp: &u64,
provider_context: &ProviderContext,
Expand Down Expand Up @@ -371,7 +371,7 @@ async fn process_proof(
return Err(MomokaVerifierError::InvalidTypedDataDeadlineTimestamp);
}

is_valid_choosen_block(
is_valid_chosen_block(
transaction_summary.momoka_tx.block_number()?,
transaction_summary
.momoka_tx
Expand Down