Umbrella PR #101's bot reviews surfaced small valid findings against code that has since merged via the stacked slices (#104–#107). None are release-blocking; recorded here so the umbrella threads can be resolved without losing them. Each line links the original thread.
Correctness / robustness
Defense-in-depth (DB constraints)
Cost / hygiene
The Stop-button → PATCH /runs/:id wiring is deliberately NOT here — it's the stacked web resume slice (#49).
Umbrella PR #101's bot reviews surfaced small valid findings against code that has since merged via the stacked slices (#104–#107). None are release-blocking; recorded here so the umbrella threads can be resolved without losing them. Each line links the original thread.
Correctness / robustness
sanitizeTitlestrips theTitle:prefix before leading markdown, so# Title:/> Title:leak the prefix — swap strip order (Overnight: v0.1 completion + v0.2 durable-run pipeline (umbrella) #101 (comment))role: 'tool'with flattened string content for absorbed tool messages — invalid shape for the model client once tool calls are stored (Overnight: v0.1 completion + v0.2 durable-run pipeline (umbrella) #101 (comment))PATCH /runs/:idon a queued run only stampscancelRequestedAt— the single-flight slot stays occupied until pickup or deadman; consider settling queued runs terminal immediately (Overnight: v0.1 completion + v0.2 durable-run pipeline (umbrella) #101 (comment))Defense-in-depth (DB constraints)
run_eventsRLS isFOR ALL— append-only is convention, not enforced; command-specific policies or a raising trigger (Overnight: v0.1 completion + v0.2 durable-run pipeline (umbrella) #101 (comment), Overnight: v0.1 completion + v0.2 durable-run pipeline (umbrella) #101 (comment))parent_idlineage is not constrained to the same chat — composite FK/check (Overnight: v0.1 completion + v0.2 durable-run pipeline (umbrella) #101 (comment), Overnight: v0.1 completion + v0.2 durable-run pipeline (umbrella) #101 (comment))runs.user_idis not tied tochats.owner_user_idat the DB level (Overnight: v0.1 completion + v0.2 durable-run pipeline (umbrella) #101 (comment))compactions.parent_idFK lacks a supporting index (Overnight: v0.1 completion + v0.2 durable-run pipeline (umbrella) #101 (comment))Cost / hygiene
openai.chat()resolution like sibling tests (Overnight: v0.1 completion + v0.2 durable-run pipeline (umbrella) #101 (comment))The Stop-button →
PATCH /runs/:idwiring is deliberately NOT here — it's the stacked web resume slice (#49).