Skip to content

Commit 5c07a50

Browse files
committed
Fixed updateOptions with falsy value for start (#1127)
1 parent b1eb5a8 commit 5c07a50

File tree

9 files changed

+33
-9
lines changed

9 files changed

+33
-9
lines changed

CHANGELOG.MD

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
# Changelog
22

3+
### 14.6.4 (*2021-03-18*)
4+
- Fixed: Fixed `updateOptions` with falsy value for `start` (#1127);
5+
36
### 14.6.3 (*2020-11-19*)
47
- Fixed: Fixed removing namespaced event listeners, internal listeners getting removed (#1109);
58

distribute/nouislider.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! nouislider - 14.6.3 - 11/19/2020 */
1+
/*! nouislider - 14.6.4 - 3/18/2021 */
22
/* Functional styling;
33
* These styles are required for noUiSlider to function.
44
* You don't need to change these rules to apply your design.

distribute/nouislider.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/*! nouislider - 14.6.3 - 11/19/2020 */
1+
/*! nouislider - 14.6.4 - 3/18/2021 */
22
(function(factory) {
33
if (typeof define === "function" && define.amd) {
44
// AMD. Register as an anonymous module.
@@ -13,7 +13,7 @@
1313
})(function() {
1414
"use strict";
1515

16-
var VERSION = "14.6.3";
16+
var VERSION = "14.6.4";
1717

1818
//region Helper Methods
1919

@@ -2599,7 +2599,7 @@
25992599

26002600
// Invalidate the current positioning so valueSet forces an update.
26012601
scope_Locations = [];
2602-
valueSet(optionsToUpdate.start || v, fireSetEvent);
2602+
valueSet(isSet(optionsToUpdate.start) ? optionsToUpdate.start : v, fireSetEvent);
26032603
}
26042604

26052605
// Initialization steps

distribute/nouislider.min.css

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

distribute/nouislider.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nouislider",
3-
"version": "14.6.3",
3+
"version": "14.6.4",
44
"main": "distribute/nouislider.js",
55
"style": "distribute/nouislider.min.css",
66
"license": "MIT",

src/nouislider.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2598,7 +2598,7 @@
25982598

25992599
// Invalidate the current positioning so valueSet forces an update.
26002600
scope_Locations = [];
2601-
valueSet(optionsToUpdate.start || v, fireSetEvent);
2601+
valueSet(isSet(optionsToUpdate.start) ? optionsToUpdate.start : v, fireSetEvent);
26022602
}
26032603

26042604
// Initialization steps

tests/slider.html

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@
6969
<script src="slider_errors.js"></script>
7070
<script src="slider_binding.js"></script>
7171
<script src="slider_update-numbers.js"></script>
72+
<script src="slider_update_options.js"></script>
7273
<script src="slider_three_or_more_handles.js"></script>
7374
<script src="slider_contained_handles.js"></script>
7475
<script src="slider_lookaround.js"></script>

tests/slider_update_options.js

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
QUnit.test("Update options", function (assert) {
2+
3+
document.getElementById('qunit-fixture').innerHTML = '<div class="slider"></div>';
4+
5+
var slider = document.getElementById('qunit-fixture').querySelector('.slider');
6+
7+
noUiSlider.create(slider, {
8+
start: 20,
9+
range: {
10+
'min': 0,
11+
'max': 100
12+
}
13+
});
14+
15+
slider.noUiSlider.updateOptions({ start: 3 });
16+
assert.deepEqual(slider.noUiSlider.get(), "3.00");
17+
18+
slider.noUiSlider.updateOptions({ start: 0 });
19+
assert.deepEqual(slider.noUiSlider.get(), "0.00");
20+
});

0 commit comments

Comments
 (0)