Skip to content

Commit a45fa16

Browse files
author
lgersen
committed
Add getPositions to API types, allow null in types for set methods (#1270, #1271)
1 parent d647612 commit a45fa16

File tree

4 files changed

+15
-8
lines changed

4 files changed

+15
-8
lines changed

CHANGELOG.MD

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
# Changelog
22

3+
### 15.7.2 (*2024-05-14*)
4+
- Added: `getPositions` to Typescript definitions (#1270);
5+
- Added: Allow `null` in `set` Typescript definitions (#1271);
6+
37
### 15.7.1 (*2023-06-14*)
48
- Added: `module` field to `package.json` (#1247, #1248);
59

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nouislider",
3-
"version": "15.7.1",
3+
"version": "15.7.2",
44
"main": "dist/nouislider.js",
55
"module": "dist/nouislider.mjs",
66
"style": "dist/nouislider.min.css",

src/nouislider.ts

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,9 @@ type Pips = PositionsPips | ValuesPips | CountPips | StepsPips | RangePips;
113113

114114
//endregion
115115

116-
type StartValues = string | number | (string | number)[];
116+
type ValueArgument = number | string | null;
117+
118+
type StartValues = ValueArgument | ValueArgument[];
117119

118120
type HandleAttributes = { [key: string]: string };
119121

@@ -202,8 +204,8 @@ export interface API {
202204
on: (eventName: string, callback: EventCallback) => void;
203205
off: (eventName: string) => void;
204206
get: (unencoded?: boolean) => GetResult;
205-
set: (input: number | string | (number | string)[], fireSetEvent?: boolean, exactInput?: boolean) => void;
206-
setHandle: (handleNumber: number, value: number | string, fireSetEvent?: boolean, exactInput?: boolean) => void;
207+
set: (input: ValueArgument | ValueArgument[], fireSetEvent?: boolean, exactInput?: boolean) => void;
208+
setHandle: (handleNumber: number, value: ValueArgument, fireSetEvent?: boolean, exactInput?: boolean) => void;
207209
reset: (fireSetEvent?: boolean) => void;
208210
disable: (handleNumber?: number) => void;
209211
enable: (handleNumber?: number) => void;
@@ -212,6 +214,7 @@ export interface API {
212214
target: HTMLElement;
213215
removePips: () => void;
214216
removeTooltips: () => void;
217+
getPositions: () => number[];
215218
getTooltips: () => { [handleNumber: number]: HTMLElement | false };
216219
getOrigins: () => { [handleNumber: number]: HTMLElement };
217220
pips: (grid: Pips) => HTMLElement;
@@ -2740,7 +2743,7 @@ function scope(target: TargetElement, options: ParsedOptions, originalOptions: O
27402743
}
27412744

27422745
// Parses value passed to .set method. Returns current value if not parse-able.
2743-
function resolveToValue(to: null | false | undefined | string | number, handleNumber: number): number {
2746+
function resolveToValue(to: ValueArgument | false | undefined, handleNumber: number): number {
27442747
// Setting with null indicates an 'ignore'.
27452748
// Inputting 'false' is invalid.
27462749
if (to === null || to === false || to === undefined) {
@@ -2830,7 +2833,7 @@ function scope(target: TargetElement, options: ParsedOptions, originalOptions: O
28302833
// Set value for a single handle
28312834
function valueSetHandle(
28322835
handleNumber: number,
2833-
value: string | number,
2836+
value: ValueArgument,
28342837
fireSetEvent?: boolean,
28352838
exactInput?: boolean
28362839
): void {

0 commit comments

Comments
 (0)