fix(install): write host.env (JHT_HOST_TYPE) on the manual install path too

run_host_setup_vps() returned early unless a --pairing-token was present
(desktop-provisioned path), so `curl install.sh | bash` (the manual/tech
VPS path) never ran host-setup.sh → ~/.jht/host.env was never written →
the wrapper exported JHT_HOST_TYPE=unknown → pid1 booted in mode=local →
it SKIPPED the entire cloud block (push daemon + pair-on-boot + the
"Sync now" handler). Net effect: cloud sync silently dead on every
manually-installed VPS (Sync-now inert, data only via manual push).

Generalised to run_host_setup(): runs on both paths. With --pairing-token
it forces --host-type=vps (no TTY to confirm); on the manual path it runs
host-setup with no flag → detect_vps() auto-detects and, with no TTY,
writes the detected JHT_HOST_TYPE without a prompt. Applied to both the
served copy (web/public) and scripts/.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: leopu00

scripts/install.sh

@@ -843,27 +843,40 @@ save_pairing_token() {
   ok "Pairing token salvato in $token_file (mode 0644)"
 }
 
-run_host_setup_vps() {
-  # Quando install.sh arriva con --pairing-token, la macchina è una VPS
-  # provisionata dal desktop launcher: nessun utente al terminale, host-setup
-  # va lanciato non-interattivo per scrivere ~/.jht/host.env con
-  # JHT_HOST_TYPE=vps. Senza questo file il container parte in mode=local
-  # (default backwards-compat del compose) e pid1 salta il pair-on-boot.
-  [ -z "$PAIRING_TOKEN" ] && return 0
+run_host_setup() {
+  # host-setup.sh scrive ~/.jht/host.env con JHT_HOST_TYPE (+ JHT_LANG + swap).
+  # SENZA questo file il container parte in mode=local (default backwards-compat
+  # del compose) e pid1 SALTA tutto il blocco cloud — daemon push + pair-on-boot
+  # + gestore "Sync now" — quindi il cloud sync è silenziosamente morto. Va
+  # eseguito su ENTRAMBI i path d'installazione:
+  #   • desktop-provisioned (--pairing-token presente): forza --host-type=vps —
+  #     nessun utente al terminale per confermare l'auto-detection.
+  #   • manuale `curl install.sh | bash`: NESSUN flag → host-setup auto-rileva
+  #     (detect_vps) e, senza TTY, scrive il tipo rilevato senza prompt.
+  #     Regressione fixata 2026-07-09: questo path faceva `return 0` subito →
+  #     host.env mai scritto → container in mode=local → daemon cloud mai avviato.
   local hostsetup="$RUNTIME_DIR/host-setup.sh"
   if [ ! -x "$hostsetup" ]; then
-    warn "host-setup.sh non disponibile in $hostsetup — skip preflight VPS"
+    warn "host-setup.sh non disponibile in $hostsetup — skip preflight"
     return 0
   fi
   if [ "$DRY_RUN" -eq 1 ]; then
-    info "dry-run: eseguirei $hostsetup --host-type=vps"
+    info "dry-run: eseguirei $hostsetup${PAIRING_TOKEN:+ --host-type=vps}"
     return 0
   fi
-  info "Eseguo host-setup.sh in modalità VPS (scrive host.env + swap)..."
-  if "$hostsetup" --host-type=vps </dev/null; then
-    ok "host-setup VPS completato"
+  info "Eseguo host-setup.sh (scrive ~/.jht/host.env + preflight swap)..."
+  if [ -n "$PAIRING_TOKEN" ]; then
+    if "$hostsetup" --host-type=vps </dev/null; then
+      ok "host-setup completato (vps forzato)"
+    else
+      warn "host-setup uscito con errore — proseguo (pair manuale potrebbe servire)"
+    fi
   else
-    warn "host-setup VPS uscito con errore — proseguo (pair manuale potrebbe servire)"
+    if "$hostsetup" </dev/null; then
+      ok "host-setup completato (tipo host auto-rilevato)"
+    else
+      warn "host-setup uscito con errore — proseguo"
+    fi
   fi
   # Allinea ownership di ~/.jht e ~/Documents/Job Hunter Team al UID del
   # container `jht` (1001, vedi Dockerfile `useradd jht`). Senza questo,
@@ -953,7 +966,7 @@ main() {
     main_native
   fi
   save_pairing_token
-  run_host_setup_vps
+  run_host_setup
   final_message
   maybe_onboard
 }

web/public/install.sh

@@ -843,27 +843,40 @@ save_pairing_token() {
   ok "Pairing token saved to $token_file (mode 0644)"
 }
 
-run_host_setup_vps() {
-  # When install.sh arrives with --pairing-token, the machine is a VPS
-  # provisioned by the desktop launcher: no user at the terminal, host-setup
-  # must be run non-interactively to write ~/.jht/host.env with
-  # JHT_HOST_TYPE=vps. Without this file the container starts in mode=local
-  # (backwards-compat default of the compose) and pid1 skips pair-on-boot.
-  [ -z "$PAIRING_TOKEN" ] && return 0
+run_host_setup() {
+  # host-setup.sh writes ~/.jht/host.env with JHT_HOST_TYPE (+ JHT_LANG + swap).
+  # WITHOUT this file the container boots in mode=local (compose backwards-compat
+  # default) and pid1 SKIPS the entire cloud block — push daemon + pair-on-boot +
+  # the "Sync now" handler — so cloud sync is silently dead. Must run on BOTH
+  # install paths:
+  #   • desktop-provisioned (--pairing-token present): force --host-type=vps —
+  #     no user at the terminal to confirm the auto-detection.
+  #   • manual `curl install.sh | bash`: NO flag → host-setup auto-detects
+  #     (detect_vps) and, with no TTY, writes the detected type without a prompt.
+  #     Regression fixed 2026-07-09: this path used to `return 0` early → host.env
+  #     never written → container in mode=local → cloud daemon never started.
   local hostsetup="$RUNTIME_DIR/host-setup.sh"
   if [ ! -x "$hostsetup" ]; then
-    warn "host-setup.sh not available at $hostsetup — skipping VPS preflight"
+    warn "host-setup.sh not available at $hostsetup — skipping preflight"
     return 0
   fi
   if [ "$DRY_RUN" -eq 1 ]; then
-    info "dry-run: would run $hostsetup --host-type=vps"
+    info "dry-run: would run $hostsetup${PAIRING_TOKEN:+ --host-type=vps}"
     return 0
   fi
-  info "Running host-setup.sh in VPS mode (writes host.env + swap)..."
-  if "$hostsetup" --host-type=vps </dev/null; then
-    ok "VPS host-setup completed"
+  info "Running host-setup.sh (writes ~/.jht/host.env + swap preflight)..."
+  if [ -n "$PAIRING_TOKEN" ]; then
+    if "$hostsetup" --host-type=vps </dev/null; then
+      ok "host-setup completed (forced vps)"
+    else
+      warn "host-setup exited with an error — continuing (a manual pair may be needed)"
+    fi
   else
-    warn "VPS host-setup exited with an error — continuing (a manual pair may be needed)"
+    if "$hostsetup" </dev/null; then
+      ok "host-setup completed (auto-detected host type)"
+    else
+      warn "host-setup exited with an error — continuing"
+    fi
   fi
   # Align the ownership of ~/.jht and ~/Documents/Job Hunter Team with the
   # `jht` container UID (1001, see Dockerfile `useradd jht`). Without this,
@@ -953,7 +966,7 @@ main() {
     main_native
   fi
   save_pairing_token
-  run_host_setup_vps
+  run_host_setup
   final_message
   maybe_onboard
 }