Merge branch 'issue-addsAccentuationTreatmentInCheckingTheNamesOfDoiAuthors-#169' into 'master'

Removes accentuation of the authors name of submission and of DOI.

See merge request softwares-pkp/plugins_ojs/doiscielo!2

Author: AlineLepidus

classes/ScreeningChecker.inc.php

@@ -69,8 +69,11 @@ public function checkDoiFromAuthor($authorSubmission, $authorsCrossref) {
         for($i = 0; $i < count($authorsCrossref); $i++) {
             $nameAuthorCrossref = $authorsCrossref[$i]['given'] . " " . $authorsCrossref[$i]['family'];
 
-            $tokensAuthorSubmission = explode(" ", $authorSubmission);
-            $tokensAuthorCrossref = explode(" ", $nameAuthorCrossref);
+            $authorSubmissionNameWithoutAccentuation = $this->removeAccentuation($authorSubmission);
+            $authorCrossrefNameWithoutAccentuation = $this->removeAccentuation($nameAuthorCrossref);
+
+            $tokensAuthorSubmission = explode(" ", $authorSubmissionNameWithoutAccentuation);
+            $tokensAuthorCrossref = explode(" ", $authorCrossrefNameWithoutAccentuation);
 
             $firstNameAuthorSubmission = $tokensAuthorSubmission[0];
             $firstNameAuthorCrossref = $tokensAuthorCrossref[0];
@@ -119,6 +122,17 @@ public function checkAuthorSurnameWhenSingleName($tokensAuthorSubmission,$tokens
         return $equalsName;
     }
 
+    public function removeAccentuation($authorName){
+        $nameWithoutAccentuation = iconv('UTF-8', 'ASCII//TRANSLIT', $authorName);
+
+        if ($nameWithoutAccentuation == false) {
+            error_log("Failure at accent removing from author's name during DOI Screening");
+            return $authorName;
+        }
+        
+        return $nameWithoutAccentuation;
+    }
+
     public function checkDoiArticle($itemCrossref) {
         return $itemCrossref['type'] == 'journal-article';
     }

tests/ScreeningCheckerTest.php

@@ -82,11 +82,14 @@ public function testDoiAuthorNameEqualsSubmissionAuthorName(): void
 
         $authorsCrossrefCase1 =  array(array('given' => "Síntique", 'family' => "Priscila Alves Lopes")); 
         $authorsCrossrefCase2 =  array(array('given' => "Maria", 'family' => "Síntique Lopes")); 
+        $authorsCrossrefCase3 =  array(array('given' => "Yves", 'family' => "Schafer Weiss"));
 
-        $authorSubmission = "Síntique Priscila Alves Lopes";
+        $authorSubmissionCase1 = "Síntique Priscila Alves Lopes";
+        $authorSubmissionCase2 = "Yves Schäfer Weiß";
 
-        $this->assertTrue($checker->checkDoiFromAuthor($authorSubmission, $authorsCrossrefCase1));
-        $this->assertFalse($checker->checkDoiFromAuthor($authorSubmission, $authorsCrossrefCase2));
+        $this->assertTrue($checker->checkDoiFromAuthor($authorSubmissionCase1, $authorsCrossrefCase1));
+        $this->assertFalse($checker->checkDoiFromAuthor($authorSubmissionCase1, $authorsCrossrefCase2));
+        $this->assertTrue($checker->checkDoiFromAuthor($authorSubmissionCase2, $authorsCrossrefCase3));
 
     }
 
@@ -131,6 +134,30 @@ public function testDoiAuthorNameWithMiddleNameDifferentSubmissionAuthorName():
         $this->assertFalse($checker->checkDoiFromAuthor($authorSubmission, $authorsCrossref));
     }
 
+    public function testRemoveAccentuation(): void
+    {
+        $checker = new ScreeningChecker();
+        $nameResultedCase1 = $checker->removeAccentuation("Síntique Priscila Alves Lopes");
+        $nameResultedCase2 = $checker->removeAccentuation("Yves Müller Schröder");
+
+        $nameExpectedCase1 = "Sintique Priscila Alves Lopes";
+        $nameExpectedCase2 = "Yves Muller Schroder";
+
+        $this->assertEquals($nameResultedCase1,$nameExpectedCase1);
+        $this->assertEquals($nameResultedCase2,$nameExpectedCase2);
+    }
+
+    public function testDoiAuthorNameWithoutAccentuationEqualsSubmissionAuthorNameWithAccentuation(): void
+    {
+        $checker = new ScreeningChecker();
+
+        $authorsCrossref =  array(array('given' => "Sintique", 'family' => "Lopes")); 
+
+        $authorSubmission = "Síntique Priscila Alves Lopes";
+
+        $this->assertTrue($checker->checkDoiFromAuthor($authorSubmission, $authorsCrossref));
+    }
+
     public function testCheckDoiArticle(): void
     {
         $checker = new ScreeningChecker();