-
Notifications
You must be signed in to change notification settings - Fork 65
Expand file tree
/
Copy pathcomponent_test.go
More file actions
613 lines (517 loc) · 15.9 KB
/
Copy pathcomponent_test.go
File metadata and controls
613 lines (517 loc) · 15.9 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
package clockspeed
import (
"context"
"encoding/json"
"errors"
"testing"
"time"
"github.com/NVIDIA/go-nvml/pkg/nvml/mock"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
apiv1 "github.com/leptonai/gpud/api/v1"
"github.com/leptonai/gpud/components"
"github.com/leptonai/gpud/pkg/nvidia-query/nvml/device"
nvmllib "github.com/leptonai/gpud/pkg/nvidia-query/nvml/lib"
"github.com/leptonai/gpud/pkg/nvidia-query/nvml/testutil"
nvmlerrors "github.com/leptonai/gpud/pkg/nvidia/errors"
nvidiaproduct "github.com/leptonai/gpud/pkg/nvidia/product"
)
// mockNVMLInstance implements the nvidianvml.Instance interface for testing
type mockNVMLInstance struct {
devices map[string]device.Device
nvmlExists bool
}
func (m *mockNVMLInstance) NVMLExists() bool {
return m.nvmlExists
}
func (m *mockNVMLInstance) Library() nvmllib.Library {
return nil
}
func (m *mockNVMLInstance) Devices() map[string]device.Device {
return m.devices
}
func (m *mockNVMLInstance) ProductName() string {
return "test-product"
}
func (m *mockNVMLInstance) Architecture() string {
return "test-architecture"
}
func (m *mockNVMLInstance) Brand() string {
return "test-brand"
}
func (m *mockNVMLInstance) DriverVersion() string {
return "test-driver-version"
}
func (m *mockNVMLInstance) DriverMajor() int {
return 1
}
func (m *mockNVMLInstance) CUDAVersion() string {
return "test-cuda-version"
}
func (m *mockNVMLInstance) FabricManagerSupported() bool {
return true
}
func (m *mockNVMLInstance) FabricStateSupported() bool {
return false
}
func (m *mockNVMLInstance) GetMemoryErrorManagementCapabilities() nvidiaproduct.MemoryErrorManagementCapabilities {
return nvidiaproduct.MemoryErrorManagementCapabilities{}
}
func (m *mockNVMLInstance) Shutdown() error {
return nil
}
func (m *mockNVMLInstance) InitError() error {
return nil
}
// TestData_GetError tests the getError method of Data
func TestData_GetError(t *testing.T) {
// Test nil data
var nilData *checkResult
errStr := nilData.getError()
assert.Empty(t, errStr)
// Test data with error
testError := errors.New("test error")
errData := &checkResult{
err: testError,
}
errStr = errData.getError()
assert.Equal(t, testError.Error(), errStr)
// Test successful data
successData := &checkResult{
ClockSpeeds: []ClockSpeed{
{UUID: "test-uuid", GraphicsMHz: 1000, MemoryMHz: 2000},
},
}
errStr = successData.getError()
assert.Empty(t, errStr)
}
// TestData_GetStates tests the getStates method of Data
func TestData_GetStates(t *testing.T) {
// Test successful data
successData := &checkResult{
ClockSpeeds: []ClockSpeed{
{UUID: "test-uuid", GraphicsMHz: 1000, MemoryMHz: 2000},
},
}
states := successData.HealthStates()
assert.Len(t, states, 1)
assert.Equal(t, Name, states[0].Name)
// Verify ExtraInfo contains JSON data
dataJSON, ok := states[0].ExtraInfo["data"]
assert.True(t, ok)
var parsedData checkResult
err := json.Unmarshal([]byte(dataJSON), &parsedData)
assert.NoError(t, err)
assert.Equal(t, successData.ClockSpeeds, parsedData.ClockSpeeds)
}
// TestData_String tests the String method of Data
func TestData_String(t *testing.T) {
// Test nil data
var nilData *checkResult
str := nilData.String()
assert.Empty(t, str)
// Test empty data
emptyData := &checkResult{}
str = emptyData.String()
assert.Equal(t, "no data", str)
// Test with clock speeds data
dataWithClockSpeeds := &checkResult{
ClockSpeeds: []ClockSpeed{
{
UUID: "test-uuid-1",
BusID: "0000:01:00.0",
GraphicsMHz: 1000,
MemoryMHz: 2000,
ClockGraphicsSupported: true,
ClockMemorySupported: true,
},
{
UUID: "test-uuid-2",
BusID: "0000:02:00.0",
GraphicsMHz: 1500,
MemoryMHz: 3000,
ClockGraphicsSupported: false,
ClockMemorySupported: false,
},
},
}
str = dataWithClockSpeeds.String()
assert.Contains(t, str, "test-uuid-1")
assert.Contains(t, str, "0000:01:00.0")
assert.Contains(t, str, "1000 MHz")
assert.Contains(t, str, "2000 MHz")
assert.Contains(t, str, "test-uuid-2")
assert.Contains(t, str, "0000:02:00.0")
assert.Contains(t, str, "1500 MHz")
assert.Contains(t, str, "3000 MHz")
}
// TestData_Summary tests the Summary method of Data
func TestData_Summary(t *testing.T) {
// Test nil data
var nilData *checkResult
summary := nilData.Summary()
assert.Empty(t, summary)
// Test with reason
dataWithReason := &checkResult{
reason: "test reason",
}
summary = dataWithReason.Summary()
assert.Equal(t, "test reason", summary)
}
// TestData_HealthState tests the HealthState method of Data
func TestData_HealthState(t *testing.T) {
// Test nil data
var nilData *checkResult
health := nilData.HealthStateType()
assert.Empty(t, health)
// Test with health state
dataWithHealth := &checkResult{
health: apiv1.HealthStateTypeHealthy,
}
health = dataWithHealth.HealthStateType()
assert.Equal(t, apiv1.HealthStateTypeHealthy, health)
}
// TestComponent_Events tests the Events method
func TestComponent_Events(t *testing.T) {
ctx := context.Background()
c := &component{
ctx: ctx,
getTimeNowFunc: func() time.Time {
return time.Now().UTC()
},
}
events, err := c.Events(ctx, time.Now().Add(-time.Hour))
assert.NoError(t, err)
assert.Nil(t, events)
}
// TestComponent_Close tests the Close method
func TestComponent_Close(t *testing.T) {
ctx, cancel := context.WithCancel(context.Background())
c := &component{
ctx: ctx,
cancel: cancel,
getTimeNowFunc: func() time.Time {
return time.Now().UTC()
},
}
err := c.Close()
assert.NoError(t, err)
}
// TestComponent_Name tests the Name method
func TestComponent_Name(t *testing.T) {
c := &component{}
assert.Equal(t, Name, c.Name())
}
// TestTags tests the Tags method
func TestTags(t *testing.T) {
c := &component{}
expectedTags := []string{
"accelerator",
"gpu",
"nvidia",
Name,
}
tags := c.Tags()
assert.Equal(t, expectedTags, tags, "Component tags should match expected values")
assert.Len(t, tags, 4, "Component should return exactly 4 tags")
}
// TestNew tests the New function
func TestNew(t *testing.T) {
ctx := context.Background()
mockDevices := map[string]device.Device{
"test-uuid": testutil.NewMockDevice(&mock.Device{}, "test-arch", "test-brand", "1.0", "0000:00:00.0"),
}
mockInstance := &mockNVMLInstance{
devices: mockDevices,
nvmlExists: true,
}
gpudInstance := &components.GPUdInstance{
RootCtx: ctx,
NVMLInstance: mockInstance,
}
comp, err := New(gpudInstance)
require.NoError(t, err)
c, ok := comp.(*component)
require.True(t, ok)
assert.Equal(t, mockInstance, c.nvmlInstance)
assert.NotNil(t, c.getClockSpeedFunc)
assert.NotNil(t, c.ctx)
assert.NotNil(t, c.cancel)
}
// TestComponent_Start tests the Start method
func TestComponent_Start(t *testing.T) {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()
mockDevices := map[string]device.Device{
"test-uuid": testutil.NewMockDevice(&mock.Device{}, "test-arch", "test-brand", "1.0", "0000:00:00.0"),
}
mockInstance := &mockNVMLInstance{
devices: mockDevices,
nvmlExists: true,
}
c := &component{
ctx: ctx,
cancel: cancel,
nvmlInstance: mockInstance,
getClockSpeedFunc: func(uuid string, dev device.Device) (ClockSpeed, error) {
return ClockSpeed{}, nil
},
getTimeNowFunc: func() time.Time {
return time.Now().UTC()
},
}
err := c.Start()
assert.NoError(t, err)
// Allow the goroutine time to initialize
time.Sleep(100 * time.Millisecond)
}
// TestComponent_States tests the States method
func TestComponent_States(t *testing.T) {
ctx := context.Background()
// Test when lastCheckResult is nil
c := &component{
ctx: ctx,
getTimeNowFunc: func() time.Time {
return time.Now().UTC()
},
}
states := c.LastHealthStates()
assert.Len(t, states, 1)
// Test with valid data
clockSpeeds := []ClockSpeed{
{UUID: "test-uuid", GraphicsMHz: 1000, MemoryMHz: 2000},
}
c.lastCheckResult = &checkResult{
ClockSpeeds: clockSpeeds,
}
states = c.LastHealthStates()
assert.Len(t, states, 1)
dataJSON, ok := states[0].ExtraInfo["data"]
assert.True(t, ok)
var parsedData checkResult
err := json.Unmarshal([]byte(dataJSON), &parsedData)
assert.NoError(t, err)
assert.Equal(t, clockSpeeds, parsedData.ClockSpeeds)
}
// TestComponent_CheckOnce tests the CheckOnce method
func TestComponent_CheckOnce(t *testing.T) {
ctx := context.Background()
// Create mock device
mockNvmlDevice := &mock.Device{}
mockDevice := testutil.NewMockDevice(mockNvmlDevice, "test-arch", "test-brand", "1.0", "0000:00:00.0")
mockDevices := map[string]device.Device{
"test-uuid": mockDevice,
}
// Test successful case
c := &component{
ctx: ctx,
nvmlInstance: &mockNVMLInstance{
devices: mockDevices,
nvmlExists: true,
},
getClockSpeedFunc: func(uuid string, dev device.Device) (ClockSpeed, error) {
return ClockSpeed{
UUID: uuid,
GraphicsMHz: 1000,
MemoryMHz: 2000,
}, nil
},
getTimeNowFunc: func() time.Time {
return time.Now().UTC()
},
}
result := c.Check()
data, ok := result.(*checkResult)
require.True(t, ok)
// Verify that lastCheckResult was updated
require.NotNil(t, c.lastCheckResult)
assert.Len(t, c.lastCheckResult.ClockSpeeds, 1)
assert.Equal(t, "test-uuid", c.lastCheckResult.ClockSpeeds[0].UUID)
assert.Equal(t, uint32(1000), c.lastCheckResult.ClockSpeeds[0].GraphicsMHz)
assert.Equal(t, uint32(2000), c.lastCheckResult.ClockSpeeds[0].MemoryMHz)
assert.Nil(t, c.lastCheckResult.err)
assert.Equal(t, data, c.lastCheckResult)
// Test error case
testErr := errors.New("test error")
c = &component{
ctx: ctx,
nvmlInstance: &mockNVMLInstance{
devices: mockDevices,
nvmlExists: true,
},
getClockSpeedFunc: func(uuid string, dev device.Device) (ClockSpeed, error) {
return ClockSpeed{}, testErr
},
getTimeNowFunc: func() time.Time {
return time.Now().UTC()
},
}
result = c.Check()
data, ok = result.(*checkResult)
require.True(t, ok)
// Verify that lastCheckResult contains the error
require.NotNil(t, c.lastCheckResult)
assert.Len(t, c.lastCheckResult.ClockSpeeds, 0)
assert.Equal(t, testErr, c.lastCheckResult.err)
assert.Equal(t, data, c.lastCheckResult)
}
// TestComponent_Check_NilNVML tests the Check method with nil NVML instance
func TestComponent_Check_NilNVML(t *testing.T) {
ctx := context.Background()
c := &component{
ctx: ctx,
nvmlInstance: nil,
getTimeNowFunc: func() time.Time {
return time.Now().UTC()
},
}
result := c.Check()
data, ok := result.(*checkResult)
require.True(t, ok)
// Verify health state when NVML is nil
assert.Equal(t, apiv1.HealthStateTypeHealthy, data.health)
assert.Equal(t, "NVIDIA NVML instance is nil", data.reason)
assert.Nil(t, data.err)
}
// TestComponent_Check_NVMLNotLoaded tests the Check method when NVML is not loaded
func TestComponent_Check_NVMLNotLoaded(t *testing.T) {
ctx := context.Background()
c := &component{
ctx: ctx,
nvmlInstance: &mockNVMLInstance{
nvmlExists: false,
},
getTimeNowFunc: func() time.Time {
return time.Now().UTC()
},
}
result := c.Check()
data, ok := result.(*checkResult)
require.True(t, ok)
// Verify health state when NVML is not loaded
assert.Equal(t, apiv1.HealthStateTypeHealthy, data.health)
assert.Equal(t, "NVIDIA NVML library is not loaded", data.reason)
assert.Nil(t, data.err)
}
// TestComponent_Check_MultipleDevices tests the Check method with multiple devices
func TestComponent_Check_MultipleDevices(t *testing.T) {
ctx := context.Background()
// Create mock devices
mockNvmlDevice1 := &mock.Device{}
mockDevice1 := testutil.NewMockDevice(mockNvmlDevice1, "test-arch-1", "test-brand-1", "1.0", "0000:00:00.0")
mockNvmlDevice2 := &mock.Device{}
mockDevice2 := testutil.NewMockDevice(mockNvmlDevice2, "test-arch-2", "test-brand-2", "1.0", "0000:00:01.0")
mockDevices := map[string]device.Device{
"test-uuid-1": mockDevice1,
"test-uuid-2": mockDevice2,
}
c := &component{
ctx: ctx,
nvmlInstance: &mockNVMLInstance{
devices: mockDevices,
nvmlExists: true,
},
getClockSpeedFunc: func(uuid string, dev device.Device) (ClockSpeed, error) {
return ClockSpeed{
UUID: uuid,
GraphicsMHz: 1000,
MemoryMHz: 2000,
ClockGraphicsSupported: true,
ClockMemorySupported: true,
}, nil
},
getTimeNowFunc: func() time.Time {
return time.Now().UTC()
},
}
result := c.Check()
data, ok := result.(*checkResult)
require.True(t, ok)
// Verify that lastCheckResult was updated with both devices
require.NotNil(t, c.lastCheckResult)
assert.Len(t, c.lastCheckResult.ClockSpeeds, 2)
assert.Contains(t, c.lastCheckResult.reason, "2 GPU(s) were checked")
assert.Nil(t, c.lastCheckResult.err)
assert.Equal(t, data, c.lastCheckResult)
}
// TestComponent_Check_GPU_Lost tests the Check method when the GPU is lost
func TestComponent_Check_GPU_Lost(t *testing.T) {
ctx := context.Background()
mockNvmlDevice := &mock.Device{}
mockDevice := testutil.NewMockDevice(mockNvmlDevice, "test-arch", "test-brand", "1.0", "0000:00:00.0")
mockDevices := map[string]device.Device{
"test-uuid": mockDevice,
}
// Test GPU lost error
c := &component{
ctx: ctx,
nvmlInstance: &mockNVMLInstance{
devices: mockDevices,
nvmlExists: true,
},
getClockSpeedFunc: func(uuid string, dev device.Device) (ClockSpeed, error) {
return ClockSpeed{}, nvmlerrors.ErrGPULost
},
getTimeNowFunc: func() time.Time {
return time.Now().UTC()
},
}
result := c.Check()
data, ok := result.(*checkResult)
require.True(t, ok)
// Verify that lastCheckResult contains the error
require.NotNil(t, c.lastCheckResult)
assert.True(t, errors.Is(c.lastCheckResult.err, nvmlerrors.ErrGPULost))
assert.Equal(t, apiv1.HealthStateTypeUnhealthy, c.lastCheckResult.health)
assert.Equal(t, nvmlerrors.ErrGPULost.Error(), c.lastCheckResult.reason)
assert.Equal(t, data, c.lastCheckResult)
// Verify suggested actions for GPU lost case
if assert.NotNil(t, data.suggestedActions) {
assert.Equal(t, nvmlerrors.ErrGPULost.Error(), data.suggestedActions.Description)
assert.Contains(t, data.suggestedActions.RepairActions, apiv1.RepairActionTypeRebootSystem)
}
// Verify suggested actions propagates to health state output
states := c.LastHealthStates()
require.Len(t, states, 1)
assert.NotNil(t, states[0].SuggestedActions)
assert.Contains(t, states[0].SuggestedActions.RepairActions, apiv1.RepairActionTypeRebootSystem)
}
// TestComponent_Check_GPURequiresResetSuggestedActions tests the Check method when GPU requires reset
func TestComponent_Check_GPURequiresResetSuggestedActions(t *testing.T) {
ctx := context.Background()
mockNvmlDevice := &mock.Device{}
mockDevice := testutil.NewMockDevice(mockNvmlDevice, "test-arch", "test-brand", "1.0", "0000:00:00.0")
mockDevices := map[string]device.Device{
"test-uuid": mockDevice,
}
c := &component{
ctx: ctx,
nvmlInstance: &mockNVMLInstance{
devices: mockDevices,
nvmlExists: true,
},
getClockSpeedFunc: func(uuid string, dev device.Device) (ClockSpeed, error) {
return ClockSpeed{}, nvmlerrors.ErrGPURequiresReset
},
getTimeNowFunc: func() time.Time {
return time.Now().UTC()
},
}
result := c.Check()
// Verify check result carries suggested actions
data, ok := result.(*checkResult)
require.True(t, ok)
require.NotNil(t, data)
assert.Equal(t, apiv1.HealthStateTypeUnhealthy, data.health)
assert.True(t, errors.Is(data.err, nvmlerrors.ErrGPURequiresReset))
assert.Equal(t, "GPU requires reset", data.reason)
if assert.NotNil(t, data.suggestedActions) {
assert.Equal(t, "GPU requires reset", data.suggestedActions.Description)
assert.Contains(t, data.suggestedActions.RepairActions, apiv1.RepairActionTypeRebootSystem)
}
// Verify suggested actions propagates to health state output
states := c.LastHealthStates()
require.Len(t, states, 1)
assert.NotNil(t, states[0].SuggestedActions)
assert.Contains(t, states[0].SuggestedActions.RepairActions, apiv1.RepairActionTypeRebootSystem)
}