Skip to content

Commit c00e930

Browse files
committed
fix
Signed-off-by: Gyuho Lee <gyuhol@nvidia.com>
1 parent 2cd987c commit c00e930

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

components/accelerator/nvidia/nccl/component_test.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,6 +174,7 @@ func TestCheck(t *testing.T) {
174174
t.Run("nvml exists but no product name", func(t *testing.T) {
175175
mockNvml := new(mockNVMLInstance)
176176
mockNvml.On("NVMLExists").Return(true)
177+
mockNvml.On("InitError").Return(nil)
177178
mockNvml.On("ProductName").Return("")
178179

179180
comp := &component{
@@ -201,6 +202,7 @@ func TestCheck(t *testing.T) {
201202
t.Run("nil readAllKmsg", func(t *testing.T) {
202203
mockNvml := new(mockNVMLInstance)
203204
mockNvml.On("NVMLExists").Return(true)
205+
mockNvml.On("InitError").Return(nil)
204206
mockNvml.On("ProductName").Return("Test GPU")
205207
mockNvml.On("Devices").Return(map[string]device.Device{})
206208
mockNvml.On("GetMemoryErrorManagementCapabilities").Return(nvidiaproduct.MemoryErrorManagementCapabilities{})
@@ -218,6 +220,7 @@ func TestCheck(t *testing.T) {
218220
t.Run("readAllKmsg returns error", func(t *testing.T) {
219221
mockNvml := new(mockNVMLInstance)
220222
mockNvml.On("NVMLExists").Return(true)
223+
mockNvml.On("InitError").Return(nil)
221224
mockNvml.On("ProductName").Return("Test GPU")
222225
mockNvml.On("Devices").Return(map[string]device.Device{})
223226
mockNvml.On("GetMemoryErrorManagementCapabilities").Return(nvidiaproduct.MemoryErrorManagementCapabilities{})
@@ -240,6 +243,7 @@ func TestCheck(t *testing.T) {
240243
t.Run("no matching messages", func(t *testing.T) {
241244
mockNvml := new(mockNVMLInstance)
242245
mockNvml.On("NVMLExists").Return(true)
246+
mockNvml.On("InitError").Return(nil)
243247
mockNvml.On("ProductName").Return("Test GPU")
244248
mockNvml.On("Devices").Return(map[string]device.Device{})
245249
mockNvml.On("GetMemoryErrorManagementCapabilities").Return(nvidiaproduct.MemoryErrorManagementCapabilities{})
@@ -266,6 +270,7 @@ func TestCheck(t *testing.T) {
266270
t.Run("with matching messages", func(t *testing.T) {
267271
mockNvml := new(mockNVMLInstance)
268272
mockNvml.On("NVMLExists").Return(true)
273+
mockNvml.On("InitError").Return(nil)
269274
mockNvml.On("ProductName").Return("Test GPU")
270275
mockNvml.On("Devices").Return(map[string]device.Device{})
271276
mockNvml.On("GetMemoryErrorManagementCapabilities").Return(nvidiaproduct.MemoryErrorManagementCapabilities{})
@@ -577,6 +582,7 @@ func TestCheck_NVML_NoProductName(t *testing.T) {
577582

578583
mockNvml := new(mockNVMLInstance)
579584
mockNvml.On("NVMLExists").Return(true)
585+
mockNvml.On("InitError").Return(nil)
580586
mockNvml.On("ProductName").Return("")
581587

582588
comp := &component{

0 commit comments

Comments
 (0)