ci(helm): derive chart versions from git tags (#1273)

Author: gyuho

.github/workflows/docker.yaml

@@ -3,7 +3,7 @@ name: Docker image release
 "on":
   push:
     tags:
-      - "*"
+      - "v*.*.*"
 
 permissions:
   contents: read
@@ -30,6 +30,10 @@ jobs:
       - name: Build and push image
         shell: bash
         run: |
+          image=nvcr.io/nvstaging/lepton/gpud
+          version="${GITHUB_REF_NAME#v}"
+
           ./scripts/build-docker.sh \
-            --tag "nvcr.io/nvstaging/lepton/gpud:${GITHUB_REF_NAME#v}" \
+            --tag "$image:$version" \
+            --tag "$image:latest" \
             --push

.github/workflows/helm.yaml

@@ -2,8 +2,8 @@ name: Helm chart release
 
 "on":
   push:
-    branches:
-      - main
+    tags:
+      - "v*.*.*"
 
 permissions:
   contents: write
@@ -29,15 +29,18 @@ jobs:
           chart=deployments/helm/gpud
           pages_dir="$RUNNER_TEMP/gh-pages"
           name="$(awk '$1 == "name:" { print $2; exit }' "$chart/Chart.yaml")"
-          version="$(awk '$1 == "version:" { print $2; exit }' "$chart/Chart.yaml")"
+          version="${GITHUB_REF_NAME#v}"
           package="$pages_dir/$name-$version.tgz"
 
           git fetch origin gh-pages:refs/remotes/origin/gh-pages
           git worktree add --detach "$pages_dir" origin/gh-pages
 
           if [[ ! -f "$package" || ! -f "$pages_dir/index.yaml" ]]; then
             if [[ ! -f "$package" ]]; then
-              helm package "$chart" --destination "$pages_dir"
+              helm package "$chart" \
+                --version "$version" \
+                --app-version "$version" \
+                --destination "$pages_dir"
             fi
             helm repo index "$pages_dir" --url https://leptonai.github.io/gpud
           fi

deployments/helm/gpud/Chart.yaml

@@ -2,6 +2,7 @@ apiVersion: v2
 name: gpud
 description: GPUd Helm chart for Kubernetes
 type: application
-version: 0.12.7
-appVersion: "0.12.7"
+# Overridden from the pushed git tag by the release workflow.
+version: 0.0.0
+appVersion: "latest"
 icon: https://assets.nvidiagrid.net/ngc/logos/Infrastructure.png

scripts/build-docker.sh

@@ -17,7 +17,7 @@
 # OPTIONS
 # ==============================================================================
 #
-#   --tag TAG           Docker image tag (required)
+#   --tag TAG           Docker image tag (required, repeatable)
 #   --platform PLAT     Target platforms (default: linux/amd64,linux/arm64)
 #   --os-name NAME      Base OS name (default: ubuntu)
 #   --os-version VER    Base OS version (default: 22.04)
@@ -132,7 +132,7 @@ PLATFORMS="linux/amd64,linux/arm64"
 OS_NAME="ubuntu"
 OS_VERSION="22.04"
 CUDA_VERSION="12.4.1"
-TAG=""
+TAGS=()
 PUSH=false
 LOAD=false
 NO_CACHE=false
@@ -174,7 +174,7 @@ show_help() {
 while [[ $# -gt 0 ]]; do
     case $1 in
         --tag)
-            TAG="$2"
+            TAGS+=("$2")
             shift 2
             ;;
         --platform)
@@ -220,10 +220,11 @@ while [[ $# -gt 0 ]]; do
 done
 
 # Validate required arguments
-if [[ -z "$TAG" ]]; then
+if [[ ${#TAGS[@]} -eq 0 ]]; then
     log_error "Docker image tag is required. Use --tag to specify."
     exit 1
 fi
+TAG="${TAGS[0]}"
 
 # Check for Dockerfile
 if [[ ! -f "$PROJECT_ROOT/Dockerfile" ]]; then
@@ -250,44 +251,42 @@ if [[ "$LOAD" == "true" && "$PLATFORMS" == *","* ]]; then
 fi
 
 # Build the command
-BUILD_CMD="docker buildx build"
-
-# Add platform
-BUILD_CMD="$BUILD_CMD --platform $PLATFORMS"
-
-# Add build args
-BUILD_CMD="$BUILD_CMD --build-arg OS_NAME=$OS_NAME"
-BUILD_CMD="$BUILD_CMD --build-arg OS_VERSION=$OS_VERSION"
-BUILD_CMD="$BUILD_CMD --build-arg CUDA_VERSION=$CUDA_VERSION"
-
-# Add tag
-BUILD_CMD="$BUILD_CMD -t $TAG"
+BUILD_CMD=(
+    docker buildx build
+    --platform "$PLATFORMS"
+    --build-arg "OS_NAME=$OS_NAME"
+    --build-arg "OS_VERSION=$OS_VERSION"
+    --build-arg "CUDA_VERSION=$CUDA_VERSION"
+)
+
+for tag in "${TAGS[@]}"; do
+    BUILD_CMD+=(--tag "$tag")
+done
 
-# Add Dockerfile
-BUILD_CMD="$BUILD_CMD -f $PROJECT_ROOT/Dockerfile"
+BUILD_CMD+=(-f "$PROJECT_ROOT/Dockerfile")
 
 # Add optional flags
 if [[ "$PUSH" == "true" ]]; then
-    BUILD_CMD="$BUILD_CMD --push"
+    BUILD_CMD+=(--push)
 fi
 
 if [[ "$LOAD" == "true" ]]; then
-    BUILD_CMD="$BUILD_CMD --load"
+    BUILD_CMD+=(--load)
 fi
 
 if [[ "$NO_CACHE" == "true" ]]; then
-    BUILD_CMD="$BUILD_CMD --no-cache"
+    BUILD_CMD+=(--no-cache)
 fi
 
 # Add context
-BUILD_CMD="$BUILD_CMD $PROJECT_ROOT"
+BUILD_CMD+=("$PROJECT_ROOT")
 
 # Print build information
 echo ""
 log_info "========================================"
 log_info "GPUd Docker Build"
 log_info "========================================"
-log_info "Tag:          $TAG"
+log_info "Tags:         ${TAGS[*]}"
 log_info "Platforms:    $PLATFORMS"
 log_info "OS:           $OS_NAME $OS_VERSION"
 log_info "CUDA Version: $CUDA_VERSION"
@@ -300,11 +299,11 @@ echo ""
 
 log_step "Building Docker image..."
 echo ""
-log_info "Command: $BUILD_CMD"
+log_info "Command: ${BUILD_CMD[*]}"
 echo ""
 
 # Execute build
-eval "$BUILD_CMD"
+"${BUILD_CMD[@]}"
 
 BUILD_STATUS=$?