Skip to content

feat(nbhttp): Implement http.Flusher for streaming support #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lesismal merged 1 commit into from
Aug 8, 2025
Merged

feat(nbhttp): Implement http.Flusher for streaming support #487

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 68 additions & 12 deletions nbhttp/response.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,31 +345,87 @@ func (res *Response) ReadFrom(r io.Reader) (n int64, err error) {
return io.Copy(c, r)
}

// Push implements the http.Pusher interface.
// It is not supported by nbhttp, so it always returns an error.
//
//go:norace
func (res *Response) Push(target string, opts *http.PushOptions) error {
return errors.New("http: server push not supported")
}

// Flush implements http.Flusher. It sends any buffered data to the client.
//
//go:norace
func (res *Response) Flush() {
if res.hijacked {
return
}
if res.Parser == nil || res.Parser.Conn == nil {
return
}

res.WriteHeader(http.StatusOK)
res.checkChunked()
res.eoncodeHead()

conn := res.Parser.Conn

if res.buffer != nil && len(*res.buffer) > 0 {
_, err := conn.Write(*res.buffer)
if err != nil {
logging.Error("Response.Flush: buffer write failed: %v", err)
mempool.Free(res.buffer)
res.buffer = nil
} else {
*res.buffer = (*res.buffer)[:0]
}
}

if res.bodyBuffer != nil && len(*res.bodyBuffer) > 0 {
_, err := conn.Write(*res.bodyBuffer)
if err != nil {
logging.Error("Response.Flush: bodyBuffer write failed: %v", err)
mempool.Free(res.bodyBuffer)
res.bodyBuffer = nil
} else {
*res.bodyBuffer = (*res.bodyBuffer)[:0]
}
}
}

// checkChunked .
//
//go:norace
func (res *Response) checkChunked() {
if res.chunkChecked {
return
}

res.chunkChecked = true

if res.request.ProtoAtLeast(1, 1) {
for _, v := range res.header[transferEncodingHeader] {
if v == "chunked" {
res.chunked = true
}
// 1. See if chunking is already set
for _, v := range res.header[transferEncodingHeader] {
if v == "chunked" {
res.chunked = true
delete(res.header, contentLengthHeader)
return
}
if !res.chunked {
if len(res.header[trailerHeader]) > 0 {
res.chunked = true
hs := res.header[transferEncodingHeader]
res.header[transferEncodingHeader] = append(hs, "chunked")
}
}

// 2. See if we should fall back to chunking
if res.request.ProtoAtLeast(1, 1) && res.header.Get(contentLengthHeader) == "" {
// Don't chunk for responses that are forbidden from having a body
if res.statusCode != http.StatusNoContent && res.statusCode != http.StatusNotModified {
res.chunked = true
}
}

// 3. See if we need to chunk for trailers
if !res.chunked && len(res.header[trailerHeader]) > 0 {
res.chunked = true
}

if res.chunked {
res.header.Set(transferEncodingHeader, "chunked")
delete(res.header, contentLengthHeader)
}
}
Expand Down
Loading