fix: ADR 0017 CI failures — move build tests to adapter-vite, fix paths

SisyphusZheng · SisyphusZheng · commit 903f957f60f6 · 2026-05-11T21:00:10.000+08:00
- Move 14 build orchestration tests from core/__tests__/ to adapter-vite/__tests__/
- Fix import paths: @lessjs/core/errors, context, ssr-handler in adapter-vite tests
- Fix buildCoreSubpathAliases() relative path: ../core/src → ../../core/src
- Add @lessjs/core/context export to core deno.json
- Remove stale @lessjs/core/build-context import from adapter-vite deno.json
- Update create CLI: jsr:@lessjs/core/cli → jsr:@lessjs/adapter-vite/cli
- Add @lessjs/adapter-vite to PKG_DIR_MAP in create CLI
- Add adapter-vite test job to .github/workflows/test.yml
- Dedupe headExtras &lt;script&gt; warning in html-escape.ts
- Fix entry-descriptor test: @lessjs/core/render-dsd (not adapter-vite)
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -23,7 +23,7 @@ jobs:
       - name: Install dependencies
         run: deno install --node-modules-dir
       - name: Run type check
-        run: deno check packages/core/src/index.ts packages/rpc/src/index.ts packages/ui/src/index.ts packages/adapter-lit/src/index.ts packages/adapter-lit/src/ssr.ts packages/signals/src/index.ts packages/create/cli.ts packages/app/src/index.ts packages/i18n/src/index.ts packages/content/src/index.ts
+        run: deno check packages/core/src/index.ts packages/rpc/src/index.ts packages/ui/src/index.ts packages/adapter-lit/src/index.ts packages/adapter-lit/src/ssr.ts packages/adapter-vite/src/index.ts packages/signals/src/index.ts packages/create/cli.ts packages/app/src/index.ts packages/i18n/src/index.ts packages/content/src/index.ts
 
   test-core:
     runs-on: ubuntu-latest
@@ -42,6 +42,23 @@ jobs:
       - name: Run core tests
         run: deno test packages/core/__tests__/ --allow-read --allow-write --allow-env --allow-run --allow-ffi
 
+  test-adapter-vite:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: denoland/setup-deno@v2
+        with:
+          deno-version: '2'
+      - name: Cache dependencies
+        uses: actions/cache@v4
+        with:
+          path: node_modules
+          key: ${{ runner.os }}-deno-${{ hashFiles('deno.lock') }}
+      - name: Install dependencies
+        run: deno install --node-modules-dir
+      - name: Run adapter-vite tests
+        run: deno test packages/adapter-vite/__tests__/ --allow-read --allow-write --allow-env --allow-run --allow-ffi
+
   test-rpc:
     runs-on: ubuntu-latest
     steps:
diff --git a/packages/adapter-vite/__tests__/build-context.test.ts b/packages/adapter-vite/__tests__/build-context.test.ts
@@ -1,5 +1,5 @@
 /**
- * @lessjs/core - build-context.ts tests (Deno)
+ * @lessjs/adapter-vite - build-context.ts tests (Deno)
  */
 import { assertEquals, assertExists } from 'jsr:@std/assert@^1.0.0';
 import { LessBuildContext } from '../src/build-context.ts';
diff --git a/packages/adapter-vite/__tests__/build-manifest.test.ts b/packages/adapter-vite/__tests__/build-manifest.test.ts
@@ -1,5 +1,5 @@
 /**
- * @lessjs/core - build-manifest.ts tests (Deno)
+ * @lessjs/adapter-vite - build-manifest.ts tests (Deno)
  *
  * Tests build manifest scanning and formatting using temp directories.
  */
diff --git a/packages/adapter-vite/__tests__/build.test.ts b/packages/adapter-vite/__tests__/build.test.ts
@@ -1,6 +1,6 @@
 // deno-lint-ignore-file no-explicit-any
 /**
- * @lessjs/core - build / entry-generators tests (Deno)
+ * @lessjs/adapter-vite - build / entry-generators tests (Deno)
  *
  * ADR 0011: closeBundle writes metadata to ctx, not .less/build-metadata.json.
  * Tests verify LessBuildContext fields instead of filesystem.
diff --git a/packages/adapter-vite/__tests__/entry-descriptor.test.ts b/packages/adapter-vite/__tests__/entry-descriptor.test.ts
@@ -1,5 +1,5 @@
 /**
- * @lessjs/core - Entry descriptor + renderer tests (Deno)
+ * @lessjs/adapter-vite - Entry descriptor + renderer tests (Deno)
  *
  * Tests the two-step entry pipeline:
  *   1. buildEntryDescriptor — produces structured data
@@ -10,7 +10,7 @@
 
 import { assertEquals, assertStringIncludes } from 'jsr:@std/assert@^1.0.0';
 import { buildEntryDescriptor, generateHonoEntryCode, renderEntry } from '../src/hono-entry.ts';
-import type { RouteEntry } from '../src/types.ts';
+import type { RouteEntry } from '@lessjs/core';
 
 // ─── Test fixtures ─────────────────────────────────────────────
 
diff --git a/packages/adapter-vite/__tests__/entry-generators.test.ts b/packages/adapter-vite/__tests__/entry-generators.test.ts
diff --git a/packages/adapter-vite/__tests__/entry-renderer.test.ts b/packages/adapter-vite/__tests__/entry-renderer.test.ts
@@ -1,5 +1,5 @@
 /**
- * @lessjs/core - Entry renderer snapshot tests (Deno)
+ * @lessjs/adapter-vite - Entry renderer snapshot tests (Deno)
  *
  * Snapshot tests for renderEntry output covering:
  * - CSP middleware (with/without nonce)
@@ -16,7 +16,7 @@ import {
   assertStringIncludes,
 } from 'jsr:@std/assert@^1.0.0';
 import { buildEntryDescriptor, generateHonoEntryCode, renderEntry } from '../src/hono-entry.ts';
-import type { RouteEntry } from '../src/types.ts';
+import type { RouteEntry } from '@lessjs/core';
 
 // Fixtures
 
diff --git a/packages/adapter-vite/__tests__/index-plugin.test.ts b/packages/adapter-vite/__tests__/index-plugin.test.ts
@@ -1,10 +1,10 @@
-// deno-lint-ignore-file no-unused-vars ban-types
 /**
- * @lessjs/core - index.ts main entry tests (Deno)
+ * @lessjs/adapter-vite - index.ts main entry tests (Deno)
  *
  * Tests that less() plugin factory returns a valid plugin array
  * with correct structure and re-exports.
  */
+// deno-lint-ignore-file no-unused-vars ban-types
 import {
   assertArrayIncludes,
   assertEquals,
@@ -14,12 +14,10 @@ import {
 import { join } from 'node:path';
 import { less } from '../src/index.ts';
 
-// Verify re-exports exist (compile-time)
-import { LessError, SsrRenderError } from '../src/errors.ts';
-
-import { createSsrContext, extractParams, parseQuery } from '../src/context.ts';
-
-import { renderSsrError, wrapInDocument } from '../src/ssr-handler.ts';
+// Verify core re-exports work (imported via @lessjs/core subpaths)
+import { LessError, SsrRenderError } from '@lessjs/core/errors';
+import { createSsrContext, extractParams, parseQuery } from '@lessjs/core/context';
+import { renderSsrError, wrapInDocument } from '@lessjs/core/ssr-handler';
 
 import { buildIslandChunkMap, injectClientScript, injectCspMeta } from '../src/ssg-postprocess.ts';
 
diff --git a/packages/adapter-vite/__tests__/island-manifest.test.ts b/packages/adapter-vite/__tests__/island-manifest.test.ts
diff --git a/packages/adapter-vite/__tests__/island-transform.test.ts b/packages/adapter-vite/__tests__/island-transform.test.ts
@@ -1,5 +1,5 @@
 /**
- * @lessjs/core - island-transform.ts tests (Deno)
+ * @lessjs/adapter-vite - island-transform.ts tests (Deno)
  */
 import { assertEquals } from 'jsr:@std/assert@^1.0.0';
 import { islandTransformPlugin } from '../src/island-transform.ts';
diff --git a/packages/adapter-vite/__tests__/route-scanner.test.ts b/packages/adapter-vite/__tests__/route-scanner.test.ts
@@ -1,5 +1,5 @@
 /**
- * @lessjs/core - route-scanner.ts tests (Deno)
+ * @lessjs/adapter-vite - route-scanner.ts tests (Deno)
  */
 import { assertEquals } from 'jsr:@std/assert@^1.0.0';
 import { join } from 'jsr:@std/path@^1.0.0';
@@ -189,8 +189,7 @@ Deno.test({
 
     await t.step('throws LessError for non-existent package', async () => {
       const { scanPackageIslands } = await import('../src/route-scanner.ts');
-      const { LessError } = await import('../src/errors.ts');
-      // Non-existent package should throw — misconfigured packages must break the build
+      const { LessError } = await import('@lessjs/core/errors'); // Non-existent package should throw — misconfigured packages must break the build
       try {
         await scanPackageIslands(['@nonexistent/package']);
         // Should not reach here
@@ -215,8 +214,7 @@ Deno.test({
 
     await t.step('throws LessError for package with import errors', async () => {
       const { scanPackageIslands } = await import('../src/route-scanner.ts');
-      const { LessError } = await import('../src/errors.ts');
-      // A package that exists but fails to import should throw
+      const { LessError } = await import('@lessjs/core/errors'); // A package that exists but fails to import should throw
       try {
         await scanPackageIslands(['vite']);
         // If vite imports successfully but has no islands, that's OK
diff --git a/packages/adapter-vite/__tests__/ssg-integration.test.ts b/packages/adapter-vite/__tests__/ssg-integration.test.ts
@@ -1,5 +1,5 @@
 /**
- * @lessjs/core - SSG integration tests (Deno)
+ * @lessjs/adapter-vite - SSG integration tests (Deno)
  *
  * Tests the SSG post-processing pipeline:
  *   1. buildIslandChunkMap — scan client build output → tagName → chunk path mapping
diff --git a/packages/adapter-vite/__tests__/ssg-postprocess.test.ts b/packages/adapter-vite/__tests__/ssg-postprocess.test.ts
@@ -1,5 +1,5 @@
 /**
- * @lessjs/core - ssg-postprocess.ts tests (Deno)
+ * @lessjs/adapter-vite - ssg-postprocess.ts tests (Deno)
  *
  * Tests the SSG post-processing functions using temp directories.
  */
diff --git a/packages/adapter-vite/__tests__/ssg-smoke.test.ts b/packages/adapter-vite/__tests__/ssg-smoke.test.ts
@@ -1,5 +1,5 @@
 /**
- * @lessjs/core - SSG smoke build test
+ * @lessjs/adapter-vite - SSG smoke build test
  *
  * End-to-end verification of the official one-command build path:
  *   deno task build
diff --git a/packages/adapter-vite/__tests__/static-paths.test.ts b/packages/adapter-vite/__tests__/static-paths.test.ts
@@ -9,7 +9,7 @@
 
 import { assertEquals } from 'jsr:@std/assert@^1.0.0';
 import { buildEntryDescriptor } from '../src/entry-descriptor.ts';
-import type { RouteEntry } from '../src/types.ts';
+import type { RouteEntry } from '@lessjs/core';
 
 // ─── Helper: create a RouteEntry ──────────────────────────────
 
diff --git a/packages/adapter-vite/deno.json b/packages/adapter-vite/deno.json
@@ -12,12 +12,12 @@
     "@lessjs/core": "jsr:@lessjs/core@^0.11",
     "@lessjs/core/logger": "jsr:@lessjs/core@^0.11/logger",
     "@lessjs/core/errors": "jsr:@lessjs/core@^0.11/errors",
+    "@lessjs/core/context": "jsr:@lessjs/core@^0.11/context",
     "@lessjs/core/render-dsd": "jsr:@lessjs/core@^0.11/render-dsd",
     "@lessjs/core/html-escape": "jsr:@lessjs/core@^0.11/html-escape",
     "@lessjs/core/adapter-registry": "jsr:@lessjs/core@^0.11/adapter-registry",
     "@lessjs/core/ssr-handler": "jsr:@lessjs/core@^0.11/ssr-handler",
     "@lessjs/core/navigation": "jsr:@lessjs/core@^0.11/navigation",
-    "@lessjs/core/build-context": "jsr:@lessjs/core@^0.11/build-context",
     "esbuild": "npm:esbuild@^0.25",
     "hono": "npm:hono@^4",
     "@hono/vite-dev-server": "npm:@hono/vite-dev-server@^0.25.3",
diff --git a/packages/adapter-vite/src/index.ts b/packages/adapter-vite/src/index.ts
@@ -89,8 +89,8 @@ const CORE_SUBPATHS: Record<string, string> = {
  */
 function buildCoreSubpathAliases(): import('vite').Alias[] {
   const adapterSrcDir = dirname(fileURLToPath(import.meta.url));
-  // Core source is at ../core/src/ relative to adapter-vite/src/
-  const coreSrcDir = join(adapterSrcDir, '../core/src');
+  // Core source is at ../../core/src/ relative to adapter-vite/src/
+  const coreSrcDir = join(adapterSrcDir, '../../core/src');
 
   const aliases: import('vite').Alias[] = [];
 
diff --git a/packages/core/deno.json b/packages/core/deno.json
@@ -14,6 +14,7 @@
     "./ssr-handler": "./src/ssr-handler.ts",
     "./ssr-handler.js": "./src/ssr-handler.ts",
     "./errors": "./src/errors.ts",
+    "./context": "./src/context.ts",
     "./logger": "./src/logger.ts",
     "./logger.js": "./src/logger.ts",
     "./navigation": "./src/navigation.ts",
diff --git a/packages/core/src/html-escape.ts b/packages/core/src/html-escape.ts
@@ -14,6 +14,9 @@ import { createLogger } from './logger.js';
 
 const log = createLogger('core');
 
+/** Track whether we've already warned about <script> in headExtras (once per process) */
+let _warnedHeadExtrasScripts = false;
+
 /** Branded type: a string that has been HTML-escaped (safe for text content) */
 export type SafeHtml = string & { readonly __safeHtml: unique symbol };
 
@@ -89,7 +92,9 @@ export function wrapInDocument(
   // Security: warn if headExtras contains <script> tags, which may indicate
   // user-supplied content being injected unsafely. Legitimate use cases exist
   // (e.g. analytics scripts), but developers should be aware of the risk.
-  if (headExtras && /<script[\s>]/i.test(headExtras)) {
+  // Only warn once per process to avoid flooding SSG logs.
+  if (headExtras && /<script[\s>]/i.test(headExtras) && !_warnedHeadExtrasScripts) {
+    _warnedHeadExtrasScripts = true;
     log.warn(
       'headExtras contains <script> tags. Ensure this content is developer-controlled, ' +
         'not user-supplied, to prevent XSS. For safe URL injection, use inject.scripts instead.',
diff --git a/packages/create/__tests__/cli.test.ts b/packages/create/__tests__/cli.test.ts
@@ -110,7 +110,7 @@ Deno.test('create-less: deno.json build uses the one-command LessJS build', () =
   const denoJson = JSON.parse(extractTemplate('deno.json'));
   assertEquals(
     denoJson.tasks['build'],
-    'deno run --config deno.json -A jsr:@lessjs/core/cli/build',
+    'deno run --config deno.json -A jsr:@lessjs/adapter-vite/cli/build',
   );
   assertExists(denoJson.tasks['build:ssr']);
   assertExists(denoJson.tasks['build:client']);
@@ -198,8 +198,11 @@ Deno.test('create-less: generated project builds through the one-command pipelin
     denoJson.imports['@lessjs/core/render-dsd'] = pathToFileURL(
       join(repoRoot, 'packages', 'core', 'src', 'render-dsd.ts'),
     ).href;
-    denoJson.imports['@lessjs/core/build-context'] = pathToFileURL(
-      join(repoRoot, 'packages', 'core', 'src', 'build-context.ts'),
+    denoJson.imports['@lessjs/adapter-vite/build-context'] = pathToFileURL(
+      join(repoRoot, 'packages', 'adapter-vite', 'src', 'build-context.ts'),
+    ).href;
+    denoJson.imports['@lessjs/adapter-vite'] = pathToFileURL(
+      join(repoRoot, 'packages', 'adapter-vite', 'src', 'index.ts'),
     ).href;
     denoJson.imports['@lessjs/content'] = pathToFileURL(
       join(repoRoot, 'packages', 'content', 'src', 'index.ts'),
@@ -223,15 +226,21 @@ Deno.test('create-less: generated project builds through the one-command pipelin
     denoJson.imports['hono'] = 'npm:hono@^4';
     denoJson.imports['@hono/vite-dev-server'] = 'npm:@hono/vite-dev-server@^0.25.3';
     denoJson.tasks.build = `deno run -A ${
-      join(repoRoot, 'packages', 'core', 'src', 'cli', 'build.ts')
+      join(repoRoot, 'packages', 'adapter-vite', 'src', 'cli', 'build.ts')
     }`;
     writeFileSync(denoJsonPath, JSON.stringify(denoJson, null, 2));
 
     const uiSrc = join(repoRoot, 'packages', 'ui', 'src');
     const aliases = [
       {
-        find: '@lessjs/core/build-context',
-        replacement: vitePath(join(repoRoot, 'packages', 'core', 'src', 'build-context.ts')),
+        find: '@lessjs/adapter-vite/build-context',
+        replacement: vitePath(
+          join(repoRoot, 'packages', 'adapter-vite', 'src', 'build-context.ts'),
+        ),
+      },
+      {
+        find: '@lessjs/adapter-vite',
+        replacement: vitePath(join(repoRoot, 'packages', 'adapter-vite', 'src', 'index.ts')),
       },
       {
         find: '@lessjs/core/render-dsd',
@@ -332,7 +341,7 @@ Deno.test('create-less: generated project builds through the one-command pipelin
       "import { lessjs } from '@lessjs/app';",
       `import { less } from ${
         JSON.stringify(
-          vitePath(join(repoRoot, 'packages', 'core', 'src', 'index.ts')),
+          vitePath(join(repoRoot, 'packages', 'adapter-vite', 'src', 'index.ts')),
         )
       };`,
     );
diff --git a/packages/create/cli.ts b/packages/create/cli.ts
@@ -22,6 +22,7 @@ const JSR_SCOPE = '@lessjs';
 const PKG_DIR_MAP: Record<string, string> = {
   core: 'core',
   adapterLit: 'adapter-lit',
+  adapterVite: 'adapter-vite',
   app: 'app',
   content: 'content',
   i18n: 'i18n',
@@ -118,6 +119,7 @@ node_modules/
     "vite": "npm:vite@8.0.10",
     "@lessjs/app": "jsr:@lessjs/app@^${v.app}",
     "@lessjs/adapter-lit": "jsr:@lessjs/adapter-lit@^${v.adapterLit}",
+    "@lessjs/adapter-vite": "jsr:@lessjs/adapter-vite@^${v.adapterVite}",
     "@lessjs/content": "jsr:@lessjs/content@^${v.content}",
     "@lessjs/core": "jsr:@lessjs/core@^${v.core}",
     "@lessjs/core/adapter-registry": "jsr:@lessjs/core@^${v.core}/adapter-registry",
@@ -135,10 +137,10 @@ node_modules/
   "nodeModulesDir": "auto",
   "tasks": {
     "dev": "deno run --config deno.json -A npm:vite",
-    "build": "deno run --config deno.json -A jsr:@lessjs/core/cli/build",
+    "build": "deno run --config deno.json -A jsr:@lessjs/adapter-vite/cli/build",
     "build:ssr": "deno run --config deno.json -A npm:vite build",
-    "build:client": "deno run --config deno.json -A jsr:@lessjs/core/cli/build-client",
-    "build:ssg": "deno run --config deno.json -A jsr:@lessjs/core/cli/build-ssg",
+    "build:client": "deno run --config deno.json -A jsr:@lessjs/adapter-vite/cli/build-client",
+    "build:ssg": "deno run --config deno.json -A jsr:@lessjs/adapter-vite/cli/build-ssg",
     "preview": "deno run --config deno.json -A npm:vite preview"
   },
   "compilerOptions": { "lib": ["ES2022", "DOM", "DOM.Iterable"] }

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,5 @@`
`1`	`1`	`/**`
`2`		`- * @lessjs/core - build-manifest.ts tests (Deno)`
	`2`	`+ * @lessjs/adapter-vite - build-manifest.ts tests (Deno)`
`3`	`3`	`*`
`4`	`4`	`* Tests build manifest scanning and formatting using temp directories.`
`5`	`5`	`*/`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`// deno-lint-ignore-file no-explicit-any`
`2`	`2`	`/**`
`3`		`- * @lessjs/core - build / entry-generators tests (Deno)`
	`3`	`+ * @lessjs/adapter-vite - build / entry-generators tests (Deno)`
`4`	`4`	`*`
`5`	`5`	`* ADR 0011: closeBundle writes metadata to ctx, not .less/build-metadata.json.`
`6`	`6`	`* Tests verify LessBuildContext fields instead of filesystem.`