[Commands] Fix accepting invalid commands

Author: TD-er

src/src/Commands/InternalCommands.cpp

@@ -643,6 +643,7 @@ bool ExecuteCommand(taskIndex_t            taskIndex,
     }
 
     if (handled) {
+//      addLog(LOG_LEVEL_INFO, F("executeInternalCommand accepted"));
       return true;
     }
   }
@@ -657,6 +658,7 @@ bool ExecuteCommand(taskIndex_t            taskIndex,
     // alter the string.
     String tmpAction(action);
     bool   handled = PluginCall(PLUGIN_WRITE, &TempEvent, tmpAction);
+//    if (handled) addLog(LOG_LEVEL_INFO, F("PLUGIN_WRITE accepted"));
 
     #ifndef BUILD_NO_DEBUG
     if (!tmpAction.equals(action)) {
@@ -673,7 +675,7 @@ bool ExecuteCommand(taskIndex_t            taskIndex,
     if (!handled) {
       // Try a controller
       handled = CPluginCall(CPlugin::Function::CPLUGIN_WRITE, &TempEvent, tmpAction);
-
+//      if (handled) addLog(LOG_LEVEL_INFO, F("CPLUGIN_WRITE accepted"));
     }
 
     if (handled) {
@@ -685,6 +687,8 @@ bool ExecuteCommand(taskIndex_t            taskIndex,
   if (tryRemoteConfig) {
     if (remoteConfig(&TempEvent, action)) {
       SendStatus(&TempEvent, return_command_success());
+//      addLog(LOG_LEVEL_INFO, F("remoteConfig accepted"));
+
       return true;
     }
   }

src/src/DataStructs/PluginStats.cpp

@@ -289,15 +289,15 @@ bool PluginStats_array::plugin_write_base(struct EventStruct *event, const Strin
   const bool clearSamples = cmd.equals(F("clearsamples")); // Command: "taskname.clearSamples"
 
   if (resetPeaks || clearSamples) {
-    success = true;
-
     for (size_t i = 0; i < VARS_PER_TASK; ++i) {
       if (_plugin_stats[i] != nullptr) {
         if (resetPeaks) {
+          success = true;
           _plugin_stats[i]->resetPeaks();
         }
 
         if (clearSamples) {
+          success = true;
           _plugin_stats[i]->clearSamples();
         }
       }

src/src/Globals/CPlugins.cpp

@@ -97,6 +97,9 @@ bool CPluginCall(CPlugin::Function Function, struct EventStruct *event, String&
     case CPlugin::Function::CPLUGIN_TEN_PER_SECOND:
     case CPlugin::Function::CPLUGIN_FIFTY_PER_SECOND:
     case CPlugin::Function::CPLUGIN_WRITE:
+    {
+      // Only CPLUGIN_WRITE might return a false
+      bool success = Function != CPlugin::Function::CPLUGIN_WRITE;
 
       if (Function == CPlugin::Function::CPLUGIN_INIT_ALL) {
         Function = CPlugin::Function::CPLUGIN_INIT;
@@ -107,13 +110,14 @@ bool CPluginCall(CPlugin::Function Function, struct EventStruct *event, String&
           protocolIndex_t ProtocolIndex = getProtocolIndex_from_ControllerIndex(x);
           event->ControllerIndex = x;
           String dummy;
-          const bool success = CPluginCall(ProtocolIndex, Function, event, dummy);
+          success = CPluginCall(ProtocolIndex, Function, event, dummy);
           if (success && Function == CPlugin::Function::CPLUGIN_WRITE) {
             return success;
           }
         }
       }
-      return true;
+      return success;
+    }
 
     // calls to specific controller
     case CPlugin::Function::CPLUGIN_INIT: