Skip to content

Commit df735c6

Browse files
Fix go-lint-checks CI job failures (#537)
With the [release of go1.26](https://go.dev/blog/go1.26), CI started failing the golangci-lint job because actions/setup-go was configured with go-version: stable, which now selects go1.26. Our pinned golangci-lint binary (v2.6.1, built with go1.25) is not compatible with go1.26. This change switches the workflow to use [go-version-file](https://github.com/actions/setup-go#go-version-file): go.mod, so checks consistently run with Pebble’s Go version. Note: we will still need to need to update golangci-lint when we move Pebble to go1.26, but this isn't a step we need to take right now.
1 parent 79baa78 commit df735c6

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

.github/workflows/checks.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ permissions:
1111
pull-requests: read
1212
env:
1313
CGO_ENABLED: 0
14-
GO_VERSION: stable
1514
GOLANGCI_LINT_VERSION: v2.6.1
1615
SHELLCHECK_SCRIPTS: ./*.sh
1716
jobs:
@@ -21,7 +20,7 @@ jobs:
2120
- uses: actions/checkout@v5
2221
- uses: actions/setup-go@v6
2322
with:
24-
go-version: ${{ env.GO_VERSION }}
23+
go-version-file: go.mod
2524
- name: Run GolangCI-Lint
2625
uses: golangci/golangci-lint-action@v9
2726
with:
@@ -32,7 +31,7 @@ jobs:
3231
- uses: actions/checkout@v5
3332
- uses: actions/setup-go@v6
3433
with:
35-
go-version: ${{ env.GO_VERSION }}
34+
go-version-file: go.mod
3635
- name: Check if go.mod is tidy
3736
run: |
3837
go mod tidy

0 commit comments

Comments
 (0)