From 636af4255dd09a1c2d3ee9b16979e72b526407d6 Mon Sep 17 00:00:00 2001
From: Jules van Rie <jules@vanrie.be>
Date: Fri, 7 Mar 2025 16:33:11 +0100
Subject: [PATCH] Fix Windows Jupyter redirect

---
 _partials/es/nbextensions.md   | 2 +-
 _partials/es/python_checkup.md | 4 ++++
 _partials/es/win_jupyter.md    | 7 +++----
 _partials/nbextensions.md      | 2 +-
 _partials/python_checkup.md    | 6 +++++-
 _partials/win_jupyter.md       | 8 +++-----
 build.rb                       | 2 +-
 7 files changed, 18 insertions(+), 13 deletions(-)

diff --git a/_partials/es/nbextensions.md b/_partials/es/nbextensions.md
index 225cd88..0dfd0db 100644
--- a/_partials/es/nbextensions.md
+++ b/_partials/es/nbextensions.md
@@ -1,4 +1,4 @@
-### Mejora `jupyter` notebook
+### Mejora Jupyter Notebook
 
 Mejora la visualización del [elemento `details` para revelación de información](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details) en tus notebooks.
 
diff --git a/_partials/es/python_checkup.md b/_partials/es/python_checkup.md
index 060a6c5..cab57c6 100644
--- a/_partials/es/python_checkup.md
+++ b/_partials/es/python_checkup.md
@@ -1,5 +1,7 @@
 ## Chequeo de la configuración de Python
 
+### Chequeo de Python y packages
+
 Reinicia tu terminal:
 
 ```bash
@@ -21,6 +23,8 @@ Ahora ejecuta el siguiente comando para verificar que puedas cargar estos paquet
 python -c "$(curl -fsSL <PIP_LOADER_URL>)"
 ```
 
+### Chequeo de Jupyter
+
 Ahora verifica que puedas iniciar un servidor de notebook en tu máquina:
 
 ```bash
diff --git a/_partials/es/win_jupyter.md b/_partials/es/win_jupyter.md
index 987b5b2..b9d1dd4 100644
--- a/_partials/es/win_jupyter.md
+++ b/_partials/es/win_jupyter.md
@@ -1,5 +1,4 @@
-
-## Configuración de Jupyter Notebook para abrirlo en tu navegador
+### Configuración de Jupyter Notebook para abrirlo en tu navegador
 
 Genera el archivo de configuración para **Jupyter Notebook**...
 
@@ -18,13 +17,13 @@ Ahora edita el archivo de configuración de Jupyter generado:
 Localiza la siguiente línea en el archivo de configuración:
 
 ``` python
-# c.NotebookApp.use_redirect_file = True
+# c.ServerApp.use_redirect_file = True
 ```
 
 Y reemplázala por éste **precisamente** 👇 (incluyendo la eliminación del símbolo `#`)
 
 ``` python
-c.NotebookApp.use_redirect_file = False
+c.ServerApp.use_redirect_file = False
 ```
 
 Intenta usar Jupyter:
diff --git a/_partials/nbextensions.md b/_partials/nbextensions.md
index 0aaa51b..083509a 100644
--- a/_partials/nbextensions.md
+++ b/_partials/nbextensions.md
@@ -1,4 +1,4 @@
-### `jupyter` notebook tweaking
+### Jupyter Notebook tweaking
 
 Let's improve the display of the [`details` disclosure elements](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/details) in your notebooks.
 
diff --git a/_partials/python_checkup.md b/_partials/python_checkup.md
index a657a47..c8e03cb 100644
--- a/_partials/python_checkup.md
+++ b/_partials/python_checkup.md
@@ -1,4 +1,6 @@
-## Python setup check up
+## Python setup check
+
+### Python and packages check
 
 Let's reset your terminal:
 
@@ -21,6 +23,8 @@ Now run the following command to check if you can load these packages:
 python -c "$(curl -fsSL <PIP_LOADER_URL>)"
 ```
 
+### Jupyter check
+
 Make sure you can run Jupyter:
 
 ```bash
diff --git a/_partials/win_jupyter.md b/_partials/win_jupyter.md
index 78e86fd..a130c38 100644
--- a/_partials/win_jupyter.md
+++ b/_partials/win_jupyter.md
@@ -1,5 +1,5 @@
 
-## Configuring Jupyter Notebook to open in your browser
+### Configuring Jupyter Notebook to open in your browser
 
 Let's generate the configuration file for **Jupyter Notebook**...
 
@@ -7,8 +7,6 @@ Let's generate the configuration file for **Jupyter Notebook**...
 jupyter notebook --generate-config
 ```
 
-⚠️ Please copy the path returned by the previous command.
-
 We will now edit the generated Jupyter configuration file:
 
 ``` bash
@@ -18,13 +16,13 @@ We will now edit the generated Jupyter configuration file:
 Locate the following line in the configuration file:
 
 ``` python
-# c.NotebookApp.use_redirect_file = True
+# c.ServerApp.use_redirect_file = True
 ```
 
 And replace it with this one **precisely** 👇 (including removing the `#` symbol)
 
 ``` python
-c.NotebookApp.use_redirect_file = False
+c.ServerApp.use_redirect_file = False
 ```
 
 Let's try to run Jupyter:
diff --git a/build.rb b/build.rb
index 45317cb..249a649 100755
--- a/build.rb
+++ b/build.rb
@@ -80,8 +80,8 @@
   ubuntu_python
   virtualenv
   pip
-  win_jupyter
   nbextensions
+  win_jupyter
   python_checkup
   dbeaver
   setup/windows_settings