Ensure all children are visited

Author: tom-sherman

deno.lock

@@ -1,6 +1,6 @@
 {
   "name": "@lpm/core",
-  "version": "0.2.8",
+  "version": "0.2.9",
   "license": "MIT",
   "exports": "./mod.ts",
 

packages/core/deno.jsonc

@@ -60,13 +60,11 @@ export class NodeRegistry {
       for (const resolution of resolutions) {
         if (!seenNodeNsids.has(resolution.nsid.toString())) {
           yield resolution;
+          seenNodeNsids.add(resolution.nsid.toString());
           if (resolution.success) {
             const children = resolution.children.filter(
               (nsid) => !seenNodeNsids.has(nsid.toString()),
             );
-            children.forEach((nsid) => {
-              seenNodeNsids.add(nsid.toString());
-            });
 
             queue.push(...children);
           }

packages/core/src/node-registry.ts

@@ -1,10 +1,10 @@
-import { NSID } from "@atproto/syntax";
+import { AtUri, NSID } from "@atproto/syntax";
 import type { Resolution } from "./node.ts";
 import { NodeRegistry } from "./node-registry.ts";
 import { assertEquals, assertObjectMatch } from "jsr:@std/assert";
 import { bootstrap } from "@needle-di/core";
 import { Lexicons } from "@atproto/lexicon";
-import { skip } from "node:test";
+import { AtpBaseClient } from "npm:@atproto/api";
 
 function assertSuccessfullResolution(
   data: Resolution,
@@ -93,30 +93,45 @@ Deno.test("doesn't resolve the same uri twice", async () => {
   assertEquals(new Set(duplicateUris), new Set());
 });
 
-Deno.test,
-  skip("can validate a post record", async () => {
-    const NSID_STR = "app.bsky.feed.post";
-    const registry = bootstrap(NodeRegistry);
-    const resolutions = [];
-    for await (
-      const resolution of registry.resolve([
-        registry.get(NSID.parse(NSID_STR)),
-      ])
-    ) {
-      assertSuccessfullResolution(resolution);
-      resolutions.push(resolution);
-    }
-
-    const lexicons = new Lexicons(resolutions.map((r) => r.doc));
-
-    const exampleRecords = [
-      '{"uri":"at://did:plc:2xau7wbgdq4phuou2ypwuen7/app.bsky.feed.post/3ljrsfbuuyk2g","cid":"bafyreigjrpyhhk5fibcajhhtkcefmxptntgx35t5zngvsxwwvu56hzioaq","value":{"text":"To update a globally installed CLI in deno you pass -fr\\n\\nfr fr","$type":"app.bsky.feed.post","langs":["en"],"createdAt":"2025-03-07T10:28:47.874Z"}}',
-      '{"uri":"at://did:plc:yosojsta3nm5qiod5zqixzur/app.bsky.feed.post/3ljpreuc6fs2c","cid":"bafyreihyt2ckoxoyusimrexuxatuwazct7uiskukhspxic756inddofipy","value":{"text":"DOGE “seemed unsure” of what USAID programs they cut and is now attempting to reverse some of the cuts, says @propublica.org reporter Brett Murphy. “This is the opposite of a careful review.\\"","$type":"app.bsky.feed.post","embed":{"$type":"app.bsky.embed.video","video":{"$type":"blob","ref":{"$link":"bafkreidowys6ntilo4wslx23jishxiqfrwywqmxxer4sy2r6y5orwuosn4"},"mimeType":"video/mp4","size":8408607},"aspectRatio":{"width":1280,"height":720}},"langs":["en"],"facets":[{"$type":"app.bsky.richtext.facet","index":{"byteEnd":128,"byteStart":113},"features":[{"did":"did:plc:k4jt6heuiamymgi46yeuxtpt","$type":"app.bsky.richtext.facet#mention"}]}],"createdAt":"2025-03-06T15:05:20.412Z"}}',
-    ].map((s) => JSON.parse(s).value);
-
-    for (const exampleRecord of exampleRecords) {
-      const result = lexicons.validate(NSID_STR, exampleRecord);
-      // @ts-expect-error result.error isn't narrowed
-      assertEquals(result.success, true, `Failed to validate: ${result.error}`);
-    }
-  });
+Deno.test("can validate a post record", async () => {
+  const NSID_STR = "app.bsky.feed.post";
+  const registry = bootstrap(NodeRegistry);
+  const resolutions = [];
+  for await (
+    const resolution of registry.resolve([
+      registry.get(NSID.parse(NSID_STR)),
+    ])
+  ) {
+    assertSuccessfullResolution(resolution);
+    resolutions.push(resolution);
+  }
+
+  const client = new AtpBaseClient("https://api.bsky.app");
+
+  const postUris = [
+    "at://did:plc:2xau7wbgdq4phuou2ypwuen7/app.bsky.feed.post/3ljmvgixb327d",
+  ].map((uri) => new AtUri(uri));
+
+  const records = await Promise.all(
+    postUris.map((uri) =>
+      client.com.atproto.repo.getRecord({
+        repo: uri.host,
+        collection: uri.collection,
+        rkey: uri.rkey,
+      })
+    ),
+  );
+
+  const lexicons = new Lexicons(resolutions.map((r) => r.doc));
+
+  for (const record of records) {
+    const result = lexicons.validate(NSID_STR, record.data.value);
+    assertEquals(
+      result.success,
+      true,
+      `Failed to validate ${record.data.uri}: ${
+        // @ts-expect-error result.error isn't narrowed
+        result.error}`,
+    );
+  }
+});

packages/core/src/node.test.ts

@@ -66,9 +66,11 @@ export class Node {
       throw new Error("Expected cid to be defined");
     }
 
+    const refs = getRefs(doc);
+
     const externalRefs = [
       ...new Set(
-        getRefs(doc)
+        refs
           .filter(
             (ref) =>
               !ref.startsWith("#") &&