Skip to content

MAXCONNECTS is a noop since curl handles are thread local #741

Description

@ligix

Is your feature request related to a provblem? Please describe.
Setting MAXCONNECTS is a noop since the connection limit is per curl handle and handles are, by default, thread local which means that even if you use the same curl Session() you end up not reusing connections (or, at least, not more than one).

The only way setting that option may make sense is if you use AsyncSession.

Describe the solution you'd like
Provide a warning to the user if such a useless option is provided

Describe alternatives you've considered
Not provide a warning which I'm not convinced is any worse than providing one.

Additional context
More than a feature request I'm opening this to bring you this ""weird"" behavior to your attention in case you want to consider adding a runtime / documentation warning.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions