Updating IL9163 to fix cppcheck warnings

Author: lexus2k

src/v2/lcd/base/ssd1306_common.inl

@@ -679,7 +679,7 @@ template <class O, class I> static uint8_t getMaxScreenItems(NanoDisplayOps<O, I
 }
 
 template <class O, class I>
-static uint8_t calculateScrollPosition(NanoDisplayOps<O, I> &display, SAppMenu *menu, uint8_t selection)
+static uint8_t calculateScrollPosition(NanoDisplayOps<O, I> &display, const SAppMenu *menu, uint8_t selection)
 {
     if ( selection < menu->scrollPosition )
     {

src/v2/lcd/il9163/lcd_il9163.h

@@ -112,7 +112,7 @@ template <typename I> class InterfaceIL9163: public I
     const int8_t m_dc = -1;                      ///< data/command pin for SPI, -1 for i2c
     NanoDisplayBase<InterfaceIL9163<I>> &m_base; ///< basic lcd display support interface
     uint8_t m_rotation = 0x00;
-    static const uint8_t m_rgb_bit = 0b00000000;
+    uint8_t m_rgb_bit = 0b00000000;
 };
 /**
  * Class implements basic functions for 16-bit mode of IL9163-based displays

src/v2/lcd/sh1106/lcd_sh1106.inl

@@ -39,7 +39,7 @@ template <class I> void InterfaceSH1106<I>::startBlock(lcduint_t x, lcduint_t y,
     commandStart();
     this->send(0xB0 | y); // set page
     this->send(((x+2)>>4) | 0x10); // high column
-    this->send(((x+2) & 0x0f) | 0x00); // low column
+    this->send(((x+2) & 0x0f)); // low column
     if ( m_dc >= 0 )
     {
         setDataMode(1);

src/v2/lcd/sh1107/lcd_sh1107.inl

@@ -38,7 +38,7 @@ template <class I> void InterfaceSH1107<I>::startBlock(lcduint_t x, lcduint_t y,
     m_page = y;
     commandStart();
     this->send(0xB0 | y); // set page
-    this->send( ((x + m_seg_offset)       & 0x0f ) | 0x00); // low column
+    this->send( ((x + m_seg_offset)       & 0x0f )       ); // low column
     this->send((((x + m_seg_offset) >> 4) & 0x07 ) | 0x10); // high column
     if ( m_dc >= 0 )
     {

tools/templates/lcd/il9163/fields/Interface~CONTROLLER~

@@ -2,4 +2,4 @@ private:
     const int8_t m_dc = -1;                      ///< data/command pin for SPI, -1 for i2c
     NanoDisplayBase<Interface~CONTROLLER~<I>> &m_base; ///< basic lcd display support interface
     uint8_t m_rotation = 0x00;
-    static const uint8_t m_rgb_bit = 0b00000000;
+    uint8_t m_rgb_bit = 0b00000000;

tools/templates/lcd/sh1106/functions/startBlock/code

@@ -3,7 +3,7 @@
     commandStart();
     this->send(0xB0 | y); // set page
     this->send(((x+2)>>4) | 0x10); // high column
-    this->send(((x+2) & 0x0f) | 0x00); // low column
+    this->send(((x+2) & 0x0f)); // low column
     if ( m_dc >= 0 )
     {
         setDataMode(1);

tools/templates/lcd/sh1107/functions/startBlock/code

@@ -2,7 +2,7 @@
     m_page = y;
     commandStart();
     this->send(0xB0 | y); // set page
-    this->send( ((x + m_seg_offset)       & 0x0f ) | 0x00); // low column
+    this->send( ((x + m_seg_offset)       & 0x0f )       ); // low column
     this->send((((x + m_seg_offset) >> 4) & 0x07 ) | 0x10); // high column
     if ( m_dc >= 0 )
     {