Skip to content

Savina benchmarks using mutations fail with connections #321

@erlingrj

Description

@erlingrj

Both ActorCreator and Sieve fails to compile because some changes in the connection API for mutations. HEre is a CI failure (https://github.com/lf-lang/benchmarks-lingua-franca/actions/runs/12932483801/job/36068849097?pr=67) but it does not include the compiler output. I can reproduce it locally and get:

src/ActorCreation.ts(238,38): error TS2769: No overload matches this call.
  Overload 1 of 2, '(src: ConnectablePort<unknown>, dst: ConnectablePort<unknown>): void', gave the following error.
    Argument of type 'IOPort<boolean>' is not assignable to parameter of type 'ConnectablePort<unknown>'.
      Type 'IOPort<boolean>' is missing the following properties from type 'ConnectablePort<unknown>': getPort, port
  Overload 2 of 2, '(src: CallerPort<unknown, unknown>, dst: CalleePort<unknown, unknown>): void', gave the following error.
    Argument of type 'IOPort<boolean>' is not assignable to parameter of type 'CallerPort<unknown, unknown>'.
      Type 'IOPort<boolean>' is missing the following properties from type 'CallerPort<unknown, unknown>': remotePort, set, invoke

For now I am moving the failing benchmarks into a failing directory and do not test them in CI. See: lf-lang/benchmarks-lingua-franca#67

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions