New "subscription button" - Final Review #1100
Description
Description 📹
- New "subscription button" - Delete “subscription” button #1091
- New "subscription button" - Add new card when subscription is inactive #1092
- New "subscription button" - Add a new title when subscription is inactive #1093
- New "subscription button" - Add a new description when subscription is inactive #1094
- New "subscription button" - Add a button "Activate subscription" when subscription is inactive #1095
- New "subscription button" - Add a new card when subscription is active #1096
- New "subscription button" - Add a new title when subscription is active #1097
- New "subscription button" - Add a new description when subscription is active #1098
- New "subscription button" - Add a new cancel button when subscription is active #1099
Your task will be to check that all the issues have been correctly developed, that the components are properly arranged, and that everything matches exactly as in the Figma design:
The purpose of this issue is to conduct a final review of the new "subscription button" on the Starknet ID platform. Here are the key details:
Issue Details
- The task is to verify that all related issues have been correctly implemented and that components are properly arranged according to the Figma design.
- The design reference is available on Figma (link provided in the issue description).
Actions to Take
-
Fork and Branch Creation:
- Fork the repository and create a new branch using the issue number.
-
Review and Verification:
- Check that all components related to the subscription button have been developed correctly.
- Ensure the layout and arrangement match exactly with the Figma design.
- Verify that all previous sub-issues have been properly addressed.
-
Testing and Validation:
- Test the functionality of the subscription button.
- Ensure the changes integrate properly with other components.
-
Commit and Submission:
- Make a commit with a clear message describing the final review.
- Submit a pull request closing the issue.
Proposed Actions 🛠️
Here’s a checklist of actions to follow for resolving this issue:
-
Fork and Create Branch:
Fork the repository and create a new branch using the issue number:git checkout -b fix-[issue-number]
-
Implement Changes:
[Insert Code snippet if needed with a mardown todo list] -
Run Tests and Commit Changes:
Make sure your changes don't break existing functionality and commit with a clear message:git commit -m "Fix: [Short description of the fix]"
Required 📋
To keep our workflow smooth, please make sure you follow these guidelines:
- Assignment: Don't create a pull request if you weren’t assigned to this issue.
- Timeframe: Complete the task within 3 business days.
- Closing the Issue: In your PR description, close the issue by writing
Close #[issue_id]. - Review Process:
- Once you've submitted your PR, change the label to "ready for review".
- If changes are requested, address them and then update the label back to "ready for review" once done.
- Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.
Thank you for your contribution 🙏