Fix spec issues

Signed-off-by: Rafal Lal <rafal.lal@tietoevry.com>

Author: rafal-lal

src/tasks/setup/cnf_setup.cr

@@ -22,7 +22,7 @@ namespace "setup" do
     stdout_success "CNF installation start."
     CNFInstall.install_cnf(args)
     logger.info { "CNF installed successfuly" }
-    stdout_success "CNF installation ended."
+    stdout_success "CNF installation complete."
   end
 
   task "cnf_uninstall" do |_, args|

src/tasks/setup/kubescape_setup.cr

@@ -44,9 +44,13 @@ task "kubescape_framework_download" do |_, args|
   framework_path = "#{tools_path}/kubescape/nsa.json"
   if !File.exists?(framework_path) || installed_framework_version != Setup::KUBESCAPE_FRAMEWORK_VERSION
     asset_url = "https://github.com/armosec/regolibrary/releases/download/v#{Setup::KUBESCAPE_FRAMEWORK_VERSION}/nsa"
-
-    download(Setup::KUBESCAPE_URL, framework_path,
-    headers: HTTP::Headers{"Authorization" => "Bearer #{ENV["GITHUB_TOKEN"]}"})
+    
+    unless ENV["GITHUB_TOKEN"]?.nil?
+      download(Setup::KUBESCAPE_URL, framework_path,
+        headers: HTTP::Headers{"Authorization" => "Bearer #{ENV["GITHUB_TOKEN"]}"})
+    else
+      download(Setup::KUBESCAPE_URL, framework_path)
+    end
     File.write(version_file, Setup::KUBESCAPE_FRAMEWORK_VERSION)
   end
 end

src/tasks/workload/microservice.cr

@@ -23,7 +23,7 @@ end
 REASONABLE_STARTUP_BUFFER = 10.0
 
 desc "To check if the CNF has multiple microservices that share a database"
-task "shared_database", ["install_cluster_tools"] do |t, args|
+task "shared_database", ["setup:install_cluster_tools"] do |t, args|
   CNFManager::Task.task_runner(args, task: t) do |args, config|
     # todo loop through local resources and see if db match found
     db_match = Netstat::Mariadb.match
@@ -727,7 +727,7 @@ task "service_discovery" do |t, args|
 end
 
 desc "To check if the CNF uses a specialized init system"
-task "specialized_init_system", ["install_cluster_tools"] do |t, args|
+task "specialized_init_system", ["setup:install_cluster_tools"] do |t, args|
   CNFManager::Task.task_runner(args, task: t) do |args, config|
     failed_cnf_resources = [] of InitSystems::InitSystemInfo
     resources_checked = false

src/tasks/workload/observability.cr

@@ -179,7 +179,7 @@ task "open_metrics", ["prometheus_traffic"] do |t, args|
 end
 
 desc "Are the CNF's logs captured by a logging system"
-task "routed_logs", ["install_cluster_tools"] do |t, args|
+task "routed_logs", ["setup:install_cluster_tools"] do |t, args|
   task_response = CNFManager::Task.task_runner(args, task: t) do |args, config|
     fluent_pods = FluentManager.find_active_match_pods()
     unless fluent_pods