Remove priority as required field for category match rules

Author: rennerocha

thebook/bookkeeping/admin.py

@@ -49,7 +49,6 @@ class CategoryAdmin(admin.ModelAdmin): ...
 @admin.register(CategoryMatchRule)
 class CategoryMatchRuleAdmin(admin.ModelAdmin):
     list_display = [
-        "priority",
         "pattern",
         "category",
     ]

thebook/bookkeeping/management/commands/set_category_to_uncategorized_transactions.py

@@ -8,7 +8,7 @@ class Command(BaseCommand):
 
     def handle(self, *args, **options):
         uncategorized_transactions = Transaction.objects.filter(category__isnull=True)
-        category_match_rules = CategoryMatchRule.objects.order_by("priority")
+        category_match_rules = CategoryMatchRule.objects.all()
 
         for transaction in uncategorized_transactions:
             transaction.categorize(rules=category_match_rules)

thebook/bookkeeping/migrations/0020_remove_categorymatchrule_priority.py

@@ -0,0 +1,17 @@
+# Generated by Django 5.2.10 on 2026-02-13 20:22
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("bookkeeping", "0019_document_content_type_document_object_id_and_more"),
+    ]
+
+    operations = [
+        migrations.RemoveField(
+            model_name="categorymatchrule",
+            name="priority",
+        ),
+    ]

thebook/bookkeeping/models.py

@@ -113,7 +113,6 @@ def __str__(self):
 
 
 class CategoryMatchRule(models.Model):
-    priority = models.IntegerField(unique=True)
     pattern = models.CharField(max_length=512)
     category = models.ForeignKey("bookkeeping.Category", on_delete=models.CASCADE)
     value = models.DecimalField(max_digits=10, decimal_places=2, blank=True, null=True)
@@ -131,7 +130,7 @@ class CategoryMatchRule(models.Model):
     tags = models.CharField(max_length=512, blank=True, null=True)
 
     def __str__(self):
-        return f"{self.pattern} ({self.priority})"
+        return f"{self.pattern}"
 
     class Meta:
         constraints = [
@@ -282,7 +281,7 @@ def has_documents(self):
 
     def categorize(self, rules=None):
         if rules is None:
-            rules = CategoryMatchRule.objects.order_by("priority")
+            rules = CategoryMatchRule.objects.all()
 
         for rule in rules:
             self, applied = rule.apply_rule(self)

thebook/bookkeeping/tests/models/test_category_match_rules.py

@@ -12,27 +12,16 @@ def category():
     return Category.objects.create(name="Test Category")
 
 
-def test_priority_must_be_unique(db, category):
-    _ = CategoryMatchRule.objects.create(
-        priority=100, pattern="test_pattern", category=category
-    )
-    with pytest.raises(IntegrityError):
-        CategoryMatchRule.objects.create(
-            priority=100, pattern="another_pattern", category=category
-        )
-
-
 def test_when_value_is_provided_comparison_function_is_also_required(db, category):
     with pytest.raises(IntegrityError):
         _ = CategoryMatchRule.objects.create(
-            priority=100, pattern="pattern", category=category, value=Decimal("42.0")
+            pattern="pattern", category=category, value=Decimal("42.0")
         )
 
 
 def test_when_comparison_function_is_provided_value_is_also_required(db, category):
     with pytest.raises(IntegrityError):
         _ = CategoryMatchRule.objects.create(
-            priority=100,
             pattern="pattern",
             category=category,
             comparison_function="EQ",
@@ -42,7 +31,6 @@ def test_when_comparison_function_is_provided_value_is_also_required(db, categor
 def test_valid_when_comparison_function_and_value_are_provided(db, category):
     try:
         category_match_rule = CategoryMatchRule.objects.create(
-            priority=100,
             pattern="pattern",
             category=category,
             value=Decimal("42.0"),
@@ -63,7 +51,6 @@ def test_valid_when_comparison_function_and_value_are_provided(db, category):
 def test_comparison_function_must_be_a_valid_value(db, category, comparison_function):
     try:
         category_match_rule = CategoryMatchRule.objects.create(
-            priority=100,
             pattern="pattern",
             category=category,
             value=Decimal("42.0"),
@@ -76,7 +63,6 @@ def test_comparison_function_must_be_a_valid_value(db, category, comparison_func
 def test_fail_when_comparison_function_is_not_a_valid_value(db, category):
     with pytest.raises(IntegrityError):
         _ = CategoryMatchRule.objects.create(
-            priority=100,
             pattern="pattern",
             category=category,
             value=Decimal("42.0"),

thebook/bookkeeping/tests/models/test_category_match_rules__apply_rule.py

@@ -15,7 +15,7 @@ def test_can_not_apply_rule_in_not_persisted_transaction(
     bank_fee_category,
 ):
     category_rule = CategoryMatchRule.objects.create(
-        priority=100, pattern="bank fee", category=bank_fee_category, tags="bank"
+        pattern="bank fee", category=bank_fee_category, tags="bank"
     )
     transaction = baker.prepare(Transaction, description="bank fee")
     with pytest.raises(ValueError):
@@ -34,7 +34,6 @@ def test_can_not_apply_rule_in_not_persisted_transaction(
 )
 def test_apply_rule_by_regex_pattern(db, bank_fee_category, pattern, description):
     category_rule = CategoryMatchRule.objects.create(
-        priority=100,
         pattern=pattern,
         category=bank_fee_category,
     )
@@ -60,7 +59,6 @@ def test_do_not_apply_rule_when_regex_not_a_match(
     db, bank_fee_category, pattern, description
 ):
     category_rule = CategoryMatchRule.objects.create(
-        priority=100,
         pattern=pattern,
         category=bank_fee_category,
     )
@@ -85,7 +83,6 @@ def test_apply_tags_to_matched_transactions(
     db, bank_fee_category, pattern, description, tags
 ):
     category_rule = CategoryMatchRule.objects.create(
-        priority=100,
         pattern=pattern,
         category=bank_fee_category,
         tags=tags,
@@ -122,7 +119,6 @@ def test_apply_rule_considering_value(
     expected_applied,
 ):
     category_rule = CategoryMatchRule.objects.create(
-        priority=100,
         pattern="bank fee",
         category=bank_fee_category,
         value=rule_value,

thebook/bookkeeping/tests/models/test_transaction__categorize.py

@@ -71,7 +71,6 @@ def test_transactions_description_rules_over_donation_threshold(
     db, mocker, settings, accountant
 ):
     CategoryMatchRule.objects.create(
-        priority=100,
         pattern="NOT DONATION",
         category=accountant,
     ),
@@ -94,12 +93,10 @@ def test_consider_match_rule_priority_when_categorizing(
     db, mocker, settings, accountant, bank_fees
 ):
     CategoryMatchRule.objects.create(
-        priority=200,
         pattern="PAYMENT",
         category=accountant,
     )
     CategoryMatchRule.objects.create(
-        priority=100,
         pattern="PAYMENT",
         category=bank_fees,
     )