Mark transaction that already exist as duplicated

Author: rennerocha

thebook/webhooks/paypal/services.py

@@ -211,7 +211,22 @@ def process_webhook_payload(webhook):
             id=webhook.id,
         )
         webhook.status = ProcessingStatus.UNPARSABLE
-        webhook.internal_notes = "webhooks.paypal.jsondecodeerror"
+        webhook.internal_notes = (
+            "webhooks.paypal.services.process_webhook_payload.unparsable_event"
+        )
+        webhook.save()
+        return
+
+    reference = jmespath.search("resource.id", payload)
+    if Transaction.objects.filter(reference=reference).exists():
+        logger.info(
+            "webhooks.paypal.services.process_webhook_payload.duplicated_transaction",
+            id=webhook.id,
+        )
+        webhook.status = ProcessingStatus.DUPLICATED
+        webhook.internal_notes = (
+            "webhooks.paypal.services.process_webhook_payload.duplicated_transaction",
+        )
         webhook.save()
         return
 
@@ -278,8 +293,6 @@ def process_webhook_payload(webhook):
 
     description = " - ".join([part for part in description_parts if part])
 
-    reference = jmespath.search("resource.id", payload)
-
     with transaction.atomic():
         bank_fee_category, _ = Category.objects.get_or_create(name="Tarifas Bancárias")
 

thebook/webhooks/tests/paypal/test_paypal_process.py

@@ -152,3 +152,20 @@ def test_do_not_process_duplicated_webhook_twice(
     duplicated_webhook.refresh_from_db()
 
     assert duplicated_webhook.status == ProcessingStatus.DUPLICATED
+
+
+@responses.activate
+def test_do_not_reprocess_existing_transaction(db, webhook__brl_payload):
+    transaction = baker.make(
+        Transaction,
+        reference="35R35201NA4015510",
+    )
+
+    webhook_with_duplicated_transaction = baker.make(
+        PaypalWebhookPayload,
+        payload=webhook__brl_payload,
+    )
+    webhook_with_duplicated_transaction.process()
+    webhook_with_duplicated_transaction.refresh_from_db()
+
+    assert webhook_with_duplicated_transaction.status == ProcessingStatus.DUPLICATED