provider.go: pass the provider.CredentialInfo to getClientSchema directly

Author: viscropst

provider.go

@@ -101,12 +101,11 @@ func (p *Provider) getClient() error {
 }
 
 func (p *Provider) getClientWithZone(zone string) error {
-	cred := NewCredentialInfo(p.AccessKeyID, p.AccessKeySecret, p.RegionID)
 	var err error
 	if len(zone) == 0 {
-		p.client, err = getClient(cred)
+		p.client, err = getClient(&p.CredentialInfo)
 	} else {
-		p.client, err = getClient(cred, zone)
+		p.client, err = getClient(&p.CredentialInfo, zone)
 	}
 	if err != nil {
 		return err

schema.go

@@ -47,21 +47,13 @@ type keyPair struct {
 	Value string
 }
 
-func NewCredentialInfo(accessKeyID, accessKeySecret, regionID string) *CredentialInfo {
-	if accessKeyID == "" || accessKeySecret == "" {
-		return nil
-	}
-	if len(regionID) == 0 {
-		regionID = defaultRegionID
+func getClientSchema(cred *CredentialInfo, scheme string) (*aliClientSchema, error) {
+	if cred.AccessKeyID == "" || cred.AccessKeySecret == "" {
+		return nil, errors.New("empty AccessKeyID or AccessKeySecret")
 	}
-	return &CredentialInfo{
-		AccessKeyID:     accessKeyID,
-		AccessKeySecret: accessKeySecret,
-		RegionID:        regionID,
+	if len(cred.RegionID) == 0 {
+		cred.RegionID = defaultRegionID
 	}
-}
-
-func getClientSchema(cred *CredentialInfo, scheme string) (*aliClientSchema, error) {
 	return defaultSchemaV3(cred, scheme)
 }