Merge pull request #1446 from liberu-genealogy/copilot/fix-dna-triangulation-service-error

Fix PHPUnit 12 test discovery and dna_matchings nullable image column

Author: delicatacurtis

database/migrations/2021_10_09_172842_create_dna_matchings_table.php

@@ -15,7 +15,7 @@ public function up()
         Schema::create('dna_matchings', function (Blueprint $table) {
             $table->bigIncrements('id');
             $table->foreignId('user_id')->constrained('users');
-            $table->string('image');
+            $table->string('image')->nullable();
             $table->string('file1');
             $table->string('file2');
             $table->string('total_shared_cm')->nullable();

tests/Feature/ModuleSystemTest.php

@@ -18,23 +18,20 @@ protected function setUp(): void
         $this->moduleManager = app(ModuleManager::class);
     }
 
-    /** @test */
-    public function it_can_list_all_modules()
+    public function test_it_can_list_all_modules(): void
     {
         $modules = $this->moduleManager->all();
         $this->assertNotEmpty($modules);
     }
 
-    /** @test */
-    public function it_can_get_module_by_name()
+    public function test_it_can_get_module_by_name(): void
     {
         $module = $this->moduleManager->get('Core');
         $this->assertNotNull($module);
         $this->assertEquals('Core', $module->getName());
     }
 
-    /** @test */
-    public function it_can_enable_and_disable_modules()
+    public function test_it_can_enable_and_disable_modules(): void
     {
         // First enable Core since other modules depend on it
         $coreModule = $this->moduleManager->get('Core');
@@ -57,8 +54,7 @@ public function it_can_enable_and_disable_modules()
         $this->assertFalse($module->isEnabled());
     }
 
-    /** @test */
-    public function it_can_get_module_info()
+    public function test_it_can_get_module_info(): void
     {
         $info = $this->moduleManager->getModuleInfo('Core');
 
@@ -68,8 +64,7 @@ public function it_can_get_module_info()
         $this->assertEquals('Core', $info['name']);
     }
 
-    /** @test */
-    public function it_returns_false_for_non_existent_modules()
+    public function test_it_returns_false_for_non_existent_modules(): void
     {
         $result = $this->moduleManager->enable('NonExistentModule');
         $this->assertFalse($result);