Merge pull request #1484 from liberu-genealogy/copilot/fix-after-create-method-bug

Fix missing afterCreate() in CreateGedcom and make ImportJobResource index-only

Author: curtisdelicata

app/Filament/App/Resources/GedcomResource/Pages/CreateGedcom.php

@@ -31,16 +31,25 @@ protected function handleRecordCreation(array $data): Model
             $path     = $filtered !== [] ? $filtered[0] : null;
         }
 
+        $data['filename'] = (string) ($path ?? '');
+
+        return Gedcom::create($data);
+    }
+
+    protected function afterCreate(): void
+    {
+        $path = $this->record->filename;
+
+        // FileUpload may store as array even when multiple(false) is set
+        if (is_array($path)) {
+            $filtered = array_values(array_filter($path));
+            $path     = $filtered !== [] ? $filtered[0] : null;
+        }
+
         $path = (string) ($path ?? '');
 
         if (! $path) {
-            Notification::make()
-                ->title('No file selected')
-                ->body('Please upload a GEDCOM or GrampsXML file.')
-                ->danger()
-                ->send();
-
-            $this->halt();
+            return;
         }
 
         $disk = Storage::disk('private');
@@ -51,34 +60,22 @@ protected function handleRecordCreation(array $data): Model
         if (str_starts_with($path, 'livewire-tmp/') && $disk->exists($path)) {
             $newPath = 'gedcom-form-imports/' . basename($path);
             $disk->move($path, $newPath);
-            $path          = $newPath;
-            $data['filename'] = $newPath;
+            $path = $newPath;
+            $this->record->update(['filename' => $newPath]);
 
             Log::info('CreateGedcom: moved upload from livewire-tmp to gedcom-form-imports', [
                 'new_path' => $newPath,
             ]);
         }
 
-        // Ensure the (possibly moved) filename is written into the record
-        $data['filename'] = $path;
-        $gedcom           = Gedcom::create($data);
-
         // Verify the file actually exists before dispatching the job
         if (! $disk->exists($path)) {
             Log::error('CreateGedcom: file does not exist on private disk, aborting dispatch', [
-                'gedcom_id' => $gedcom->getKey(),
+                'gedcom_id' => $this->record->getKey(),
                 'path'      => $path,
             ]);
 
-            $gedcom->delete();
-
-            Notification::make()
-                ->title('Import failed')
-                ->body('The uploaded file could not be found. Please try uploading again.')
-                ->danger()
-                ->send();
-
-            $this->halt();
+            return;
         }
 
         $fullPath  = $disk->path($path);
@@ -109,7 +106,7 @@ protected function handleRecordCreation(array $data): Model
                 ->send();
         } catch (Throwable $e) {
             Log::error('Failed to dispatch GEDCOM import job', [
-                'gedcom_id' => $gedcom->getKey(),
+                'gedcom_id' => $this->record->getKey(),
                 'path'      => $path,
                 'full_path' => $fullPath,
                 'error'     => $e->getMessage(),
@@ -122,8 +119,6 @@ protected function handleRecordCreation(array $data): Model
                 ->danger()
                 ->send();
         }
-
-        return $gedcom;
     }
 
     /**

app/Filament/App/Resources/ImportJobResource.php

@@ -3,9 +3,7 @@
 namespace App\Filament\App\Resources;
 
 use App\Filament\App\Resources\ImportJobResource\Pages\ListImportJobs;
-use App\Filament\App\Resources\ImportJobResource\Pages\ViewImportJob;
 use App\Models\ImportJob;
-use Filament\Actions\ViewAction;
 use Filament\Tables\Columns\TextColumn;
 use Filament\Tables\Table;
 use Illuminate\Database\Eloquent\Builder;
@@ -92,17 +90,14 @@ public static function table(Table $table): Table
             ])
             ->defaultSort('created_at', 'desc')
             ->filters([])
-            ->recordActions([
-                ViewAction::make(),
-            ])
+            ->recordActions([])
             ->toolbarActions([]);
     }
 
     public static function getPages(): array
     {
         return [
             'index' => ListImportJobs::route('/'),
-            'view'  => ViewImportJob::route('/{record}'),
         ];
     }
 }