Skip to content

connmgr.WithEmergencyTrim is broken #3216

Closed
@sukunrt

Description

@sukunrt

This Option is broken. It expects users to call:

watchdog.SystemDriven or watchdog.HeapDriven to actually do the trimming in times of an emergency, but this isn't documented anywhere. No user of this option calls these methods(https://github.com/search?q=WithEmergencyTrim&type=code)

I propose removing this completely. We should expose a ForceTrim option that closes the connection in times of an emergency, but the application should decide when it's necessary to ForceTrim the connection.

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/bugA bug in existing code (including security flaws)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions