chore: linting and tests

Author: achingbrain

packages/transport-webrtc/src/private-to-public/transport.browser.ts

@@ -2,6 +2,7 @@ import { serviceCapabilities, transportSymbol } from '@libp2p/interface'
 import { peerIdFromString } from '@libp2p/peer-id'
 import { CODE_P2P } from '@multiformats/multiaddr'
 import { WebRTCDirect } from '@multiformats/multiaddr-matcher'
+import { UnimplementedError } from '../error.ts'
 import { genUfrag } from '../util.js'
 import { connect } from './utils/connect.js'
 import { createDialerRTCPeerConnection } from './utils/get-rtcpeerconnection.js'
@@ -12,7 +13,6 @@ import type { TransportManager } from '@libp2p/interface-internal'
 import type { Keychain } from '@libp2p/keychain'
 import type { Multiaddr } from '@multiformats/multiaddr'
 import type { Datastore } from 'interface-datastore'
-import { UnimplementedError } from '../error.ts'
 
 export interface WebRTCDirectTransportComponents {
   peerId: PeerId

packages/transport-webrtc/src/private-to-public/transport.ts

@@ -10,14 +10,14 @@ import { equals as uint8ArrayEquals } from 'uint8arrays/equals'
 import { fromString as uint8ArrayFromString } from 'uint8arrays/from-string'
 import { DEFAULT_CERTIFICATE_DATASTORE_KEY, DEFAULT_CERTIFICATE_LIFESPAN, DEFAULT_CERTIFICATE_PRIVATE_KEY_NAME, DEFAULT_CERTIFICATE_RENEWAL_THRESHOLD } from '../constants.js'
 import { WebRTCDirectListener } from './listener.js'
+import { WebRTCDirectTransport as WebRTCDirectBrowserTransport } from './transport.browser.js'
 import { formatAsPem } from './utils/pem.js'
 import type { TransportCertificate } from '../index.js'
+import type { WebRTCTransportDirectInit as WebRTCTransportDirectBrowserInit, WebRTCMetrics, WebRTCDirectTransportComponents } from './transport.browser.ts'
 import type { CreateListenerOptions, Transport, Listener, PrivateKey, Startable } from '@libp2p/interface'
 import type { Keychain } from '@libp2p/keychain'
 import type { Multiaddr } from '@multiformats/multiaddr'
 import type { TypedEventTarget } from 'main-event'
-import { WebRTCDirectTransport as WebRTCDirectBrowserTransport } from './transport.browser.js'
-import type { WebRTCTransportDirectInit as WebRTCTransportDirectBrowserInit, WebRTCMetrics, WebRTCDirectTransportComponents } from './transport.browser.ts'
 
 export type { WebRTCMetrics, WebRTCDirectTransportComponents }
 

packages/transport-webrtc/test/transport.spec.ts

@@ -32,6 +32,8 @@ function assertAllMultiaddrsHaveSamePort (addrs: Multiaddr[]): void {
   }
 }
 
+const LISTEN_SUPPORTED = isNode || isElectronMain
+
 describe('WebRTCDirect Transport', () => {
   let components: WebRTCDirectTransportComponents
   let listener: Listener
@@ -68,9 +70,11 @@ describe('WebRTCDirect Transport', () => {
 
     await start(transport)
 
-    listener = transport.createListener({
-      upgrader
-    })
+    if (LISTEN_SUPPORTED) {
+      listener = transport.createListener({
+        upgrader
+      })
+    }
   })
 
   afterEach(async () => {
@@ -102,14 +106,21 @@ describe('WebRTCDirect Transport', () => {
       multiaddr('/ip4/1.2.3.4/udp/1234/certhash/uEiAUqV7kzvM1wI5DYDc1RbcekYVmXli_Qprlw3IkiEg6tQ/p2p/12D3KooWGDMwwqrpcYKpKCgxuKT2NfqPqa94QnkoBBpqvCaiCzWd')
     ]
 
-    expect(transport.listenFilter([
-      ...valid,
-      ...invalid
-    ])).to.deep.equal(valid)
+    if (LISTEN_SUPPORTED) {
+      expect(transport.listenFilter([
+        ...valid,
+        ...invalid
+      ])).to.deep.equal(valid)
+    } else {
+      expect(transport.listenFilter([
+        ...valid,
+        ...invalid
+      ])).to.be.empty()
+    }
   })
 
   it('can listen on ipv4 and ipv6 on the same port in series', async function () {
-    if ((!isNode && !isElectronMain) || !supportsIpV6()) {
+    if (!LISTEN_SUPPORTED || !supportsIpV6()) {
       return this.skip()
     }
 
@@ -125,7 +136,7 @@ describe('WebRTCDirect Transport', () => {
   })
 
   it('can listen on ipv4 and ipv6 on the same port in parallel', async function () {
-    if ((!isNode && !isElectronMain) || !supportsIpV6()) {
+    if (!LISTEN_SUPPORTED || !supportsIpV6()) {
       return this.skip()
     }
 
@@ -143,7 +154,7 @@ describe('WebRTCDirect Transport', () => {
   })
 
   it('can listen on wildcard IPv4 hosts', async function () {
-    if ((!isNode && !isElectronMain) || !supportsIpV6()) {
+    if (!LISTEN_SUPPORTED || !supportsIpV6()) {
       return this.skip()
     }
 
@@ -168,7 +179,7 @@ describe('WebRTCDirect Transport', () => {
   })
 
   it('can listen on wildcard IPv6 hosts', async function () {
-    if ((!isNode && !isElectronMain) || !supportsIpV6()) {
+    if (!LISTEN_SUPPORTED || !supportsIpV6()) {
       return this.skip()
     }
 
@@ -193,7 +204,7 @@ describe('WebRTCDirect Transport', () => {
   })
 
   it('should add certificate to announce addresses', async function () {
-    if ((!isNode && !isElectronMain) || !supportsIpV6()) {
+    if (!LISTEN_SUPPORTED || !supportsIpV6()) {
       return this.skip()
     }
 
@@ -225,7 +236,7 @@ describe('WebRTCDirect Transport', () => {
   })
 
   it('can start listeners for two nodes on wildcard socket addresses', async function () {
-    if ((!isNode && !isElectronMain) || !supportsIpV6()) {
+    if (!LISTEN_SUPPORTED || !supportsIpV6()) {
       return this.skip()
     }
 
@@ -268,7 +279,7 @@ describe('WebRTCDirect Transport', () => {
   })
 
   it('can start multiple wildcard listeners', async function () {
-    if ((!isNode && !isElectronMain) || !supportsIpV6()) {
+    if (!LISTEN_SUPPORTED || !supportsIpV6()) {
       return this.skip()
     }