Skip to content

Commit 4d671d1

Browse files
committed
chore: disable Firefox interop tests
Firefox 134.0 has broken interop as it can no longer dial go-libp2p. The regression is fixed in Firefox Nightly (136.0) so disable interop testing until that has been released and Playwright has upgraded the version it supports (likely some time in March).
1 parent 31a15a1 commit 4d671d1

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.github/workflows/main.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,9 @@ jobs:
231231
- uses: libp2p/test-plans/.github/actions/run-interop-ping-test@master
232232
with:
233233
test-filter: js-libp2p-head
234-
extra-versions: ${{ github.workspace }}/interop/node-version.json ${{ github.workspace }}/interop/chromium-version.json ${{ github.workspace }}/interop/firefox-version.json
234+
# disable firefox interop (revert once playwright runs ff 136.0)
235+
# extra-versions: ${{ github.workspace }}/interop/node-version.json ${{ github.workspace }}/interop/chromium-version.json ${{ github.workspace }}/interop/firefox-version.json
236+
extra-versions: ${{ github.workspace }}/interop/node-version.json ${{ github.workspace }}/interop/chromium-version.json
235237
s3-cache-bucket: ${{ vars.S3_LIBP2P_BUILD_CACHE_BUCKET_NAME }}
236238
s3-access-key-id: ${{ vars.S3_LIBP2P_BUILD_CACHE_AWS_ACCESS_KEY_ID }}
237239
s3-secret-access-key: ${{ secrets.S3_LIBP2P_BUILD_CACHE_AWS_SECRET_ACCESS_KEY }}

0 commit comments

Comments
 (0)