log message id if send queue full instead of full raw message

[gftea]

Description

the send queue full warning logs the whole raw message data which result in massive log size
e.g.

{"timestamp":"2026-01-16T20:33:01.517","level":"WARN","message":"Send Queue full. Could not send Forward { message: RawMessage { source: Some(        PeerId("16Uiu2HAmBFinmDjuVPs5ptgy3tTTyh5RcG9oRqjK2494Y5nsyVE4")), data: [3, 0, 0, 0, 0, 0, 0, 0, 0, 110, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,         0, 0, 0, 200, 40, 1, 0, 0, 197, 126, 18, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 20, 46, 75, 250, 7, 109, 118, 184, 101, 52, 162, 23, 118, 174        , 212, 83, 172, 109, 18, 58, 116, 32, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 36, 20, 6,         250, 241, 114, 1 (edited)

Motivation

in high load traffic, high volume of warning messages like this result in extreme large log files, and also increase disk I/O load unncessary, while the rawMessage is not useful for debug, but msg id would be more useful

Current Implementation

current impl log the debug format

tracing::warn!(peer=%peer_id, "Send Queue full. Could not send {:?}.", rpc);

/// A Gossipsub RPC message sent.
#[derive(Debug)]
pub enum RpcOut {
    /// Publish a Gossipsub message on network.`timeout` limits the duration the message
    /// can wait to be sent before it is abandoned.
    Publish { message: RawMessage, timeout: Delay },
    /// Forward a Gossipsub message on network. `timeout` limits the duration the message
    /// can wait to be sent before it is abandoned.
    Forward { message: RawMessage, timeout: Delay },
    /// Subscribe a topic.
    Subscribe(TopicHash),
    /// Unsubscribe a topic.
    Unsubscribe(TopicHash),
    /// Send a GRAFT control message.
    Graft(Graft),
    /// Send a PRUNE control message.
    Prune(Prune),
    /// Send a IHave control message.
    IHave(IHave),
    /// Send a IWant control message.
    IWant(IWant),
    /// The node requests us to not forward message ids (peer_id + sequence _number) - IDontWant
    /// control message.
    IDontWant(IDontWant),
}

### Are you planning to do it yourself in a pull request?

Maybe

[IronJam11]

hey, can i take up this issue

[elenaf9]

Logging just the message id (and maybe some other meta data) sounds reasonable to me. Wdyt @jxs?

[jxs]

thanks for the ping Elena, yeah makes sense

[IronJam11]

thank you for your input @elenaf9 . I'll try implementing it if its fine by your side. (was busy with another issue all this while)

[xpanvictor]

Hello @gftea @elenaf9 @IronJam11, want to confirm if this has been worked on. I can send a PR referencing this if approved.
My approach would be either an RpcOut::kind() and ?message_id() accessor or an RpcLog wrapper with it's Display impl to avoid messing with current enum.
Kindly let me know if I can hop on this and if my approach is good enough.
I'm on the current pldg cohort.

[gftea]

@xpanvictor , I am not working on it, I think it need to change some data types to avoid clone, because the message id fn is defined by user which has input type Message, not RawMessage, and if to calc the message id, it need to convert to Message in order to call the existing callback signature, such conversion at present requires cloning which is not ideal

[xpanvictor]

@xpanvictor , I am not working on it, I think it need to change some data types to avoid clone, because the message id fn is defined by user which has input type Message, not RawMessage, and if to calc the message id, it need to convert to Message in order to call the existing callback signature, such conversion at present requires cloning which is not ideal

Yes, thank you for the suggestions. I've reviewed it again and I can see exactly what you're saying and how it'll require copying since full Message is required to build the id.

I was initially considering computing message_id at ingress and using a wrapper struct on RawMessage to include the id however I noticed we already have the id for Publish|Forward directly and we can log the full details for those without RawMessage.

an implementation like this

pub(crate) struct RpcLog<'a> {
    rpc: &'a RpcOut,
}

impl<'a> Debug for RpcLog<'a> {
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
        let mut b = f.debug_struct("RpcLog");
        // can add some form of RpcType
        match self.rpc {
            RpcOut::Forward { message_id, .. } | RpcOut::Publish { message_id, .. } => {
                b.field("MessageId", message_id);
            }
            _ => {
                b.field("RpcOut", self);
            }
        }
        b.finish()
    }
}