Skip to content
This repository was archived by the owner on Dec 11, 2023. It is now read-only.
This repository was archived by the owner on Dec 11, 2023. It is now read-only.

V2 references Faraday::Error::ConnectionFailed, which doesn't exist in newer versions of Faraday #144

Open
@patbl

Description

@patbl

A long time ago, Faraday::Error::ConnectionFailed was moved to Faraday::ConnectionFailed. This mismatch results in the following error:

Check failed to run: uninitialized constant Faraday::Error::ConnectionFailed
Did you mean?  Faraday::ConnectionFailed

Here's the line that raises the exception: https://github.com/librato/librato-metrics/blob/v2.1.2/lib/librato/metrics/middleware/retry.rb#L19

The error class was updated on the 1.x branch here, but the 2.x branch still uses the old class.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions