Update golangci-lint to version 2

Newer golangci-lint uses a new configuration format and cannot load the
old format. To avoid complications this change migrates the existing
linter configuration to version 2 format and updates the CI pipeline
accordingly.

Author: longsleep

.github/workflows/build.yml

@@ -35,12 +35,11 @@ jobs:
         make -C identifier vendor
 
     - name: Lint
-      uses: golangci/golangci-lint-action@v4
+      uses: golangci/golangci-lint-action@v8
       with:
         version: latest
         args: --timeout=2m
-        skip-pkg-cache: true
-        skip-build-cache: true
+        skip-cache: true
         only-new-issues: true
 
     - name: Build

.golangci.yaml

@@ -1,43 +1,9 @@
+version: "2"
 run:
   modules-download-mode: vendor
   issues-exit-code: 0
-
-linters-settings:
-  govet:
-    settings:
-      printf:
-        funcs:
-          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Infof
-          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Warnf
-          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Errorf
-          - (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf
-  gocyclo:
-    min-complexity: 10
-  maligned:
-    suggest-new: true
-  dupl:
-    threshold: 100
-  goconst:
-    min-len: 2
-    min-occurrences: 2
-  misspell:
-    locale: US
-  lll:
-    line-length: 200
-  goimports:
-    local-prefixes: github.com/libregraph/lico
-  gocritic:
-    enabled-tags:
-      - performance
-      - style
-      - experimental
-  revive:
-    min-confidence: 0
-  shadow:
-
 linters:
-  # inverted configuration with `enable-all` and `disable` is not scalable during updates of golangci-lint
-  disable-all: true
+  default: none
   enable:
     - bodyclose
     - copyloopvar
@@ -48,27 +14,66 @@ linters:
     - goconst
     - gocritic
     - gocyclo
-    - gofmt
-    - goimports
     - gosec
-    - gosimple
     - govet
     - ineffassign
     - lll
     - misspell
     - nakedret
     - revive
     - staticcheck
-    - stylecheck
-    - typecheck
     - unconvert
     - unparam
     - unused
-
-  # don't enable:
-  # - depguard - until https://github.com/OpenPeeDeeP/depguard/issues/7 gets fixed
-  # - maligned,prealloc
-  # - gochecknoglobals
-
+  settings:
+    dupl:
+      threshold: 100
+    goconst:
+      min-len: 2
+      min-occurrences: 2
+    gocritic:
+      enabled-tags:
+        - performance
+        - style
+        - experimental
+    gocyclo:
+      min-complexity: 10
+    govet:
+      settings:
+        printf:
+          funcs:
+            - (github.com/golangci/golangci-lint/pkg/logutils.Log).Infof
+            - (github.com/golangci/golangci-lint/pkg/logutils.Log).Warnf
+            - (github.com/golangci/golangci-lint/pkg/logutils.Log).Errorf
+            - (github.com/golangci/golangci-lint/pkg/logutils.Log).Fatalf
+    lll:
+      line-length: 200
+    misspell:
+      locale: US
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
 severity:
-  default-severity: warning
+  default: warning
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  settings:
+    goimports:
+      local-prefixes:
+        - github.com/libregraph/lico
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$