Skip to content

Commit dd1ce2c

Browse files
committed
Fixed vulnerability in json.php caused my missing Content-Type header
1 parent 748f49c commit dd1ce2c

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

results/json.php

+6-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
<?php
22

3+
error_reporting(0);
4+
header('Content-Type: application/json; charset=utf-8');
5+
36
require_once 'telemetry_db.php';
47

58
/**
@@ -53,7 +56,7 @@ function formatSpeedtestData($speedtest)
5356
$speedtest = getSpeedtestUserById($_GET['id']);
5457
if (!is_array($speedtest)) {
5558
echo '{}';
59+
} else {
60+
$speedtest = formatSpeedtestData($speedtest);
61+
echo json_encode(array('timestamp'=>$speedtest['timestamp'],'download'=>$speedtest['dl'],'upload'=>$speedtest['ul'],'ping'=>$speedtest['ping'],'jitter'=>$speedtest['jitter'],'ispinfo'=>$speedtest['ispinfo']));
5662
}
57-
$speedtest = formatSpeedtestData($speedtest);
58-
59-
echo json_encode(array('timestamp'=>$speedtest['timestamp'],'download'=>$speedtest['dl'],'upload'=>$speedtest['ul'],'ping'=>$speedtest['ping'],'jitter'=>$speedtest['jitter'],'ispinfo'=>$speedtest['ispinfo']));

speedtest.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ function Speedtest() {
4949
this._settings = {}; //settings for the speed test worker
5050
this._state = 0; //0=adding settings, 1=adding servers, 2=server selection done, 3=test running, 4=done
5151
console.log(
52-
"LibreSpeed by Federico Dossena v5.3.0 - https://github.com/librespeed/speedtest"
52+
"LibreSpeed by Federico Dossena v5.3.1 - https://github.com/librespeed/speedtest"
5353
);
5454
}
5555

0 commit comments

Comments
 (0)