menu_displaylist: let the screen arrays lead where code was bypassing them

An audit of all fifty-two array-driven screens against the dump
found the arrays lead perfectly on order - zero violations, even
across cases holding several arrays - but thirty-five shown rows
were injected by case code beside them. Thirty are legitimately
parametric or capability-absolute: the netplay per-user loop, the
cheat rows keyed on the current index, and the latency screen's
driver-flag cascade, which must stay hidden even from
include-everything and so cannot be a checked entry today. The
five that were plain bypasses are fixed where the grammar allows:
the frame-time auto-reset toggle becomes a checked entry with its
hiding rule in the standard toggle switch, and the updater action
row joins the core screen's array as PARSE_ACTION. The core
manager row stays coded and documented: it has no backing setting,
and settingless action rows are a real gap in the array grammar,
alongside absolute conditions and interleaved positions - the
three things a layout definition format has to express. All three
dump passes byte-identical.

Author: libretroadmin

menu/menu_displaylist.c

@@ -11918,6 +11918,9 @@ unsigned menu_displaylist_build_list(
       case DISPLAYLIST_CORE_SETTINGS_LIST:
          {
             static const menu_displaylist_build_info_t build_list[] = {
+#ifdef HAVE_ONLINE_UPDATER
+               {MENU_ENUM_LABEL_UPDATER_SETTINGS,                  PARSE_ACTION},
+#endif
                {MENU_ENUM_LABEL_CORE_INFO_CACHE_ENABLE,            PARSE_ONLY_BOOL},
                {MENU_ENUM_LABEL_CORE_INFO_SAVESTATE_BYPASS,        PARSE_ONLY_BOOL},
                {MENU_ENUM_LABEL_SYSTEMFILES_IN_CONTENT_DIR_ENABLE, PARSE_ONLY_BOOL},
@@ -11938,14 +11941,9 @@ unsigned menu_displaylist_build_list(
                      MENU_SETTING_ACTION, 0, 0, NULL))
                count++;
 
-#ifdef HAVE_ONLINE_UPDATER
-            if (menu_entries_append(list,
-                     msg_hash_to_str(MENU_ENUM_LABEL_VALUE_UPDATER_SETTINGS),
-                     msg_hash_to_str(MENU_ENUM_LABEL_UPDATER_SETTINGS),
-                     MENU_ENUM_LABEL_UPDATER_SETTINGS,
-                     MENU_SETTING_ACTION, 0, 0, NULL))
-               count++;
-#endif
+            /* core_manager_list has no backing setting, so it cannot
+             * be a PARSE_ACTION array entry; the raw append above is
+             * the only mechanism for settingless action rows today. */
 
             for (i = 0; i < ARRAY_SIZE(build_list); i++)
             {
@@ -12107,27 +12105,36 @@ unsigned menu_displaylist_build_list(
       case DISPLAYLIST_FRAME_TIME_COUNTER_SETTINGS_LIST:
          {
             static menu_displaylist_build_info_selective_t build_list[] = {
-               {MENU_ENUM_LABEL_VIDEO_REFRESH_RATE_AUTO, PARSE_ONLY_FLOAT, true},
-               {MENU_ENUM_LABEL_VIDEO_FRAME_TIME_SAMPLE_GATED, PARSE_ONLY_BOOL, true},
+               {MENU_ENUM_LABEL_VIDEO_REFRESH_RATE_AUTO,       PARSE_ONLY_FLOAT, true},
+               {MENU_ENUM_LABEL_VIDEO_FRAME_TIME_SAMPLE_GATED, PARSE_ONLY_BOOL,  true},
+               /* Auto-reset toggle is redundant when gated sampling
+                * is active (no contamination enters the buffer to
+                * begin with), so it is hidden in that case to keep
+                * the menu focused. */
+               {MENU_ENUM_LABEL_FRAME_TIME_COUNTER_AUTO_RESET, PARSE_ONLY_BOOL,  true},
             };
 
             for (i = 0; i < ARRAY_SIZE(build_list); i++)
             {
-               if (MENU_DISPLAYLIST_PARSE_SETTINGS_ENUM(list,
-                        build_list[i].enum_idx,  build_list[i].parse_type,
-                        false) == 0)
-                  count++;
+               switch (build_list[i].enum_idx)
+               {
+                  case MENU_ENUM_LABEL_FRAME_TIME_COUNTER_AUTO_RESET:
+                     build_list[i].checked =
+                           !settings->bools.video_frame_time_sample_gated;
+                     break;
+                  default:
+                     break;
+               }
             }
 
-            /* Auto-reset toggle is redundant when gated sampling
-             * is active (no contamination enters the buffer to
-             * begin with), so hide it in that case to keep the
-             * menu focused. */
-            if (!settings->bools.video_frame_time_sample_gated)
+            for (i = 0; i < ARRAY_SIZE(build_list); i++)
             {
+               if (!build_list[i].checked && !include_everything)
+                  continue;
+
                if (MENU_DISPLAYLIST_PARSE_SETTINGS_ENUM(list,
-                        MENU_ENUM_LABEL_FRAME_TIME_COUNTER_AUTO_RESET,
-                        PARSE_ONLY_BOOL, false) == 0)
+                        build_list[i].enum_idx,  build_list[i].parse_type,
+                        false) == 0)
                   count++;
             }
          }