menu_setting: move the MIDI device selectors into descriptor rows

The MIDI input and output pickers were built by hand with their
four device-cycling handlers - start, left, right, ok - poked on
after construction. They are S_STRING rows now, those handlers
riding in the slots the grammar already provides; the builder body
drops the two CONFIG_STRING blocks for one ADD_DESC under the same
non-console guard. Settings dump byte-identical, so both defaults,
the empty flag word and all four handlers reproduced exactly;
referee reads two more settings index-faithful, two fewer hand
built. Net 23 lines from the builder plus a 21-line def file.

Second of the fully-movable hand-CONFIG builders to cross. Noted
in passing: core_updater looked movable by raw handler shape but
is not - its buildbot URLs sit inside an Android play-feature
runtime guard and its backup uint is interleaved with a computed
offset_by range, so it needs interleaving and runtime-condition
grammar the rows do not have yet, and stays coded.

Author: libretroadmin

menu/menu_setting.c

@@ -12560,6 +12560,13 @@ static const setting_desc_t privacy_desc_2[] = {
 };
 
 #if !defined(RARCH_CONSOLE)
+#if !defined(RARCH_CONSOLE)
+static const setting_desc_t midi_devices_desc_0[] = {
+/* GENERATED: rows come from settings_def_midi_devices.h in order. */
+#include "../settings/settings_def_midi_devices.h"
+};
+#endif
+
 static const setting_desc_t midi_desc_0[] = {
 /* GENERATED: rows come from settings_def_midi_volume.h in order. */
 #include "../settings/settings_def_midi_volume.h"
@@ -17026,40 +17033,7 @@ static void settings_build_midi(
             &group_info, &subgroup_info, parent_group);
 
 #if !defined(RARCH_CONSOLE)
-      /* Descriptor holdout: poke tail outside the descriptor grammar. */
-      CONFIG_STRING(
-            list, list_info,
-            settings->arrays.midi_input,
-            sizeof(settings->arrays.midi_input),
-            MENU_ENUM_LABEL_MIDI_INPUT,
-            MENU_ENUM_LABEL_VALUE_MIDI_INPUT,
-            DEFAULT_MIDI_INPUT,
-            &group_info,
-            &subgroup_info,
-            parent_group,
-            general_write_handler,
-            general_read_handler);
-      SETTINGS_ACTION_SET(start, &(*list)[list_info->index - 1], setting_string_action_start_midi_device)
-      SETTINGS_ACTION_SET(left, &(*list)[list_info->index - 1], setting_string_action_left_midi_input)
-      SETTINGS_ACTION_SET(right, &(*list)[list_info->index - 1], setting_string_action_right_midi_input)
-      SETTINGS_ACTION_SET(ok, &(*list)[list_info->index - 1], setting_string_action_ok_midi_device)
-
-      CONFIG_STRING(
-            list, list_info,
-            settings->arrays.midi_output,
-            sizeof(settings->arrays.midi_output),
-            MENU_ENUM_LABEL_MIDI_OUTPUT,
-            MENU_ENUM_LABEL_VALUE_MIDI_OUTPUT,
-            DEFAULT_MIDI_OUTPUT,
-            &group_info,
-            &subgroup_info,
-            parent_group,
-            general_write_handler,
-            general_read_handler);
-      SETTINGS_ACTION_SET(start, &(*list)[list_info->index - 1], setting_string_action_start_midi_device)
-      SETTINGS_ACTION_SET(left, &(*list)[list_info->index - 1], setting_string_action_left_midi_output)
-      SETTINGS_ACTION_SET(right, &(*list)[list_info->index - 1], setting_string_action_right_midi_output)
-      SETTINGS_ACTION_SET(ok, &(*list)[list_info->index - 1], setting_string_action_ok_midi_device)
+            ADD_DESC(midi_devices_desc_0);
 
             ADD_DESC(midi_desc_0);
 #endif
@@ -18160,6 +18134,9 @@ static const settings_desc_table_t settings_desc_registry[] = {
 #endif
    { privacy_desc_2, (uint16_t)ARRAY_SIZE(privacy_desc_2) },
 #if !defined(RARCH_CONSOLE)
+#if !defined(RARCH_CONSOLE)
+   { midi_devices_desc_0, (uint16_t)ARRAY_SIZE(midi_devices_desc_0) },
+#endif
    { midi_desc_0, (uint16_t)ARRAY_SIZE(midi_desc_0) },
 #endif
 #ifdef HAVE_MIST

settings/settings_def_midi_devices.h

@@ -0,0 +1,20 @@
+/* Single-source definitions: MIDI input/output device selectors.
+ * Grammar identical to settings_def_video_sync.h plus S_FLOAT and
+ * the _NS no-sublabel variants; the descriptor argument span
+ * matches SDESC_<kind>_ROW; row order is menu display order;
+ * h2json.py parses these rows for the Crowdin source upload. */
+
+#if !defined(RARCH_CONSOLE)
+/* Device pickers: start/left/right/ok cycle the enumerated MIDI
+ * devices, so those four handlers ride in the row. */
+S_STRING(midi_input, MIDI_INPUT,
+      "midi_input",
+      DEFAULT_MIDI_INPUT, SD_FLAG_NONE, 0, setting_string_action_ok_midi_device, NULL, setting_string_action_start_midi_device, NULL, setting_string_action_left_midi_input, setting_string_action_right_midi_input, 0,
+      "Input",
+      "Select input device.")
+S_STRING(midi_output, MIDI_OUTPUT,
+      "midi_output",
+      DEFAULT_MIDI_OUTPUT, SD_FLAG_NONE, 0, setting_string_action_ok_midi_device, NULL, setting_string_action_start_midi_device, NULL, setting_string_action_left_midi_output, setting_string_action_right_midi_output, 0,
+      "Output",
+      "Select output device.")
+#endif