Skip to content

Commit 9147de6

Browse files
libretroadminLibretroAdmin
authored andcommitted
settings: migrate the auto mouse grab setting to a single-source def file
Performed by tools/settings_migrate_group.py with the standard battery including the platform-profile lanes and the integrated enum consolidation stage; the lookup gate's parent baseline is computed per run.
1 parent baf190f commit 9147de6

8 files changed

Lines changed: 113 additions & 17 deletions

File tree

configuration.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1964,6 +1964,7 @@ static struct config_bool_setting *populate_settings_bool(
19641964
#include "settings/settings_def_video_fullscreen.h"
19651965
#define SETTINGS_DEF_CONFIG_PASS
19661966
#include "settings/settings_def_video_sync.h"
1967+
#include "settings/settings_def_input_auto_mouse_grab.h"
19671968
#if defined(HAVE_DINPUT) || defined(HAVE_WINRAWINPUT)
19681969
#include "settings/settings_def_input_nowinkey.h"
19691970
#endif
@@ -2224,7 +2225,6 @@ static struct config_bool_setting *populate_settings_bool(
22242225
SETTING_BOOL("input_autodetect_enable", &settings->bools.input_autodetect_enable, true, DEFAULT_INPUT_AUTODETECT_ENABLE, false);
22252226
SETTING_BOOL("input_turbo_enable", &settings->bools.input_turbo_enable, true, DEFAULT_TURBO_ENABLE, false);
22262227
SETTING_BOOL("input_turbo_allow_dpad", &settings->bools.input_turbo_allow_dpad, true, DEFAULT_TURBO_ALLOW_DPAD, false);
2227-
SETTING_BOOL("input_auto_mouse_grab", &settings->bools.input_auto_mouse_grab, true, DEFAULT_INPUT_AUTO_MOUSE_GRAB, false);
22282228
SETTING_BOOL("input_remap_binds_enable", &settings->bools.input_remap_binds_enable, true, true, false);
22292229
SETTING_BOOL("input_remap_sort_by_controller_enable", &settings->bools.input_remap_sort_by_controller_enable, true, false, false);
22302230
SETTING_BOOL("input_hotkey_device_merge", &settings->bools.input_hotkey_device_merge, true, DEFAULT_INPUT_HOTKEY_DEVICE_MERGE, false);
@@ -2348,6 +2348,7 @@ static struct config_float_setting *populate_settings_float(
23482348
#include "settings/settings_def_video_fullscreen.h"
23492349
#define SETTINGS_DEF_CONFIG_PASS
23502350
#include "settings/settings_def_video_sync.h"
2351+
#include "settings/settings_def_input_auto_mouse_grab.h"
23512352
#if defined(HAVE_DINPUT) || defined(HAVE_WINRAWINPUT)
23522353
#include "settings/settings_def_input_nowinkey.h"
23532354
#endif
@@ -2674,6 +2675,7 @@ static struct config_uint_setting *populate_settings_uint(
26742675
#include "settings/settings_def_video_fullscreen.h"
26752676
#define SETTINGS_DEF_CONFIG_PASS
26762677
#include "settings/settings_def_video_sync.h"
2678+
#include "settings/settings_def_input_auto_mouse_grab.h"
26772679
#if defined(HAVE_DINPUT) || defined(HAVE_WINRAWINPUT)
26782680
#include "settings/settings_def_input_nowinkey.h"
26792681
#endif
@@ -2975,6 +2977,7 @@ static struct config_int_setting *populate_settings_int(
29752977
#include "settings/settings_def_video_fullscreen.h"
29762978
#define SETTINGS_DEF_CONFIG_PASS
29772979
#include "settings/settings_def_video_sync.h"
2980+
#include "settings/settings_def_input_auto_mouse_grab.h"
29782981
#if defined(HAVE_DINPUT) || defined(HAVE_WINRAWINPUT)
29792982
#include "settings/settings_def_input_nowinkey.h"
29802983
#endif

intl/msg_hash_lbl.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1762,10 +1762,6 @@ MSG_HASH(
17621762
MENU_ENUM_LABEL_INPUT_SENSORS_ENABLE,
17631763
MENU_ENUM_LABEL_INPUT_SENSORS_ENABLE_STR
17641764
)
1765-
MSG_HASH(
1766-
MENU_ENUM_LABEL_INPUT_AUTO_MOUSE_GRAB,
1767-
MENU_ENUM_LABEL_INPUT_AUTO_MOUSE_GRAB_STR
1768-
)
17691765
MSG_HASH(
17701766
MENU_ENUM_LABEL_INPUT_AUTO_GAME_FOCUS,
17711767
MENU_ENUM_LABEL_INPUT_AUTO_GAME_FOCUS_STR

intl/msg_hash_us.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -537,6 +537,7 @@ static const char *const msg_hash_us_lbl_strs[] = {
537537
#define S_FLOAT_NS(f, T, n, d, rnd, sd, df, c, mn, mx, st, ok, rp, us) n,
538538
#include "../settings/settings_def_video_fullscreen.h"
539539
#include "../settings/settings_def_video_sync.h"
540+
#include "../settings/settings_def_input_auto_mouse_grab.h"
540541
#include "../settings/settings_def_input_nowinkey.h"
541542
#include "../settings/settings_def_overlay_enable.h"
542543
#include "../settings/settings_def_microphone.h"
@@ -603,6 +604,7 @@ static const uint32_t msg_hash_us_lbl_ids[] = {
603604
#define S_FLOAT_NS(f, T, n, d, rnd, sd, df, c, mn, mx, st, ok, rp, us) (uint32_t)MENU_ENUM_LABEL_##T,
604605
#include "../settings/settings_def_video_fullscreen.h"
605606
#include "../settings/settings_def_video_sync.h"
607+
#include "../settings/settings_def_input_auto_mouse_grab.h"
606608
#include "../settings/settings_def_input_nowinkey.h"
607609
#include "../settings/settings_def_overlay_enable.h"
608610
#include "../settings/settings_def_microphone.h"

intl/msg_hash_us.h

Lines changed: 32 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3612,14 +3612,38 @@ MSG_HASH(
36123612
MENU_ENUM_SUBLABEL_INPUT_SENSORS_ENABLE,
36133613
"Enable input from accelerometer, gyroscope and illuminance sensors, if supported by the current hardware. May have a performance impact and/or increase power drain on some platforms."
36143614
)
3615-
MSG_HASH(
3616-
MENU_ENUM_LABEL_VALUE_INPUT_AUTO_MOUSE_GRAB,
3617-
"Automatic Mouse Grab"
3618-
)
3619-
MSG_HASH(
3620-
MENU_ENUM_SUBLABEL_INPUT_AUTO_MOUSE_GRAB,
3621-
"Enable mouse grab on application focus."
3622-
)
3615+
/* GENERATED REGION: auto mouse grab setting (see settings_def_input_auto_mouse_grab.h). */
3616+
#define SETTINGS_DEF_STRINGS_PASS
3617+
#define S_BOOL(f, T, n, d, sd, df, c, us, sub) \
3618+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us) \
3619+
MSG_HASH(MENU_ENUM_SUBLABEL_##T, sub)
3620+
#define S_BOOL_NS(f, T, n, d, sd, df, c, us) \
3621+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us)
3622+
#define S_UINT(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us, sub) \
3623+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us) \
3624+
MSG_HASH(MENU_ENUM_SUBLABEL_##T, sub)
3625+
#define S_UINT_NS(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us) \
3626+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us)
3627+
#define S_INT(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us, sub) \
3628+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us) \
3629+
MSG_HASH(MENU_ENUM_SUBLABEL_##T, sub)
3630+
#define S_INT_NS(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us) \
3631+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us)
3632+
#define S_FLOAT(f, T, n, d, rnd, sd, df, c, mn, mx, st, ok, rp, us, sub) \
3633+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us) \
3634+
MSG_HASH(MENU_ENUM_SUBLABEL_##T, sub)
3635+
#define S_FLOAT_NS(f, T, n, d, rnd, sd, df, c, mn, mx, st, ok, rp, us) \
3636+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us)
3637+
#include "../settings/settings_def_input_auto_mouse_grab.h"
3638+
#undef S_BOOL
3639+
#undef S_BOOL_NS
3640+
#undef S_UINT
3641+
#undef S_UINT_NS
3642+
#undef S_INT
3643+
#undef S_INT_NS
3644+
#undef S_FLOAT
3645+
#undef S_FLOAT_NS
3646+
#undef SETTINGS_DEF_STRINGS_PASS
36233647
MSG_HASH(
36243648
MENU_ENUM_LABEL_VALUE_INPUT_AUTO_GAME_FOCUS,
36253649
"Auto Enable 'Game Focus' Mode"

menu/menu_setting.c

Lines changed: 26 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15187,8 +15187,32 @@ static bool setting_append_list(
1518715187

1518815188
{
1518915189
static const setting_desc_t inp_desc_8[] = {
15190-
SDESC_BOOL_ROW(input_auto_mouse_grab, INPUT_AUTO_MOUSE_GRAB,
15191-
DEFAULT_INPUT_AUTO_MOUSE_GRAB, SD_FLAG_NONE, 0, 0),
15190+
/* GENERATED: rows come from settings_def_input_auto_mouse_grab.h in order. */
15191+
#define S_BOOL(f, T, n, d, sd, df, c, us, sub) \
15192+
SDESC_BOOL_ROW(f, T, d, sd, df, c),
15193+
#define S_BOOL_NS(f, T, n, d, sd, df, c, us) \
15194+
SDESC_BOOL_ROW(f, T, d, sd, df, c),
15195+
#define S_UINT(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us, sub) \
15196+
SDESC_UINT_ROW(f, T, d, sd, df, c, mn, mx, st, ob, ok, rp),
15197+
#define S_UINT_NS(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us) \
15198+
SDESC_UINT_ROW(f, T, d, sd, df, c, mn, mx, st, ob, ok, rp),
15199+
#define S_INT(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us, sub) \
15200+
SDESC_INT_ROW(f, T, d, sd, df, c, mn, mx, st, ob, ok, rp),
15201+
#define S_INT_NS(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us) \
15202+
SDESC_INT_ROW(f, T, d, sd, df, c, mn, mx, st, ob, ok, rp),
15203+
#define S_FLOAT(f, T, n, d, rnd, sd, df, c, mn, mx, st, ok, rp, us, sub) \
15204+
SDESC_FLOAT_ROW(f, T, d, rnd, sd, df, c, mn, mx, st, ok, rp),
15205+
#define S_FLOAT_NS(f, T, n, d, rnd, sd, df, c, mn, mx, st, ok, rp, us) \
15206+
SDESC_FLOAT_ROW(f, T, d, rnd, sd, df, c, mn, mx, st, ok, rp),
15207+
#include "../settings/settings_def_input_auto_mouse_grab.h"
15208+
#undef S_BOOL
15209+
#undef S_BOOL_NS
15210+
#undef S_UINT
15211+
#undef S_UINT_NS
15212+
#undef S_INT
15213+
#undef S_INT_NS
15214+
#undef S_FLOAT
15215+
#undef S_FLOAT_NS
1519215216
};
1519315217
settings_list_add_desc(list, list_info, settings,
1519415218
inp_desc_8, ARRAY_SIZE(inp_desc_8),

msg_hash.h

Lines changed: 38 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1443,7 +1443,44 @@ enum msg_hash_enums
14431443
#endif
14441444

14451445
MENU_LABEL(INPUT_SENSORS_ENABLE),
1446-
MENU_LABEL(INPUT_AUTO_MOUSE_GRAB),
1446+
/* GENERATED REGION: auto mouse grab setting enum rows (see settings/settings_def_input_auto_mouse_grab.h). */
1447+
#define SETTINGS_DEF_ENUM_PASS
1448+
#define SETTINGS_DEF_STRINGS_PASS
1449+
#define S_BOOL(f, T, n, d, sd, df, c, us, sub) MENU_LABEL(T),
1450+
#define S_BOOL_NS(f, T, n, d, sd, df, c, us) MENU_LABEL(T),
1451+
#define S_UINT(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us, sub) MENU_LABEL(T),
1452+
#define S_UINT_NS(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us) MENU_LABEL(T),
1453+
#define S_INT(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us, sub) MENU_LABEL(T),
1454+
#define S_INT_NS(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us) MENU_LABEL(T),
1455+
#define S_FLOAT(f, T, n, d, rnd, sd, df, c, mn, mx, st, ok, rp, us, sub) MENU_LABEL(T),
1456+
#define S_FLOAT_NS(f, T, n, d, rnd, sd, df, c, mn, mx, st, ok, rp, us) MENU_LABEL(T),
1457+
#define S_BOOL_H(f, T, n, d, sd, df, c, us, sub) MENU_LBL_H(T),
1458+
#define S_UINT_H(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us, sub) MENU_LBL_H(T),
1459+
#define S_BOOL_NS_H(f, T, n, d, sd, df, c, us) MENU_LBL_H(T),
1460+
#define S_INT_H(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us, sub) MENU_LBL_H(T),
1461+
#define S_FLOAT_H(f, T, n, d, rnd, sd, df, c, mn, mx, st, ok, rp, us, sub) MENU_LBL_H(T),
1462+
#define S_UINT_NS_H(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us) MENU_LBL_H(T),
1463+
#define S_INT_NS_H(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us) MENU_LBL_H(T),
1464+
#define S_FLOAT_NS_H(f, T, n, d, rnd, sd, df, c, mn, mx, st, ok, rp, us) MENU_LBL_H(T),
1465+
#include "settings/settings_def_input_auto_mouse_grab.h"
1466+
#undef S_BOOL
1467+
#undef S_BOOL_NS
1468+
#undef S_UINT
1469+
#undef S_UINT_NS
1470+
#undef S_INT
1471+
#undef S_INT_NS
1472+
#undef S_FLOAT
1473+
#undef S_FLOAT_NS
1474+
#undef S_BOOL_H
1475+
#undef S_UINT_H
1476+
#undef S_BOOL_NS_H
1477+
#undef S_INT_H
1478+
#undef S_FLOAT_H
1479+
#undef S_UINT_NS_H
1480+
#undef S_INT_NS_H
1481+
#undef S_FLOAT_NS_H
1482+
#undef SETTINGS_DEF_STRINGS_PASS
1483+
#undef SETTINGS_DEF_ENUM_PASS
14471484

14481485
MENU_LABEL(INPUT_AUTO_GAME_FOCUS),
14491486
MENU_ENUM_LABEL_VALUE_INPUT_AUTO_GAME_FOCUS_OFF,

msg_hash_lbl_str.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,6 @@
445445
#define MENU_ENUM_LABEL_INPUT_AUTODETECT_ENABLE_STR "input_autodetect_enable"
446446
#define MENU_ENUM_LABEL_INPUT_SELECT_PHYSICAL_KEYBOARD_STR "input_android_physical_keyboard"
447447
#define MENU_ENUM_LABEL_INPUT_SENSORS_ENABLE_STR "input_sensors_enable"
448-
#define MENU_ENUM_LABEL_INPUT_AUTO_MOUSE_GRAB_STR "input_auto_mouse_grab"
449448
#define MENU_ENUM_LABEL_INPUT_AUTO_GAME_FOCUS_STR "input_auto_game_focus"
450449
#define MENU_ENUM_LABEL_INPUT_BUTTON_AXIS_THRESHOLD_STR "input_axis_threshold"
451450
#define MENU_ENUM_LABEL_INPUT_ANALOG_DEADZONE_STR "input_analog_deadzone"
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
/* Single-source definitions: auto mouse grab setting.
2+
* Grammar identical to settings_def_video_sync.h plus S_FLOAT and
3+
* the _NS no-sublabel variants; the descriptor argument span
4+
* matches SDESC_<kind>_ROW; row order is menu display order;
5+
* h2json.py parses these rows for the Crowdin source upload. */
6+
7+
S_BOOL(input_auto_mouse_grab, INPUT_AUTO_MOUSE_GRAB,
8+
"input_auto_mouse_grab",
9+
DEFAULT_INPUT_AUTO_MOUSE_GRAB, SD_FLAG_NONE, 0, 0,
10+
"Automatic Mouse Grab",
11+
"Enable mouse grab on application focus.")

0 commit comments

Comments
 (0)