Skip to content

Commit b2239c3

Browse files
libretroadminLibretroAdmin
authored andcommitted
settings: migrate the third main menu action group to a single-source def file
Performed by tools/settings_migrate_group.py with the standard battery including the platform-profile lanes and the integrated enum consolidation stage.
1 parent c7c4ca0 commit b2239c3

7 files changed

Lines changed: 174 additions & 48 deletions

File tree

configuration.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1966,6 +1966,7 @@ static struct config_bool_setting *populate_settings_bool(
19661966
#include "settings/settings_def_video_fullscreen.h"
19671967
#define SETTINGS_DEF_CONFIG_PASS
19681968
#include "settings/settings_def_video_sync.h"
1969+
#include "settings/settings_def_menu_main_actions_3.h"
19691970
#include "settings/settings_def_menu_main_actions_1.h"
19701971
#include "settings/settings_def_user_identity.h"
19711972
#include "settings/settings_def_netplay_passwords.h"
@@ -2442,6 +2443,7 @@ static struct config_float_setting *populate_settings_float(
24422443
#include "settings/settings_def_video_fullscreen.h"
24432444
#define SETTINGS_DEF_CONFIG_PASS
24442445
#include "settings/settings_def_video_sync.h"
2446+
#include "settings/settings_def_menu_main_actions_3.h"
24452447
#include "settings/settings_def_menu_main_actions_1.h"
24462448
#include "settings/settings_def_user_identity.h"
24472449
#include "settings/settings_def_netplay_passwords.h"
@@ -2877,6 +2879,7 @@ static struct config_uint_setting *populate_settings_uint(
28772879
#include "settings/settings_def_video_fullscreen.h"
28782880
#define SETTINGS_DEF_CONFIG_PASS
28792881
#include "settings/settings_def_video_sync.h"
2882+
#include "settings/settings_def_menu_main_actions_3.h"
28802883
#include "settings/settings_def_menu_main_actions_1.h"
28812884
#include "settings/settings_def_user_identity.h"
28822885
#include "settings/settings_def_netplay_passwords.h"
@@ -3288,6 +3291,7 @@ static struct config_int_setting *populate_settings_int(
32883291
#include "settings/settings_def_video_fullscreen.h"
32893292
#define SETTINGS_DEF_CONFIG_PASS
32903293
#include "settings/settings_def_video_sync.h"
3294+
#include "settings/settings_def_menu_main_actions_3.h"
32913295
#include "settings/settings_def_menu_main_actions_1.h"
32923296
#include "settings/settings_def_user_identity.h"
32933297
#include "settings/settings_def_netplay_passwords.h"
@@ -3499,6 +3503,7 @@ static struct config_int_setting *populate_settings_int(
34993503
#include "settings/settings_def_video_fullscreen.h"
35003504
#define SETTINGS_DEF_CONFIG_PASS
35013505
#include "settings/settings_def_video_sync.h"
3506+
#include "settings/settings_def_menu_main_actions_3.h"
35023507
#include "settings/settings_def_menu_main_actions_1.h"
35033508
#include "settings/settings_def_user_identity.h"
35043509
#include "settings/settings_def_netplay_passwords.h"

intl/msg_hash_lbl.h

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -2080,20 +2080,6 @@ MSG_HASH(
20802080
MENU_ENUM_LABEL_LOAD_CONTENT_HISTORY,
20812081
MENU_ENUM_LABEL_LOAD_CONTENT_HISTORY_STR
20822082
)
2083-
MSG_HASH(
2084-
MENU_ENUM_LABEL_LOAD_DISC,
2085-
MENU_ENUM_LABEL_LOAD_DISC_STR
2086-
)
2087-
MSG_HASH(
2088-
MENU_ENUM_LABEL_DUMP_DISC,
2089-
MENU_ENUM_LABEL_DUMP_DISC_STR
2090-
)
2091-
#ifdef HAVE_LAKKA
2092-
MSG_HASH(
2093-
MENU_ENUM_LABEL_EJECT_DISC,
2094-
MENU_ENUM_LABEL_EJECT_DISC_STR
2095-
)
2096-
#endif
20972083
MSG_HASH(
20982084
MENU_ENUM_LABEL_LOAD_CONTENT_SPECIAL,
20992085
MENU_ENUM_LABEL_LOAD_CONTENT_SPECIAL_STR

intl/msg_hash_us.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -549,6 +549,7 @@ static const char *const msg_hash_us_lbl_strs[] = {
549549
#define S_ACTION_NS(T, n, us) n,
550550
#include "../settings/settings_def_video_fullscreen.h"
551551
#include "../settings/settings_def_video_sync.h"
552+
#include "../settings/settings_def_menu_main_actions_3.h"
552553
#include "../settings/settings_def_menu_main_actions_1.h"
553554
#include "../settings/settings_def_user_identity.h"
554555
#include "../settings/settings_def_netplay_passwords.h"
@@ -687,6 +688,7 @@ static const uint32_t msg_hash_us_lbl_ids[] = {
687688
#define S_ACTION_NS(T, n, us) (uint32_t)MENU_ENUM_LABEL_##T,
688689
#include "../settings/settings_def_video_fullscreen.h"
689690
#include "../settings/settings_def_video_sync.h"
691+
#include "../settings/settings_def_menu_main_actions_3.h"
690692
#include "../settings/settings_def_menu_main_actions_1.h"
691693
#include "../settings/settings_def_user_identity.h"
692694
#include "../settings/settings_def_netplay_passwords.h"

intl/msg_hash_us.h

Lines changed: 74 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -175,32 +175,80 @@ MSG_HASH(
175175
MENU_ENUM_LABEL_HELP_LOAD_CONTENT_LIST,
176176
"Browse for content. To load content, you need a 'Core' to use, and a content file.\nTo control where the menu starts to browse for content, set 'File Browser Directory'. If not set, it will start in root.\nThe browser will filter out extensions for the last core set in 'Load Core', and use that core when content is loaded."
177177
)
178-
MSG_HASH(
179-
MENU_ENUM_LABEL_VALUE_LOAD_DISC,
180-
"Load Disc"
181-
)
182-
MSG_HASH(
183-
MENU_ENUM_SUBLABEL_LOAD_DISC,
184-
"Load a physical media disc. First select the core (Load Core) to use with the disc."
185-
)
186-
MSG_HASH(
187-
MENU_ENUM_LABEL_VALUE_DUMP_DISC,
188-
"Dump Disc"
189-
)
190-
MSG_HASH( /* FIXME Is a specific image format used? Is it determined automatically? User choice? */
191-
MENU_ENUM_SUBLABEL_DUMP_DISC,
192-
"Dump the physical media disc to internal storage. It will be saved as an image file."
193-
)
194-
#ifdef HAVE_LAKKA
195-
MSG_HASH(
196-
MENU_ENUM_LABEL_VALUE_EJECT_DISC,
197-
"Eject Disc"
198-
)
199-
MSG_HASH(
200-
MENU_ENUM_SUBLABEL_EJECT_DISC,
201-
"Ejects the disc from physical CD/DVD drive."
202-
)
203-
#endif
178+
/* GENERATED REGION: third main menu action group (see settings_def_menu_main_actions_3.h). */
179+
#define SETTINGS_DEF_STRINGS_PASS
180+
#define S_BOOL(f, T, n, d, sd, df, c, us, sub) \
181+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us) \
182+
MSG_HASH(MENU_ENUM_SUBLABEL_##T, sub)
183+
#define S_BOOL_NS(f, T, n, d, sd, df, c, us) \
184+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us)
185+
#define S_UINT(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us, sub) \
186+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us) \
187+
MSG_HASH(MENU_ENUM_SUBLABEL_##T, sub)
188+
#define S_UINT_NS(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us) \
189+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us)
190+
#define S_INT(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us, sub) \
191+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us) \
192+
MSG_HASH(MENU_ENUM_SUBLABEL_##T, sub)
193+
#define S_INT_NS(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us) \
194+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us)
195+
#define S_FLOAT(f, T, n, d, rnd, sd, df, c, mn, mx, st, ok, rp, us, sub) \
196+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us) \
197+
MSG_HASH(MENU_ENUM_SUBLABEL_##T, sub)
198+
#define S_FLOAT_NS(f, T, n, d, rnd, sd, df, c, mn, mx, st, ok, rp, us) \
199+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us)
200+
#define S_STRING(f, T, n, d, sd, c, ok, rp, sta, sel, lf, rt, ui, us, sub) \
201+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us) \
202+
MSG_HASH(MENU_ENUM_SUBLABEL_##T, sub)
203+
#define S_STRING_NS(f, T, n, d, sd, c, ok, rp, sta, sel, lf, rt, ui, us) \
204+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us)
205+
#define S_DIR(f, T, n, d, el, sd, c, sta, us, sub) \
206+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us) \
207+
MSG_HASH(MENU_ENUM_SUBLABEL_##T, sub)
208+
#define S_DIR_NS(f, T, n, d, el, sd, c, sta, us) \
209+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us)
210+
#define S_STRING_P(f, T, n, d, sd, c, ok, rp, sta, sel, lf, rt, ui, us, sub) \
211+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us) \
212+
MSG_HASH(MENU_ENUM_SUBLABEL_##T, sub)
213+
#define S_STRING_P_NS(f, T, n, d, sd, c, ok, rp, sta, sel, lf, rt, ui, us) \
214+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us)
215+
#define S_PATH(f, T, n, d, sd, c, vals, rp, ui, us, sub) \
216+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us) \
217+
MSG_HASH(MENU_ENUM_SUBLABEL_##T, sub)
218+
#define S_PATH_NS(f, T, n, d, sd, c, vals, rp, ui, us) \
219+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us)
220+
#define S_PATH_DS(f, T, n, df2, sd, c, vals, rp, ui, us, sub) \
221+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us) \
222+
MSG_HASH(MENU_ENUM_SUBLABEL_##T, sub)
223+
#define S_PATH_DS_NS(f, T, n, df2, sd, c, vals, rp, ui, us) \
224+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us)
225+
#define S_ACTION(T, n, us, sub) \
226+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us) \
227+
MSG_HASH(MENU_ENUM_SUBLABEL_##T, sub)
228+
#define S_ACTION_NS(T, n, us) \
229+
MSG_HASH(MENU_ENUM_LABEL_VALUE_##T, us)
230+
#include "../settings/settings_def_menu_main_actions_3.h"
231+
#undef S_BOOL
232+
#undef S_BOOL_NS
233+
#undef S_UINT
234+
#undef S_UINT_NS
235+
#undef S_INT
236+
#undef S_INT_NS
237+
#undef S_FLOAT
238+
#undef S_FLOAT_NS
239+
#undef S_STRING
240+
#undef S_STRING_NS
241+
#undef S_DIR
242+
#undef S_DIR_NS
243+
#undef S_STRING_P
244+
#undef S_STRING_P_NS
245+
#undef S_PATH
246+
#undef S_PATH_NS
247+
#undef S_PATH_DS
248+
#undef S_PATH_DS_NS
249+
#undef S_ACTION
250+
#undef S_ACTION_NS
251+
#undef SETTINGS_DEF_STRINGS_PASS
204252
MSG_HASH(
205253
MENU_ENUM_LABEL_VALUE_PLAYLISTS_TAB,
206254
"Playlists"

menu/menu_setting.c

Lines changed: 62 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -11188,11 +11188,68 @@ static bool setting_append_list(
1118811188
{
1118911189
{
1119011190
static const setting_desc_t mm_desc_4[] = {
11191-
SDESC_ACTION_ROW(LOAD_DISC),
11192-
SDESC_ACTION_ROW(DUMP_DISC),
11193-
#ifdef HAVE_LAKKA
11194-
SDESC_ACTION_ROW(EJECT_DISC),
11195-
#endif
11191+
/* GENERATED: rows come from settings_def_menu_main_actions_3.h in order. */
11192+
#define S_BOOL(f, T, n, d, sd, df, c, us, sub) \
11193+
SDESC_BOOL_ROW(f, T, d, sd, df, c),
11194+
#define S_BOOL_NS(f, T, n, d, sd, df, c, us) \
11195+
SDESC_BOOL_ROW(f, T, d, sd, df, c),
11196+
#define S_UINT(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us, sub) \
11197+
SDESC_UINT_ROW(f, T, d, sd, df, c, mn, mx, st, ob, ok, rp),
11198+
#define S_UINT_NS(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us) \
11199+
SDESC_UINT_ROW(f, T, d, sd, df, c, mn, mx, st, ob, ok, rp),
11200+
#define S_INT(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us, sub) \
11201+
SDESC_INT_ROW(f, T, d, sd, df, c, mn, mx, st, ob, ok, rp),
11202+
#define S_INT_NS(f, T, n, d, sd, df, c, mn, mx, st, ob, ok, rp, us) \
11203+
SDESC_INT_ROW(f, T, d, sd, df, c, mn, mx, st, ob, ok, rp),
11204+
#define S_FLOAT(f, T, n, d, rnd, sd, df, c, mn, mx, st, ok, rp, us, sub) \
11205+
SDESC_FLOAT_ROW(f, T, d, rnd, sd, df, c, mn, mx, st, ok, rp),
11206+
#define S_FLOAT_NS(f, T, n, d, rnd, sd, df, c, mn, mx, st, ok, rp, us) \
11207+
SDESC_FLOAT_ROW(f, T, d, rnd, sd, df, c, mn, mx, st, ok, rp),
11208+
#define S_STRING(f, T, n, d, sd, c, ok, rp, sta, sel, lf, rt, ui, us, sub) \
11209+
SDESC_STRING_ROW(f, T, d, sd, c, ok, rp, sta, sel, lf, rt, ui),
11210+
#define S_STRING_NS(f, T, n, d, sd, c, ok, rp, sta, sel, lf, rt, ui, us) \
11211+
SDESC_STRING_ROW(f, T, d, sd, c, ok, rp, sta, sel, lf, rt, ui),
11212+
#define S_DIR(f, T, n, d, el, sd, c, sta, us, sub) \
11213+
SDESC_DIR_ROW(f, T, d, el, sd, c, sta),
11214+
#define S_DIR_NS(f, T, n, d, el, sd, c, sta, us) \
11215+
SDESC_DIR_ROW(f, T, d, el, sd, c, sta),
11216+
#define S_STRING_P(f, T, n, d, sd, c, ok, rp, sta, sel, lf, rt, ui, us, sub) \
11217+
SDESC_STRING_ROW_P(f, T, d, sd, c, ok, rp, sta, sel, lf, rt, ui),
11218+
#define S_STRING_P_NS(f, T, n, d, sd, c, ok, rp, sta, sel, lf, rt, ui, us) \
11219+
SDESC_STRING_ROW_P(f, T, d, sd, c, ok, rp, sta, sel, lf, rt, ui),
11220+
#define S_PATH(f, T, n, d, sd, c, vals, rp, ui, us, sub) \
11221+
SDESC_PATH_ROW(f, T, d, sd, c, vals, rp, ui),
11222+
#define S_PATH_NS(f, T, n, d, sd, c, vals, rp, ui, us) \
11223+
SDESC_PATH_ROW(f, T, d, sd, c, vals, rp, ui),
11224+
#define S_PATH_DS(f, T, n, df2, sd, c, vals, rp, ui, us, sub) \
11225+
SDESC_PATH_ROW_DS(f, T, df2, sd, c, vals, rp, ui),
11226+
#define S_PATH_DS_NS(f, T, n, df2, sd, c, vals, rp, ui, us) \
11227+
SDESC_PATH_ROW_DS(f, T, df2, sd, c, vals, rp, ui),
11228+
#define S_ACTION(T, n, us, sub) \
11229+
SDESC_ACTION_ROW(T),
11230+
#define S_ACTION_NS(T, n, us) \
11231+
SDESC_ACTION_ROW(T),
11232+
#include "../settings/settings_def_menu_main_actions_3.h"
11233+
#undef S_BOOL
11234+
#undef S_BOOL_NS
11235+
#undef S_UINT
11236+
#undef S_UINT_NS
11237+
#undef S_INT
11238+
#undef S_INT_NS
11239+
#undef S_FLOAT
11240+
#undef S_FLOAT_NS
11241+
#undef S_STRING
11242+
#undef S_STRING_NS
11243+
#undef S_DIR
11244+
#undef S_DIR_NS
11245+
#undef S_STRING_P
11246+
#undef S_STRING_P_NS
11247+
#undef S_PATH
11248+
#undef S_PATH_NS
11249+
#undef S_PATH_DS
11250+
#undef S_PATH_DS_NS
11251+
#undef S_ACTION
11252+
#undef S_ACTION_NS
1119611253
};
1119711254
settings_list_add_desc(list, list_info, settings,
1119811255
mm_desc_4, ARRAY_SIZE(mm_desc_4),

msg_hash_lbl_str.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -524,9 +524,6 @@
524524
#define MENU_ENUM_LABEL_LOAD_ARCHIVE_STR "load_archive"
525525
#define MENU_ENUM_LABEL_LOAD_ARCHIVE_DETECT_CORE_STR "load_archive_detect_core"
526526
#define MENU_ENUM_LABEL_LOAD_CONTENT_HISTORY_STR "load_recent"
527-
#define MENU_ENUM_LABEL_LOAD_DISC_STR "load_disc"
528-
#define MENU_ENUM_LABEL_DUMP_DISC_STR "dump_disc"
529-
#define MENU_ENUM_LABEL_EJECT_DISC_STR "eject_disc"
530527
#define MENU_ENUM_LABEL_LOAD_CONTENT_SPECIAL_STR "load_special"
531528
#define MENU_ENUM_LABEL_LOAD_CONTENT_LIST_STR "load_content"
532529
#define MENU_ENUM_LABEL_LOAD_STATE_STR "load_state"
Lines changed: 31 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
/* Single-source definitions: third main menu action group.
2+
* Grammar identical to settings_def_video_sync.h plus S_FLOAT and
3+
* the _NS no-sublabel variants; the descriptor argument span
4+
* matches SDESC_<kind>_ROW; row order is menu display order;
5+
* h2json.py parses these rows for the Crowdin source upload. */
6+
7+
/* Descriptor and configuration rows are #ifdef HAVE_CDROM; the string
8+
* tables always carry this row via the strings pass. */
9+
#if defined(HAVE_CDROM) || defined(SETTINGS_DEF_STRINGS_PASS)
10+
S_ACTION(LOAD_DISC,
11+
"load_disc",
12+
"Load Disc",
13+
"Load a physical media disc. First select the core (Load Core) to use with the disc.")
14+
#endif
15+
/* Descriptor and configuration rows are #ifdef HAVE_CDROM; the string
16+
* tables always carry this row via the strings pass. */
17+
#if defined(HAVE_CDROM) || defined(SETTINGS_DEF_STRINGS_PASS)
18+
/* FIXME Is a specific image format used? Is it determined automatically? User choice? */
19+
S_ACTION(DUMP_DISC,
20+
"dump_disc",
21+
"Dump Disc",
22+
"Dump the physical media disc to internal storage. It will be saved as an image file.")
23+
#endif
24+
#ifdef HAVE_CDROM
25+
#ifdef HAVE_LAKKA
26+
S_ACTION(EJECT_DISC,
27+
"eject_disc",
28+
"Eject Disc",
29+
"Ejects the disc from physical CD/DVD drive.")
30+
#endif
31+
#endif

0 commit comments

Comments
 (0)