fix GLES/GL shared contexts define, move serialization instead#19169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Guidelines
C89_BUILD=1Description
This PR #19161 changed the ID for RETRO_ENVIRONMENT_SET_HW_SHARED_CONTEXT and RETRO_ENVIRONMENT_SET_SERIALIZATION_QUIRKS, however in doing so all cores that supported GL/GLES shared contexts e.g. dolphin were broken.
Lets move RETRO_ENVIRONMENT_SET_SERIALIZATION_QUIRKS instead as its less important.
Related Issues
Related Pull Requests
Reviewers