Generate xml DAT messes up video

[mahoneyt944]

While playing wrestwar, I generated a DAT file and when I returned to the game the graphics were messed up. I generate lot of these regularly so something with this game and some others in the driver in particular have this issue for me. Can anyone replicate this issue?

[arcadez2003]

Well if i could help ya big man i would but not using this core personally means im snookered ;)

[grant2258]

All you need to to is add machine reset when the dat is finished. You might get away with expanding the original machine driver as well instead of a reset. If you want to debug it youll need to go over the constructor of the driver it was never intended to be called while a game is running.

[mahoneyt944]

I don't see why creating this file should affect the current game while it's in a pause_action unless it's changing driver properties while it executes? Maybe that's the case here? I thought it was just checking for properties not applying them. Info.c should probably execute itself in a sandbox like environment situation if that's the case.

[grant2258]

anything using expand_machine_driver causes it. A reset after should reset any possible demons changed, you would have to debug the expand constructed and the video update is int called during pause now. So you can rule that one out it nothing to do with the pause this will likely still happen before you pause changes.

Its worth noting I done a fix very early on in that affected dats by the samples s by disabling optimizations on the samples code. It only happened on 64bit when creating the dat as some games crashed back then not just distort gfx.

I see someones changed the code so not sure what changed or is some games still crash as its removed. You could try a push - pop optimizations the function that use expand_machine_driver because there is more of them now than there used to be.

update creating the dat calls the games video_update a few times

[mahoneyt944]

update creating the dat calls the games video_update a few times

That has to be what's effecting wrestwar

[grant2258]

Has no ill effects unless you call using expand_machine_driver() youll need to trace it or simple reset after the dat creation

[mahoneyt944]

Interesting, I'll peak through that then

[mahoneyt944]

So when it uses expand_machine_driver() what's causing the issue? The memset? Or is it changing references that the current running game is actively using?

simple reset after the dat creation

Resetting the core in RA does not fix wrestwar. It needs a full reboot. But I still think sandboxing expand_machine_driver() or another underlying issues would just allow everything to work without the need to reset.

[grant2258]

reset works fine from the menu or in the code. Not sure where the issue is to be honest would need need to debug it with gdb to trace it properly. You need to see whats calling video code calling the video update in the dat creation that the first point you need to debug and its not expand machine calling it. You might need to make the dat creation a pause action as well could be that simple.

[mahoneyt944]

It's already in a pause action, since the mame menu is open.

[grant2258]

Well clearly somethings calling it

INFO] [Environ]: SET_MESSAGE: Generating XML DAT
VIDEO_UPDATE( system16 )called
start xml
close xml
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called
VIDEO_UPDATE( system16 )called

[mahoneyt944]

That's probably updatescreen() which is what pause action uses. I don't think that's the issue though, to verify use the commit that blacks the menu screen instead of drawing

mame2003-plus-libretro/src/mame.c

Line 1185 in 5f5e325

int updatescreen(void)

[grant2258]

Either way the pre pause changes ran the video update like we currently are and its only causing issues when he expand is called so its something in there that's causing the issue that hasn't changed. The code is probably called regardless the way the menu imposes over game screen. This isint a new issue it will be on the pre pause code you added as well.

[mahoneyt944]

Yeah it's definitely an old bug I actually noticed this bug when all the system16 updates were happening but wasn't too concerned then. Would be nice to fix it though.

[grant2258]

The code was meant to run from the command line so its probably something initializing differently. Personally if it bothers you id say go for fixing it. When I make a dat I usually quitting to use the dat anyway.