Allow S to create bulk changes of merge type (#1666)

---------

Co-authored-by: Olov Ylinenpää <[email protected]>

Author: lrosenstrom

rest/src/main/groovy/whelk/rest/security/AccessControl.java

@@ -5,6 +5,7 @@
 import whelk.Document;
 import whelk.JsonLd;
 import whelk.datatool.bulkchange.BulkAccessControl;
+import whelk.datatool.bulkchange.BulkJobDocument;
 import whelk.exception.ModelValidationException;
 import whelk.util.LegacyIntegrationTools;
 
@@ -13,6 +14,7 @@
 import java.util.Optional;
 
 import static whelk.datatool.bulkchange.BulkJobDocument.JOB_TYPE;
+import static whelk.datatool.bulkchange.BulkJobDocument.SpecType.Merge;
 
 public class AccessControl {
     private static final Logger log = LogManager.getLogger(AccessControl.class);
@@ -86,7 +88,13 @@ else if (document.getThingType().equals("ShelfMarkSequence")) {
         else if ((document.getThingType().equals(JOB_TYPE))) {
             // TODO step 1, new specific sigel instead
             // TODO step 2, configure as permission on user instead (in libris login)
-            return hasPermissionForSigel("SEK", userPrivileges);
+
+            var bulkDoc = new BulkJobDocument(document);
+            if (bulkDoc.getSpecificationType().equals(Merge)) {
+                return hasPermissionForSigel("S", userPrivileges) || hasPermissionForSigel("SEK", userPrivileges);
+            } else {
+                return hasPermissionForSigel("SEK", userPrivileges);
+            }
         }
         else if (document.isInReadOnlyDataset()) {
             return false;

whelktool/src/main/java/whelk/datatool/bulkchange/BulkJobDocument.java

@@ -151,14 +151,16 @@ public void addExecution(ZonedDateTime endTime, Status status, List<String> repo
         _set(EXECUTION_PATH, executions, data);
     }
 
-    public Specification getSpecification() {
+    public SpecType getSpecificationType() {
         Map<String, Object> spec = getSpecificationRaw();
         if (spec == null) {
             throw new ModelValidationException("Nothing in " + SPECIFICATION_PATH);
         }
+        return fromKey(SpecType.class, get(spec, JsonLd.TYPE_KEY));
+    }
 
-        String specType = get(spec, JsonLd.TYPE_KEY);
-        return switch(fromKey(SpecType.class, specType)) {
+    public Specification getSpecification() {
+        return switch(getSpecificationType()) {
             case SpecType.Update -> new Specification.Update(
                     get(spec, MATCH_FORM_KEY, Collections.emptyMap()),
                     get(spec, TARGET_FORM_KEY, Collections.emptyMap())