Skip to content

wayland: Uncomment support for wl_display_reconnect #6531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flibitijibibo
Copy link
Collaborator

Finally a self-explanatory commit! This is the commit that will enable the reconnect support currently being reviewed here: https://gitlab.freedesktop.org/wayland/wayland/-/merge_requests/283

Fixes #6213

@slouken
Copy link
Collaborator

slouken commented Aug 6, 2024

The upstream MR was closed, is this still relevant?

@flibitijibibo
Copy link
Collaborator Author

Good question - @davidedmundson, is there anything from this PR we need to support the current solution for compositor handoffs?

@1ace
Copy link
Contributor

1ace commented Mar 18, 2025

I was curious about this just now, so I dug a bit, and @davidedmundson's branch looks very different from this PR; for posterity, the current HEAD commit is davidedmundson@140564d

I'm hoping this feature can eventually land, as it's really useful. Maybe if David can't work on it anymore, someone else can take over, starting with that commit, and get it through the finish line?

@1ace
Copy link
Contributor

1ace commented Mar 18, 2025

I just realized that's relying on eglBindClientWaylandDisplayWL from the extension EGL_WL_bind_client_wayland_display which doesn't exist yet (not published anywhere as far as ddg or google can tell), so I guess someone taking over would have to write an extension spec based on the behaviour of the current implementation, which is weird but not impossible... but it's definitely simpler if @davidedmundson you simply publish it 😝

I did a quick read through the mesa implementation of that new function, and it looks reasonable to me :)
(we have done a bunch of work around that code recently so a non-trivial rebase is needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Wayland] Add support for reconnects when the compositor restarts
3 participants