Emscripten: device rotation doesn't emit resize events

[ericoporto]

I think emscripten_set_orientationchange_callback should be included in src/video/emscripten/SDL_emscriptenevents.c, so it can generate a resize event.

See Device Orientation in Emscripten API documentation.

As is now, rotating the device doesn't produce any event, so even though the canvas css size changes, this isn't update inside SDL, and the application can't get a window resize event.

I tried this workaround below, but it didn't work, no SDL resize event is generated on orientation changed - but listening to the resize event in JS I can see it indeed happens.

window.addEventListener("orientationchange", function() {
    window.dispatchEvent(new Event("resize"));
  }, false);

You can use chrome://inspect#devices for remote debugging from chrome, if using an Android device.

To be honest, rotation and resizing for me are different things, but from the comment here, it seems it's settled they should be the same, so at least the events should be produced here - or alternatively some rotation event.

[ericoporto]

I think orientation hints are also not working - I wonder if I am doing something wrong or they are just not being used by Emscripten platform.

https://developer.mozilla.org/en-US/docs/Web/API/ScreenOrientation/lock

• lock only works in fullscreen
• when no hint is set, we probably don't want to lock (I believe itch locks in Fullscreen landscape, if width bigger than height, on mobile)
• desktop browsers probably don't support lock