Add userdata argument to Mix_ChannelFinished callback
#689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This breaks ABI on the existing library, so I probably wouldn't merge this. (In the in-progress rewrite, this has a userdata argument already.) |
|
I thought the major release 3.0 was the right moment to break ABI. Where is the in-progress rewrite btw? I wanted to help because I use SDL3 and wished for SDL3_mixer, but I see no clear communication on the subject. |
The redesign is being discussed over in #662, and the work-in-progress is temporarily at https://github.com/icculus/SDL_remixer. Definitely check it out and give feedback, all current decisions are still able to change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #161