MSVC_RUNTIME_LIBRARY value 'MultiThreadedDLL' not known for this ASM

[TakWolf]

CMake Error in cmake-build-release/_deps/sdl3_mixer-src/external/wavpack/CMakeLists.txt:
  MSVC_RUNTIME_LIBRARY value 'MultiThreadedDLL' not known for this ASM
  compiler.

Windows 10
Visual Studio/2022/Community
Use the latest node: de0f62a

include(FetchContent)

FetchContent_Declare(SDL3
        GIT_REPOSITORY https://github.com/libsdl-org/SDL.git
        GIT_TAG 3a219caf3da11df9feed819be6d2b08c10d44cfc
)
FetchContent_MakeAvailable(SDL3)

FetchContent_Declare(SDL3_mixer
        GIT_REPOSITORY https://github.com/libsdl-org/SDL_mixer.git
        GIT_TAG de0f62abbcb41c64e0cb1045a521e2deeb562fb7
)
FetchContent_MakeAvailable(SDL3_mixer)

add_executable(${PROJECT_NAME}
        src/main.cpp
)
target_link_libraries(${PROJECT_NAME} PRIVATE SDL3::SDL3)
target_link_libraries(${PROJECT_NAME} PRIVATE SDL3_mixer::SDL3_mixer)
target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_23)

[TakWolf]

It seems to be related to the shared libraries build.

Use the following options will not generate errors. (it has also become a static link)

set(BUILD_SHARED_LIBS OFF)
set(SDL_SHARED OFF)
set(SDL_STATIC ON)
set(SDL3MIXER_VENDORED OFF)

[icculus]

I'm not sure who's bug this is (CMake itself should know that the assembler doesn't use MSVC_RUNTIME_LIBRARY? wavpack should change something in their CMake code? etc).

I don't think this is an SDL_mixer issue, though...@madebr, do you agree? I could be totally wrong.

[madebr]

I don't think this is an SDL_mixer issue, though...@madebr, do you agree? I could be totally wrong.

Yes, it's something about wavpack's CMakeLists.txt.

@TakWolf I'm trying out things, does applying this patch change anything?

--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -33,10 +33,10 @@ endif()
 
 include(CheckLanguage)
 
-check_language(ASM)
-if(CMAKE_ASM_COMPILER)
-  enable_language(ASM)
-endif()
+#check_language(ASM)
+#if(CMAKE_ASM_COMPILER)
+#  enable_language(ASM)
+#endif()
 
 if(MSVC)
   if(WavPack_CPU_X86 OR WavPack_CPU_X64)

[icculus]

Going to bump this to a later milestone, as we're running out of time for the initial release, and it's not really fair to expect @TakWolf to have a quick reply to something originally reported two years ago.

(But if you do happen to have a chance to look at this again, we would love to hear if this patch resolves it!)

[TakWolf]

@icculus
Sorry for the late reply.
Since this issue has been going on for a long time and I have lost the context, I am not sure if I can still restore the previous environment. I will try it out

[icculus]

No worries if you can't trivially reproduce it, it'll pop again when someone else stumbles into it.