fix dump bug (#700)

* fix quote col name in dump

* add regression test

Author: MarinPostma

sqld/src/connection/dump/exporter.rs

@@ -84,7 +84,7 @@ impl<W: Write> DumpState<W> {
 
                 let mut iter = colss.iter().peekable();
                 while let Some(col) = iter.next() {
-                    write!(&mut select, "{col}")?;
+                    write!(&mut select, "{}", Quoted(col))?;
                     if iter.peek().is_some() {
                         select.push(',');
                     }
@@ -462,6 +462,9 @@ AND type IN ('index','trigger','view')";
 
 #[cfg(test)]
 mod test {
+    use rusqlite::Connection;
+    use tempfile::tempdir;
+
     use super::*;
 
     #[test]
@@ -487,4 +490,16 @@ mod test {
         assert_eq!("X'68656c6c6f0a'", Blob(b"hello\n").to_string());
         assert_eq!("X''", Blob(b"").to_string());
     }
+
+    #[test]
+    fn table_col_is_keyword() {
+        let tmp = tempdir().unwrap();
+        let conn = Connection::open(tmp.path().join("data")).unwrap();
+        conn.execute(r#"create table test ("limit")"#, ()).unwrap();
+
+        let mut out = Vec::new();
+        export_dump(conn, &mut out).unwrap();
+
+        insta::assert_snapshot!(std::str::from_utf8(&out).unwrap());
+    }
 }

sqld/src/connection/dump/snapshots/sqld__connection__dump__exporter__test__table_col_is_keyword.snap

@@ -0,0 +1,10 @@
+---
+source: sqld/src/connection/dump/exporter.rs
+expression: "std::str::from_utf8(&out).unwrap()"
+---
+PRAGMA foreign_keys=OFF;
+BEGIN TRANSACTION;
+CREATE TABLE IF NOT EXISTS libsql_wasm_func_table (name text PRIMARY KEY, body text) WITHOUT ROWID;
+CREATE TABLE IF NOT EXISTS test ("limit");
+COMMIT;
+

sqld/src/http/user/dump.rs

@@ -55,7 +55,10 @@ where
                             *this.join_handle = Some(join_handle);
                             task::Poll::Pending
                         }
-                        task::Poll::Ready(Ok(Err(err))) => task::Poll::Ready(Some(Err(err))),
+                        task::Poll::Ready(Ok(Err(err))) => {
+                            tracing::error!("error creating dump: {err}");
+                            task::Poll::Ready(Some(Err(err)))
+                        }
                         task::Poll::Ready(Err(err)) => {
                             task::Poll::Ready(Some(Err(anyhow::anyhow!(err)
                                 .context("Dump task crashed")